Bug 134166 - Page style direction change not immediately applied to toolbar direction buttons
Summary: Page style direction change not immediately applied to toolbar direction buttons
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Jonathan Clark
URL:
Whiteboard: target:25.2.0
Keywords:
Depends on:
Blocks: RTL-UI
  Show dependency treegraph
 
Reported: 2020-06-20 10:31 UTC by Eyal Rozenberg
Modified: 2024-10-03 08:22 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2020-06-20 10:31:22 UTC
Reproduction:

(I'm using LO writer with a Hebrew locale and English UI, not sure if that matters.)

1. Create a new document.
2. Sanity check: your paragraph style should be Default Paragraph Style; your paragraph style's direction should be inherit (i.e. "use superordinate object settings"); your page style should be Default Page Style.
3. Enter one word in an RTL language and another in an LTR language, e.g. "שלום Hello" (without the parentheses).
4. Place the cursor within that first paragraph.
5. Sanity check: Toolbar direction buttons have the same direction pressed as the Default Page Style's direction setting.
6. Switch the Default Page Style's direction setting (i.e. if it was LTR make it RTL and vice-versa)

Result: 

* Word order is switched - indicating that the paragraph style has switched.
* Toolbar direction buttons unchanged! Same button is pressed as was before.
* If you re-place your cursor (e.g. click somewhere else within that first paragraph, direction buttons get updated to correct setting.



PS - This bug made me mistakenly believe that inherited-paragraph-direction was not inherited from the page style settings... (bug 133816).
Comment 1 Buovjaga 2020-10-30 13:25:46 UTC
Reproduced

Arch Linux 64-bit
Version: 7.1.0.0.alpha1+
Build ID: 1a4ae360d06ae300a8fd5482b3b3a86dc021750d
CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 30 October 2020
Comment 2 Buovjaga 2020-10-30 13:30:53 UTC
Same problem in 4.4.7, 3.3.0 (Win 10)
Comment 3 QA Administrators 2022-10-31 03:33:24 UTC Comment hidden (obsolete)
Comment 4 Eyal Rozenberg 2022-10-31 08:32:14 UTC
Bug still manifests with:

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2486d99c6053af1414117faac2c0db18c0d344c4
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US
Comment 5 Eyal Rozenberg 2024-09-26 21:06:41 UTC
This is not minor, this is bad bad bad - for newbie users. Confusing them with incorrect direction indication makes  develop an incorrect perception of what buttons do, what keyboard shortcuts do, what alignment vs direction mean... bad 

:-((In reply to Eyal Rozenberg from comment #0)
> "שלום Hello" (without the parentheses).

I mean to say, without the double-quotes of course.
Comment 6 Jonathan Clark 2024-10-01 23:49:23 UTC
This bug seems temperamental.

I was able to reproduce it with the following:

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2486d99c6053af1414117faac2c0db18c0d344c4
CPU threads: 32; OS: Linux 6.8; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6d949b587b192ca572c187c1131e2a8947269337
CPU threads: 32; OS: Linux 6.8; UI render: default; VCL: qt5 (cairo+wayland)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6d949b587b192ca572c187c1131e2a8947269337
CPU threads: 32; OS: Linux 6.8; UI render: default; VCL: qt6 (cairo+wayland)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

However, I could not reproduce it with:

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2486d99c6053af1414117faac2c0db18c0d344c4
CPU threads: 32; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

(The config from Comment 4.)

Version: 24.2.6.2 (X86_64) / LibreOffice Community
Build ID: 8e9a753d9daaea75c34b417ba1bdf556bf2fc5b3
CPU threads: 32; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6d949b587b192ca572c187c1131e2a8947269337
CPU threads: 32; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6d949b587b192ca572c187c1131e2a8947269337
CPU threads: 32; OS: Linux 6.8; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

(The x11 plugin exhibited the bug in 7.5.)
Comment 7 Commit Notification 2024-10-03 04:20:18 UTC
Jonathan Clark committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3937143065b00fc0ec5709a41c2135c19a11fc4b

tdf#134166 sw: Fixed RTL/LTR toolbar buttons not updating

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Eyal Rozenberg 2024-10-03 08:22:19 UTC
(In reply to Commit Notification from comment #7)

Thanks, Jonathan :-)

I hope I have the time to try this out before the conference; if I haven't - someone please ping me