Bug 134552 - EDITING Calc custom row height not applied with very large spreadsheets
Summary: EDITING Calc custom row height not applied with very large spreadsheets
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4
Keywords: bibisected, bisected, regression
: 148151 148944 (view as bug list)
Depends on:
Blocks: Regressions-1024plus-Columns
  Show dependency treegraph
 
Reported: 2020-07-06 11:01 UTC by NISZ LibreOffice Team
Modified: 2022-05-11 11:40 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Calc 6.4 (10.02 KB, application/vnd.oasis.opendocument.spreadsheet)
2020-07-06 11:01 UTC, NISZ LibreOffice Team
Details
Screenshot of the problem in Calc without and with very large sheets support (186.09 KB, image/png)
2020-07-06 11:06 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2020-07-06 11:01:11 UTC
Created attachment 162696 [details]
Example file from Calc 6.4

Attached document contains a simple Calc table with some data and the first row having a custom row height set.
When opening in newer Calc versions with support for very large spreadsheets enabled the custom height is not interpreted correctly, making the second rows content slip into the first rows.

Steps to reproduce:
    1. Enable Experimental features, then Calc – Defaults – Enable very large spreadsheets
    2. Open attached document

Actual results:
Second rows text slips into the first row.

Expected results:
Separate rows texts show up in separate rows.

LibreOffice details:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 9af38b4504ccda57a0c32eb8bdd03e5a8ca29ddc
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

Bibisected using bibisect-win64-6.5 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=afad9ccb381a02b90654a5fa302480e46f38a1fc 

author: Noel Grandin <noel.grandin@collabora.co.uk> Thu Dec 12 16:49:19 2019 +0200 
committer: Noel Grandin <noel.grandin@collabora.co.uk> Fri Dec 13 07:04:49 2019 +0100 

sc: rowcol: tdf#50916 pass ScDocument* around in data/

Adding CC to: Noel Grandin
Comment 1 NISZ LibreOffice Team 2020-07-06 11:06:11 UTC
Created attachment 162697 [details]
Screenshot of the problem in Calc without and with very large sheets support
Comment 2 Xisco Faulí 2020-07-21 16:10:42 UTC
Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: abea0d6647c7f1f7e76c73c26cb80e6a67dc5111
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 3 Justin L 2021-11-19 07:29:31 UTC
repro 7.3+
Comment 4 Justin L 2021-12-08 08:10:20 UTC
The only potential logic change I noticed was a couple instances of
-    (ValidRow(nRow)
+    (ValidRow(nRow, mnMaxRow))
Comment 5 Roman Kuznetsov 2022-02-15 08:39:34 UTC
No repro in

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 0bf0feb40ae5c394a14cdfe4f94fb98dd9053597
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL Jumbo

NISZ team, could you please retest your problem in current dev build?
Comment 6 Xisco Faulí 2022-02-15 10:53:09 UTC
Issue fixed by

https://cgit.freedesktop.org/libreoffice/core/commit/?id=cd50d33fc4af3f2d4ab40de98ecf02f0d832d750

author	Luboš Luňák <l.lunak@collabora.com>	2022-02-07 18:57:47 +0100
committer	Luboš Luňák <l.lunak@collabora.com>	2022-02-08 12:27:19 +0100
commit cd50d33fc4af3f2d4ab40de98ecf02f0d832d750 (patch)
tree 3fb7e649c9914b9b6c0e5aa6a81d3c5c30bebb7b
parent 03f225039b366f075b23a074e63edc6a47b12d3c (diff)
MAXCOL/MAXROW -> ScSheetLimits in fillinfo.cxx
Comment 7 Timur 2022-04-01 08:10:35 UTC
*** Bug 148151 has been marked as a duplicate of this bug. ***
Comment 8 Timur 2022-04-01 08:29:57 UTC
Please backport to 7.3 and 7.2.

Another sample attachment 178926 [details] with screenshot attachment 179169 [details] wrongly in bug 130383.
Comment 9 Xisco Faulí 2022-04-01 08:43:30 UTC
(In reply to Timur from comment #8)
> Please backport to 7.3 and 7.2.
> 
> Another sample attachment 178926 [details] with screenshot attachment 179169 [details]
> [details] wrongly in bug 130383.

no, this is about large spreadsheets, which is experimental in 7.2 and 7.3
Comment 10 Timur 2022-05-11 11:40:09 UTC
*** Bug 148944 has been marked as a duplicate of this bug. ***