Bug 130383 - Filesave ODS: Row height after Optimal Height still opens as 1 line instead of 2 in cell F5 (not with XLS/X)
Summary: Filesave ODS: Row height after Optimal Height still opens as 1 line instead o...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.2.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Regressions-row-height
  Show dependency treegraph
 
Reported: 2020-02-03 11:49 UTC by Philgood
Modified: 2024-01-17 14:52 UTC (History)
12 users (show)

See Also:
Crash report or crash signature:


Attachments
See line 5 only C14 is visible, but contain others valus not printable (20.07 KB, application/vnd.oasis.opendocument.spreadsheet)
2020-02-03 11:51 UTC, Philgood
Details
Bibisect log (3.06 KB, text/plain)
2020-05-03 21:12 UTC, Telesto
Details
Simple spreadsheet demonstating the issue (12.86 KB, application/vnd.oasis.opendocument.spreadsheet)
2022-03-16 20:30 UTC, heavy
Details
Screenshot of misbehaving spreadsheet (164.16 KB, image/png)
2022-03-28 13:09 UTC, heavy
Details
Screencast demonstrating issue (5.49 MB, video/webm)
2022-04-01 14:24 UTC, heavy
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philgood 2020-02-03 11:49:08 UTC
Description:
Before saving the .ods, line 5, the column is C2, C4, C5, C6, C7, C8, C9, C11, C12, C13, C14. The text C2 to C13 is at the 1st line and C14 at the 2nd line of the cell.
After reload, only appear (and printed) C14
But, in the same column, but line 24 the same case with R9, R12, R14, R15, R16, R21, R23, R27, R32, R34  and no problem after reload, the 2 line of the column are visibles and printable.
Alignement of the cells is in French: Renvoi à la ligne et coupure des mots.


Actual Results:
A 7.7Cm width column and text is C2, C4, C5, C6, C7, C8, C9, C11, C12, C13, C14
Save the sheet quit programm, reload the sheet, only C14 is visible and printable

Expected Results:
C2, C4, C5, C6, C7, C8, C9, C11, C12, C13,
C14
In the same cell


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Philgood 2020-02-03 11:51:27 UTC
Created attachment 157616 [details]
See line 5 only C14 is visible, but contain others valus not printable

Line 5 is KO but, the line 24 is OK.. Why ? it is the same case ?
Comment 2 m_a_riosv 2020-02-03 21:23:11 UTC
I can't repro.
Version: 6.4.0.3 (x64)
Build ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8
CPU threads: 4; OS: Windows 10.0 Build 19555; UI render: GL; VCL: win; 
Locale: es-ES (es_ES); UI-Language: en-US Calc: CL
Comment 3 Buovjaga 2020-05-02 17:08:03 UTC
Ok, so looking at cell F5, it only displays "C14" when viewed on Linux, but on Windows it displays the actual contents "C2, C4, C5, C6, C7, C8, C9, C11, C12, C13, C14"

Weird that the bug was reported against Windows, though.

This is not yet seen with latest commit of Linux 50max bibisect repo. Already seen with oldest of 6.3 repo.
Comment 4 Telesto 2020-05-03 21:12:38 UTC
Created attachment 160301 [details]
Bibisect log

Bisected to
author	Vasily Melenchuk <Vasily.Melenchuk@cib.de>	2018-04-06 20:19:10 +0300
committer	Thorsten Behrens <Thorsten.Behrens@CIB.de>	2018-06-08 00:47:06 +0200
commit 1e55a47e89a9d9d6cf9cb3993484022aaf2c097b (patch)
tree 3a3372525645775c32721e59ce8c205c8f474ffd
parent 2a7f74900fb646235b74d4c9bd4690e44edc3ed4 (diff)
tdf#62268: allow row height recalculation on document load
During document load rows with style:use-optimal-row-height="true"
should recalculate it's height.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=1e55a47e89a9d9d6cf9cb3993484022aaf2c097b
Comment 5 Telesto 2020-05-03 21:15:41 UTC Comment hidden (obsolete)
Comment 6 Xisco Faulí 2020-06-17 11:53:28 UTC
Not a regression. The issue can be reproduced if recalculation on File Load for ODF files is set to Always Recalculate in Tools/Options.../LibreOffice Calc/Formula
Comment 7 BogdanB 2020-09-19 11:43:43 UTC
In this case, if the user change that setting everything would be fine.

Philgood, could you try that?...See comment 6: Open Calc - Tools - Options - LibreOffice Calc - Formula - and change under Recalculation on File Load - instead of Never recalculate to Always recalculate.

Please test and tell us if this worked for you.
Comment 8 Timur 2021-09-01 12:11:14 UTC
Repro in 7.3+ Win and Lin as:
Open ODS and see F5 showing just 1 line "C14" (formula bar shows the full content)
Set Optimal row height on row 5, or add some space, content is OK.
Save and reload, see again 1 line (just "C14").

I confirm regression, saving an reopening OK before commit from Comment 4.

Note:
Never recalculate should not be changed to Always recalculate for perf sake.
Just in testing it can be set to Prompt. 
It's not about Calc/Formula/Recalculate (no formula here), it's about row height.
Comment 9 Timur 2021-09-01 13:06:28 UTC
I don't see why this is OK only on filesave with pre-commit LO. 
I compared ODS and I didn't notice a difference. 
So not clear why pre-commit LO 6.2 has the same issue on fileopen before save.
Comment 10 heavy 2022-03-16 20:30:48 UTC Comment hidden (obsolete)
Comment 11 Gessel 2022-03-24 13:46:08 UTC Comment hidden (obsolete)
Comment 12 heavy 2022-03-24 17:18:27 UTC Comment hidden (obsolete)
Comment 13 Gessel 2022-03-25 22:53:22 UTC Comment hidden (obsolete)
Comment 14 heavy 2022-03-28 13:09:32 UTC Comment hidden (obsolete)
Comment 15 Timur 2022-03-31 11:00:10 UTC Comment hidden (obsolete)
Comment 16 Timur 2022-04-01 08:26:59 UTC
attachment 178926 [details] was bug 134552, that's fixed in 7.4+.
I obsolete that discussion. This bug remains.
Comment 17 heavy 2022-04-01 12:51:01 UTC Comment hidden (obsolete)
Comment 18 Buovjaga 2022-04-01 13:52:22 UTC
(In reply to heavy from comment #17)
> Is there a pre-release of 7.4 that I could download and test?

https://dev-builds.libreoffice.org/daily/master/current.html

On Linux, you can also roll your own appimage: https://wiki.documentfoundation.org/Installing_in_parallel/Linux#Automated_installation
Comment 19 heavy 2022-04-01 14:24:18 UTC
Created attachment 179255 [details]
Screencast demonstrating issue

The attached screencast demonstrates the issue for me under Fedora 35 using the latest 7.4 alpha. I still see the same issue. I also tried it with and without enabling support for very large spreadsheets. The issue was present in either case.
Comment 20 m_a_riosv 2022-09-17 23:41:51 UTC
*** Bug 151031 has been marked as a duplicate of this bug. ***
Comment 21 Gabor Kelemen (allotropia) 2024-01-17 14:52:59 UTC
I can't reproduce this since 7.6 commit:

https://git.libreoffice.org/core/+/b1393fd5ce847f40abab49f57c67929bb0087fae

author	Maxim Monastirsky <momonasmon@gmail.com>	Fri Mar 17 14:54:30 2023 +0200
committer	Maxim Monastirsky <momonasmon@gmail.com>	Thu Mar 23 08:54:06 2023 +0000

sc drawstyles: ODF import and export