Bug 135073 - Crash of the document recovery window (comment 11)
Summary: Crash of the document recovery window (comment 11)
Status: NEEDINFO
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest, regression
Depends on:
Blocks: AutoSave-AutoRecovery-Backup Crash
  Show dependency treegraph
 
Reported: 2020-07-23 08:59 UTC by Telesto
Modified: 2024-08-04 18:58 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screencast (670.07 KB, video/mp4)
2020-09-03 17:56 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-07-23 08:59:35 UTC
Description:
Crash of the  document recovery window

Steps to Reproduce:
1. download full getting started guide 4.2 and 5.0 from 
https://wiki.documentfoundation.org/images/0/0f/GS42-GettingStartedLO.odt
and
https://wiki.documentfoundation.org/images/f/f3/GS50-GettingStartedLO.odt
2. open GS Guide 5.0 in LO
3. select menu Edit - Track Changes - Compare Document
4. select GS Guide 4.2 and wait
5. Press Undo

6. File recovery dialog appears
7. Press OK -> error popups.. window still present.. not happens anyore

Actual Results:
File recovery stuck

Expected Results:
Shouldn't be so


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 52820b52b3bca45e2db527d1cc5f4488b2e0b9d0
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-07-23 09:01:00 UTC
Also in 5.3
Comment 2 Telesto 2020-07-23 09:04:25 UTC
Pressing OK working fine with 5.2
Comment 3 MM 2020-07-24 19:40:43 UTC
Confirmed on windows 10 x64 with Version: 6.4.6.1 (x64)
Build ID: 985dd72ca280d5c6da2e9f90f7ff9286cafe7ff8
CPU threads: 12; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
Comment 4 Mike Kaganski 2020-08-02 08:42:04 UTC
(In reply to Telesto from comment #0)
> 7. Press OK -> error popups.. window still present.. not happens anyore

Not happens what?
Please refrain from vague phrases that don't allow to understand what you mean. Better be overly verbose than unclear. Use full sentences, with exact nouns instead of "it"s and such, even if that means you will repeat the same word tens of times. This is not a novel, this is STR, which must be unambiguous.

https://www.chiark.greenend.org.uk/~sgtatham/bugs.html#clarity
Comment 5 Mike Kaganski 2020-08-02 09:13:11 UTC
Specifically, I didn't write about mistyped "anymore" (which is not a problem).

(In reply to Telesto from comment #0)
> Steps to Reproduce:
> ...
> 2. open GS Guide 5.0 in LO
> 3. select menu Edit - Track Changes - Compare Document
Given the size of the document, you omitted one detail relevant here: should one wait for layout to finish (so it stops jumping back when you scroll, and "Page 1 of N" in status bar stops changing, and N becomes 533), or should one start comparison immediately, or does this not matter. (But you might not notice this, OK...)

> 4. select GS Guide 4.2 and wait
Wait for what? I *guess* that you meant "... until "Manage Changes" dialog appears", but that's just my guess. Maybe you meant that something else appears for you; and that could happen e.g. that you see a different thing at this point than what I see. A good report would not let it unsaid, and a person who reports hundreds of bugs is expected to follow best practices.

> 5. Press Undo
How? without closing the dialog? or closing it? That is a very important detail, and "I didn't write to close it, so it naturally means it should stay open" is not an argument. It's good to read "Press "Undo" button on toolbar, without previously closing "Manage Changes" dialog", or something like that. Also, how many times should one press the "Undo"?

> 6. File recovery dialog appears
Not that big, just another illustration of ignoring the importance of details: the dialog is not "File recovery", it's "LibreOfficeDev 7.1 Document Recovery".

> 7. Press OK -> error popups.. window still present.. not happens anyore
There's no "OK" in the "Document Recovery" dialog. Which error (its text) exactly? which "window" is meant - the "Document Recovery" dialog's? or any other window that you see, but didn't mention? and finally, what "not happens anymore" and when? do you mean that you don't see the same problem when try to repeat the steps? or what?
Comment 6 Mike Kaganski 2020-08-02 10:01:25 UTC
(In reply to Mike Kaganski from comment #5)
> > 7. Press OK -> error popups.. window still present.. not happens anyore
> There's no "OK" in the "Document Recovery" dialog.

Or did you mean "Due to an error, LibreOffice crashed. All the files you were working on will now be saved" dialog, which is different from the "Document Recovery" dialog appearing the next time you launch the program ("LibreOffice will attempt to recover ...")? (The two dialogs/different modes of the same dialog (?) should really be named differently for disambiguation.) This likely the exact thing that happened here that you see something different from what I see (me using a debug build), so extra level of details is again very important, also mentioning the "Documents are being saved" window appearing (is *this* a window you were talking about in #7?).
Comment 7 Telesto 2020-08-02 10:14:38 UTC
1. download full getting started guide 4.2 and 5.0 from 
https://wiki.documentfoundation.org/images/0/0f/GS42-GettingStartedLO.odt
and
https://wiki.documentfoundation.org/images/f/f3/GS50-GettingStartedLO.odt
2. open GS Guide 5.0 in LO
3. select menu Edit - Track Changes - Compare Document
4. select GS Guide 4.2 and with until the comparing process finishes 
5. Close the track changes dialog
6. Press Undo (to delete the comparison, number of steps is different between versions; but all steps)
7. The LibreOffice document recovery opens ("Due to an error")
8. Press OK -> A Windows dialog opens error; closing LibreOffice

7/8 don't happen for me today; everything simple hangs/freezes
Comment 8 Telesto 2020-08-25 21:09:51 UTC
Next attempt (based on bug 136124)

1. Open attachment 162927 [details]
2. Tools -> Options -> Save/ load set autosave to 1 minute
3. CTRL+A
4. CTRL+X
5. Edit -> Track changes -> Manage
6. Minimize -
7. Wait -> LibreOffice starts blinking in the task bar 
8. Click it -> Crash

Dialog & press OK -> Crash again (something in the same area: bug 131681)
Comment 9 Telesto 2020-09-03 17:56:02 UTC
Created attachment 165112 [details]
Screencast

Another case
1. Open attachment 165096 [details] bug 122792
2. CTRL+A
3. CTRL+X
4. CTRL+V -> Crash -> Document recovery appears
5. Press OK; saving starts... nearly finished.. error appears (see screencast)
Comment 10 Telesto 2020-09-03 18:05:31 UTC
(In reply to Telesto from comment #9)
> Created attachment 165112 [details]
> Screencast
> 
> Another case
> 1. Open attachment 165096 [details] bug 122792
> 2. CTRL+A
> 3. CTRL+X
> 4. CTRL+V -> Crash -> Document recovery appears
> 5. Press OK; saving starts... nearly finished.. error appears (see
> screencast)

Still working fine with 6.3 (so maybe throwing bugs together, based on comment 0)
Comment 11 QA Administrators 2022-09-04 03:49:57 UTC Comment hidden (obsolete)
Comment 12 Telesto 2022-09-04 14:46:00 UTC
1. download full getting started guide 4.2 and 5.0 from 
https://wiki.documentfoundation.org/images/0/0f/GS42-GettingStartedLO.odt
and
https://wiki.documentfoundation.org/images/f/f3/GS50-GettingStartedLO.odt
2. open GS Guide 5.0 in LO
3. select menu Edit - Track Changes - Compare Document
4. select GS Guide 4.2 and with until the comparing process finishes 
5. Close the track changes dialog
6. Press Undo -> Crash (a problem, but not the point of the bug)

7. The LibreOffice Document Recovery dialog opens (The following files will be recovered..)
8. Press OK 
9. Documents are being saved dialog opens; LibreOffice stopped working. Close the program dialog appears

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: dc92a4d973086ce8a6a5f75ba0f4d4c9ca05537a
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 13 Mike Kaganski 2022-09-05 16:43:23 UTC
(In reply to Telesto from comment #12)
> 9. Documents are being saved dialog opens; LibreOffice stopped working.
> Close the program dialog appears

No repro using Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: d752cb42473547872741c74a70809f28f9fe789c
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL threaded
Comment 14 Stéphane Guillou (stragu) 2024-05-18 05:28:04 UTC
With comment 12 steps:

No repro on Linux:
BigPtrArray crash at step 6, but at step 9, but LO closes, and Ubuntu Apport catches the crash. Reopening LO goes directly to reporting the step 6 crash, and then the document recovery works.

Version: 7.6.6.3 (X86_64) / LibreOffice Community
Build ID: d97b2716a9a4a2ce1391dee1765565ea469b0ae7
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

On Windows 11, I get the crash at step 6, and then "Document are being saved" is stuck on step 9 with progress bar not moving. If I close that dialog and restart LO, I get the crash report dialog, with signature "BigPtrArray::Index2Block(long)":
- https://crashreport.libreoffice.org/stats/crash_details/fa9252b3-d5df-4605-9d10-6edc7f42a120
- https://crashreport.libreoffice.org/stats/crash_details/99030566-c721-4ae7-b885-26253eab36a4
... but that's the step 6 (bug 135072) crash that's reported after, correct?
After the crash report dialog, the document recovery works as expected.

Version: 7.6.6.3 (X86_64) / LibreOffice Community
Build ID: d97b2716a9a4a2ce1391dee1765565ea469b0ae7
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

So, is the issue that the "Documents are being saved" freezes?
Comment 15 Buovjaga 2024-08-04 18:58:53 UTC
(In reply to Stéphane Guillou (stragu) from comment #14)
> So, is the issue that the "Documents are being saved" freezes?

Telesto: looks like we need more info on this at the moment.