Description: CRASH: Impress crashes if try start a slide show from current slide Steps to Reproduce: 1. Open the file from attach 2. Select 22 slide 3. Select Start from Current Slide on toolbar 4. Crash!!! Actual Results: Impress crashes Expected Results: Impress works fine Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ (x64) Build ID: 539e4124739feffdceecb5207fdc2428396a9dd4 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded It works without Skia => a Skia problem
Created attachment 163453 [details] Presentation file
Also LibreOffice is in tasks after crash and I should kill it before new start
Repro crash with Version: 7.1.0.0.alpha0+ (x64) Build ID: 27c1a7fbcd3e236d4eee7ee3e1a7acdaa47510eb CPU threads: 12; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL
Created attachment 163459 [details] Vs 2019 Call Stack, Start with first slide It crashes already when start with first slide. Tested with Version: 7.1.0.0.alpha0+ (x64) Build ID: e3bf5b17bf4b8c8a7abb2c524d0f0da34295766c CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Vulkan; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL
Problem is the transition "Fade". This transition crashes already in the preview. There is no crash with e.g. transition "Wheel".
https://gerrit.libreoffice.org/c/core/+/99330
I think, the problem is not related to Skia. It crashes too with Version: 7.1.0.0.alpha0+ (x64) Build ID: e3bf5b17bf4b8c8a7abb2c524d0f0da34295766c CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: default; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL
It does not crash with Version: 6.4.5.0.0+ (x64) Build ID: 70a2071ce91b71326659e645dd97996262ea309a CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; Locale: de-DE (en_US); UI-Language: en-US Calc: threaded And it does not crash with Version: 7.0.0.2 (x64) Build ID: c01aa64b6c3d89ebe5fe69c28c7adb24eb85249c CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Raster; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL
Regression introduced in range https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=e3adb51c54089a961cea1a33c5f54f6e552a4590..eccb763146325bd44a84b6a1698109ebd1bcf35e Only skia related commit in the range seems to be https://cgit.freedesktop.org/libreoffice/core/commit/?id=fada69d6ee05700fd57c8844591562608a900a9d author Luboš Luňák <l.lunak@collabora.com> 2020-07-06 11:59:13 +0200 committer Luboš Luňák <l.lunak@collabora.com> 2020-07-07 11:44:13 +0200 commit fada69d6ee05700fd57c8844591562608a900a9d (patch) tree 3b193fb280f4d5c3adc53408ae8b4119bc83793b parent ecb2dc9705d2197833cfbfd2259d3ac289f3e82d (diff) set also RGB/BGR LCD order for Skia text rendering (tdf#134275)
https://git.libreoffice.org/core/+/87e5ee310959d535c53a083258edff1b3b1335bd is much more likely - see the patch mentioned in comment 6.
(In reply to Regina Henschel from comment #7) > I think, the problem is not related to Skia. It crashes too with Version: > 7.1.0.0.alpha0+ (x64) > Build ID: e3bf5b17bf4b8c8a7abb2c524d0f0da34295766c > CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: default; VCL: win > Locale: de-DE (en_US); UI: en-US > Calc: CL I can't repro it without Skia
Noel: could you please see comment 6 and comment 10. I suspect something from the "UNO constructors" change ... still strange (but I had not investigated too deep, I confess).
(In reply to Mike Kaganski from comment #10) > https://git.libreoffice.org/core/+/87e5ee310959d535c53a083258edff1b3b1335bd > is much more likely - see the patch mentioned in comment 6. oh, thank makes sense too. A few weeks ago, I reported a similar issue in bug 134647
Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/71654aed66ef425467118b69bc6d5879b4b0e717 tdf#135078: let vclcanvas::SpriteCanvas implement css::lang::XServiceInfo It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
The commit should fix the crash, and Luboš confirmed that it's a correct thing per se, but I don't know if this is the correct fix for the underlying issue (if any) - which is "why suddenly a long-existing code started to use a different object after changing used constructors".
Mike's fix is the correct fix - the previous code returned a ServiceFactory object, which supplied the XServiceInfo interface. The new code directly returns the underlying object, which is why it now has to implement that XServiceInfo interface itself.
(In reply to Noel Grandin from comment #16) Thanks Noel! FIXED then.
verified in Version: 7.1.0.0.alpha0+ (x64) Build ID: <buildversion> CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded But fade transition effect is flickering now=( Mike, any ideas?