Bug 135184 - FILEOPEN XLSX Dotted lines disappeared
Summary: FILEOPEN XLSX Dotted lines disappeared
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.0.0.1 rc
Hardware: All All
: medium normal
Assignee: Regina Henschel
URL:
Whiteboard: target:7.1.0 target:7.0.2
Keywords: bibisected, bisected, regression
Depends on:
Blocks: OOXML-Chart
  Show dependency treegraph
 
Reported: 2020-07-27 09:29 UTC by NISZ LibreOffice Team
Modified: 2020-09-29 11:50 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the original document side by side in Excel and Calc (88.83 KB, image/png)
2020-07-27 09:29 UTC, NISZ LibreOffice Team
Details
The example file in current Calc master (56.47 KB, image/png)
2020-08-31 13:57 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2020-07-27 09:29:31 UTC
Created attachment 163600 [details]
Screenshot of the original document side by side in Excel and Calc

Attachment #142562 [details] from bug #118034 contains a chart with trendline and trendline equation border set to dotted line style.
Opening this file in 7.1 master makes these dotted lines disappear.

Steps to reproduce:
    1. Open attachment #142562 [details]

Actual results:
Trend line and the trend line equations border have no dotted border line.

Expected results:
Trend line and the trend line equations border should have dotted border line.

LibreOffice details:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 1db7decf3fb172542f5fce03ce7bf0cb310d1ffc
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

Version: 7.0.0.1 (x64)
Build ID: 04ba7e3f1e51af6c5d653e543a620e36719083fd
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

But not yet in:
Verzió: 6.4.0.3 (x86)
Build az.: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8
CPU szálak: 4; OS: Windows 6.3 Build 9600; Felületmegjelenítés: GL; VCL: win; 
Területi beállítások: en-US (hu_HU); Felület nyelve: hu-HU
Calc: CL

Additional Information: 

Bibisected using bibisect-win64-7.1 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3f3b50015e4fd9efc3459612a70409fca49cf390

author
Regina Henschel <rb.henschel@t-online.de> Sat Jun 20 15:08:12 2020 +0200 
committer
Regina Henschel <rb.henschel@t-online.de> Mon Jun 22 10:43:08 2020 +0200 

tdf#134053 tweak dash and space length for ooxml

Adding CC to: Regina Henschel
Comment 1 Xisco Faulí 2020-07-27 09:56:56 UTC
Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: b68c10a0d0e6f83b6b037da72210033cacb1677b
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 2 Regina Henschel 2020-07-27 13:20:45 UTC
The problem is, that the chart does not use the svg:stroke-linecap attribute. If you add svg:stroke-linecap="round" manually, the dotted lines are shown correctly.

So here the import of charts should set svg:stroke-linecap always.
Comment 3 Regina Henschel 2020-07-27 20:32:36 UTC
Chart is currently not able to interpret linecap. This feature is missing in general, not only in OOXML import but for ODF too.

For Draw objects the property linecap is interpreted and for drawing objects the solution of bug 134053 gives lines which look very similar to those of MS Office, especially rounded dots are nearly circles now. Therefore I think, it should not be reverted.

Please have a look at https://gerrit.libreoffice.org/c/core/+/99562. I have added two lines, which force to use linecap 'flat' regardless which linecap is set in MS Office. I have not tested yet, but borders of legend, title ... and data series lines will likely need a same workaround.

A real fix would be to enable charts to use linecap 'round' and 'square'. But to be honest, I wouldn't know how to implement that.

How to proceed?
Comment 4 NISZ LibreOffice Team 2020-07-28 07:58:31 UTC
There is an older feature request for line chart ending arrows at bug #95038 - but we have not looked at solving it yet.
Comment 5 Regina Henschel 2020-07-28 08:56:18 UTC
Would you help me to bring linecaps to Chart? For them there is already an UI in the sidebar.
Comment 6 Regina Henschel 2020-07-29 09:27:32 UTC
I have added linecaps to several property sets, see mentioned https://gerrit.libreoffice.org/c/core/+/99562

It seems, that is the right way to go. What do you think?

That gets already correct rounded dots for trendline and legend.

Equation text box gets correct rounded dots too, but looses stroke totally when resave to xlsx. That is not new, but already bug in LO 6.4.

I have not found yet, where the place for the lines is, which are drawn for the data series. Do you know where?

The drop-down for line caps in the sidebar does not work, because it has an empty method.
Comment 7 Regina Henschel 2020-07-30 13:56:17 UTC
@NISZ LibreOffice Team: Data series lines are now OK too. All unit test related things are missing. But it would be helpful, if you could test, whether the fix itself works for you.
Comment 8 Regina Henschel 2020-08-04 21:36:33 UTC
@NISZ LibreOffice Team: Can someone from your team review https://gerrit.libreoffice.org/c/core/+/99562 ? It is ready now.
Comment 9 Commit Notification 2020-08-06 11:11:22 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/74be8bb787a44464957e5d3105c8de6d36e81b4a

tdf#135184 add linecaps in charts

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 NISZ LibreOffice Team 2020-08-31 13:57:15 UTC
Created attachment 164923 [details]
The example file in current Calc master

Dotted line is back in:

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 1e0cfd5662d95cea84e80e4fe10d52c3b1101ae6
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

Thanks for fixing this!

I think this is worth a backport to 7.0.
Comment 11 Xisco Faulí 2020-09-02 12:10:20 UTC
Backported to 7-0 branch: https://gerrit.libreoffice.org/c/core/+/101871
Comment 12 Commit Notification 2020-09-15 09:14:44 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/2b218729b8332fa2bc8a20480c8ba701e1bca361

tdf#135184 add linecaps in charts

It will be available in 7.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 NISZ LibreOffice Team 2020-09-28 07:40:43 UTC
I guess this can be closed now. Proper implementation of arrows/linecaps can continue in bug #95038
Many thanks Regina!
Comment 14 Xisco Faulí 2020-09-28 14:04:39 UTC
Regina's commit also includes a unittest
Comment 15 Xisco Faulí 2020-09-29 11:50:16 UTC
Verified in

Version: 7.1.0.0.alpha0+
Build ID: cd85546a2fbdade42f80fd3b6bd650791db9f32d
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: tr-TR (en_US.UTF-8); UI: en-US
Calc: threaded

@Regina, thanks for fixing this issue!!