Bug 137171 - Please un-hide "show icons in menus" and "show shortcuts in context menus" options for GTK3
Summary: Please un-hide "show icons in menus" and "show shortcuts in context menus" op...
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.1.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-30 22:16 UTC by Ming Hua
Modified: 2021-04-03 13:26 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ming Hua 2020-09-30 22:16:39 UTC
According to bug 123265 comment 16 and bug 123265 comment 20, the "Icons in menus" and "Shortcuts in context menus" options in Tools > Options > LibreOffice > View stopped working in GTK3 VCL, and as a consequence these two options were hidden by commit:

https://git.libreoffice.org/core/commit/0d6a64c218791156e050c2050b8070d40fdacf97

Resolves: tdf#123265 hide show-icons under gtk3

However, according to bug 123265 comment 41, the options stopped working because the fix for bug 126830 got lost during the GTK2 cleanup, and commit:

https://git.libreoffice.org/core/commit/9e129e8557370207f784cba0f40643044ead88be

Restore the fix for tdf#126830

has restored the fix, and these two options should work in GTK3 VCL now.

In light of these, I don't see the reason to hide these options anymore, and they should be shown to GTK3 users who don't/can't set system-wide setting for all applications about menu icons.  In other words, 0d6a64c218791156e050c2050b8070d40fdacf97 probably should be reverted.

Caolán, as you were the author of the original commit that hid the options, I hope you don't mind me adding your to CC.
Comment 1 Caolán McNamara 2020-10-01 08:15:28 UTC
I disagree entirely.
Comment 2 hellwoodfire 2020-11-06 06:31:47 UTC
I think, someone somewhere does not take the time to understand the problem.
There was related a fix by Maxim for bug 123265. I tested with LO 7.0.3.1 and there is still no icons in menu. HOWEVER, in LINUX MINT, in the THEMES dialog, we have an option named "SHOW ICONS IN MENUS". It's set the TRUE. This mean I want to see icons in Menu SYSTEM WIDE. As it is in GIMP, in INKSCAPE, etc. It work everywhere in ALL applications EXCEPT LibreOffice. The application read THIS setting, LibreOffice don't (or it's  a bug) ?  

WE NEED ICONS IN MENUS WITH GTK3. Libre Office is Complete non sens without them. We find 10 times faster the menu item we look for with icons. Just look at the Form menu in Writer... The prolem also affect the context menu. It's a complete mess without icons. Totally UNUSABLE. People will go back to Windows and Microsoft Office. 

I found a HACK that PROVE that YOU CAN display the ICON in the MENUs. 
I EDIT registrymodifications.xcu IN my .config folder: I set IsSystemIconsInMenus to true and remove the line with ShowIconsInMenues (OR I set IsSystemIconsInMenus to false and ShowIconsInMenues to true) 

NONE OF THEM was in the file, IsSystemIconsInMenus and ShowIconsInMenues. CAN you explain WHAT EXACLY IS THE SETTING YOU READ in the OS, to set these flags? BECAUSE as I said, my Linux Mint config is "SHOW ICONS IN MENUS" and it's it's like LibreOffice doesn't care at all. 

Do you test with Linux Mint?  
Do you test with any GTK3 desktop environement? 
Where now MILLIONS or users all around the WORLD not able to WORK with LibreOffice because a majority of desktop environments are GTK3. 

Can you take the time to communicate with everyone implicated (Linux Mint, GTK3) and take the time to understand the Problem. Because LibreOffice without icons in menu is like absolutely nothing and everyone will go back to Microsoft Office. Please listen, analyse, understand, and do something. 

THANKS
Comment 3 Ming Hua 2020-11-06 07:07:12 UTC
(In reply to hellwoodfire from comment #2)
> I found a HACK that PROVE that YOU CAN display the ICON in the MENUs. 
> I EDIT registrymodifications.xcu IN my .config folder: I set
> IsSystemIconsInMenus to true and remove the line with ShowIconsInMenues (OR
> I set IsSystemIconsInMenus to false and ShowIconsInMenues to true) 
Please read other people's comments carefully before advocating your own opinions.

As has been stated in bug 123265 comment #48, and reminded to you again in bug 123265 comment #63, there is no need to manually edit registrymodifications.xcu, just use the expert configuration provided by the UI.

Also please don't reopen WONTFIX bugs without discussion first.  Respect the developer's decision.  See https://wiki.documentfoundation.org/QA/BSA/BugReport_Details#How_to_reopen_Bugs and related wiki pages for Bugzilla etiquette.