Bug 137567 - Image missing in ODT (shows up in navigator) since 7.1
Summary: Image missing in ODT (shows up in navigator) since 7.1
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: redlinehide-regressions
  Show dependency tree / graph
 
Reported: 2020-10-17 20:19 UTC by Telesto
Modified: 2021-05-13 09:02 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:
Regression By:

Attachments
Bibisect log (2.74 KB, text/plain)
2020-10-17 20:23 UTC, Telesto 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-10-17 20:19:49 UTC 
Description:
Image missing in document (shows up in navigator) since 7.1

Steps to Reproduce:
1. open attachment 164527 [details]


Actual Results:
No image present

Expected Results:
Image should show


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 94e6e140491de31c0788c91af855a75a3bb12709
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-10-17 20:23:23 UTC 
Created attachment 166475 [details]
Bibisect log

Bisected to:
author	Michael Stahl <Michael.Stahl@cib.de>	2020-08-28 22:05:06 +0200
committer	Michael Stahl <michael.stahl@cib.de>	2020-08-31 12:41:22 +0200
commit 586750da40c5b332d2442ef24ae121795e88e903 (patch)
tree 6e9fb51629af1e2e1555120d4e557e336e832a46
parent 943aaf6c61d9594ec229984b5d5801afe5d89024 (diff)
tdf#135001 sw_redlinehide: fix IsShown() for AT_PARA flys
There is one merged text frame from node 102 to node 328 with no
extents, and of course a shape anchored at node 271 should not be
visible at all.

This crashes because the shape was removed from the layout during
CheckParaRedlineMerge() but then moved to the visible heaven layer
again via sw::AddRemoveFlysAnchoredToFrameStartingAtNode() and the
layer determines if it's visible as far as Sdr* is concerned;
it lacks a connection to a SwFrame though.

warn:legacy.osl:3547848:3547848:sw/source/core/layout/paintfrm.cxx:3861: <SwFlyFrame::IsPaint(..)> - paint of drawing object without anchor frame!?

(regression from 6aaae44da382f4bc3eafc287b4a21734b740cf21)

https://cgit.freedesktop.org/libreoffice/core/commit/?id=586750da40c5b332d2442ef24ae121795e88e903
Comment 2 Telesto 2020-10-17 20:25:06 UTC Comment hidden (obsolete)
Comment 3 Dieter 2021-05-13 07:17:25 UTC 
(In reply to Telesto from comment #0)
> Description:
> Image missing in document (shows up in navigator) since 7.1

Navigator says, that image is hidden. So I would say it is the expected result. I don't know how to change this setting.

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 1675a68526c43c6c6e4dc850ee911f0c1de75c88
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

So please explain, why you think, it is not the expected result
=> NEEDINFO
Comment 4 Telesto 2021-05-13 09:02:02 UTC 
It's true that the image was present and know hidden (track & changes show).

However this actually not a bug in sight, but the proper behaviour. So yes, it changed, but the commit fixed present issue (showing the image)

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: d7f734db2c078ced3ce08ad58cd816a79abe3bcf
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL

Anyhow, creating a follow-up report what should happen to deleted content with track changes present, but hidden. It shouldn't show inside Navigator when 'show changes being disabled'