Bug 137972 - Correcting with spell checker context menu places cursor at the left (previously right)
Summary: Correcting with spell checker context menu places cursor at the left (previou...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: low enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 141693 148219 148813 (view as bug list)
Depends on:
Blocks: Spell-Checking
  Show dependency treegraph
 
Reported: 2020-11-03 22:05 UTC by Telesto
Modified: 2022-08-22 08:44 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Example file (8.10 KB, application/vnd.oasis.opendocument.text)
2020-11-03 22:06 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-11-03 22:05:51 UTC
Description:
Correcting with spell checker context menu places cursor at the left (previously left)

Steps to Reproduce:
1. Open the attached file
2. Right click wrong spelled word

Actual Results:
Cursor at the left

Expected Results:
A) This is a change in logic
B) Other spell checkers do right too


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha1+ (x64)
Build ID: ec1f4d3253963ac16d638734ac70dde033e82154
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL
Comment 1 Telesto 2020-11-03 22:06:07 UTC
Created attachment 166983 [details]
Example file
Comment 2 Telesto 2020-11-03 22:09:12 UTC
@Michael
They recent change you made for replacing text has small side effect (else anchors got eating). Cursor is put left, instead of right. 

Not sure if there are practical side effects but it's change in logic and bit odd.
Comment 3 Telesto 2020-11-13 12:03:57 UTC
Bisected to:
author	Michael Stahl <Michael.Stahl@cib.de>	2020-08-19 18:55:27 +0200
committer	Michael Stahl <michael.stahl@cib.de>	2020-08-20 13:47:08 +0200
commit ec579354af954867b829e7d08e4d752518c83728 (patch)
tree e2fea1fd4729fedf648f129a0e927674b4235c7a
parent 6274fbe13c8fa556916b5aed695c6921ef6ff84f (diff)
tdf#135721 sw: fix spell check context menu deleting flys
Kind of similar to e1629c210ad78310e3d48c0756723134a27b89df
but the problem is at a higher level: SwTextShell::Execute() with
SID_SPELLCHECK_APPLY_SUGGESTION should not DelLeft() + Insert() but
just Replace().

(regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5)

https://cgit.freedesktop.org/libreoffice/core/commit/?id=ec579354af954867b829e7d08e4d752518c83728
Comment 4 Michael Stahl (allotropia) 2020-11-13 12:11:11 UTC
uh... is that a bug? not sure if users care?
Comment 5 Telesto 2020-11-13 12:21:46 UTC
(In reply to Michael Stahl (CIB) from comment #4)
> uh... is that a bug? not sure if users care?

It's a difference. Not sure if this would cause practical issue with macro/undo/redo or whatever. And of course habit :-). 
I never really noticed it, but after the change I found something being off. I still not really know what's makes it different, but somehow it's strange. And the right click replace mostly placed cursor right (in other programs). So there might be a reason.

Anyhow I call it change in logic. But if you want to do a 'social experiment' to check if anybody notices: also fine :P
Comment 6 Telesto 2020-12-17 18:43:32 UTC
@Heiko
Any opinion on this? I'm realizing this being a kind of UX topic. Say I'm typing and a red line appears.. I read click it and select the corrected version.. I tend to press space and go on where I left.. but with cursor at the wrong position this doesn't work anymore..

However I might be me.. so asking the actual usability expert :P. Not seen anyone complain yet (except me)
Comment 7 Heiko Tietze 2020-12-18 07:59:59 UTC
Let's call it a minor discrepancy. The cursor is also left in case of RTL text flow. Continuing at the end of the word is the usual progress of editing, so yes.

Tested with 6.4.
Comment 8 Telesto 2021-04-15 15:13:40 UTC
*** Bug 141693 has been marked as a duplicate of this bug. ***
Comment 9 Telesto 2022-03-27 20:32:38 UTC
*** Bug 148219 has been marked as a duplicate of this bug. ***
Comment 10 Heiko Tietze 2022-05-25 08:10:15 UTC
*** Bug 148813 has been marked as a duplicate of this bug. ***
Comment 11 Dieter 2022-05-25 08:36:32 UTC
Still present in

Version: 7.3.4.1 (x64) / LibreOffice Community
Build ID: 13668373362b52f6e3ebcaaecb031bd59a3ac66b
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Related to bug 102044
Comment 12 duplicator 2022-08-22 08:44:50 UTC
Still present in

Version: 7.4.0.3 / LibreOffice Community
Build ID: 40(Build:3)
CPU threads: 8; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
7.4.0-2
Calc: threaded

For me it is a real issue