Bug 138307 - FILEOPEN: Calc chart embedded basic custom shape text missing (ODF import)
Summary: FILEOPEN: Calc chart embedded basic custom shape text missing (ODF import)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
7.2.5.2 release
Hardware: All All
: medium normal
Assignee: Balázs Varga
URL:
Whiteboard: target:7.2.0 target:7.1.0.0.beta2
Keywords: filter:odf, regression
: 133827 142137 (view as bug list)
Depends on:
Blocks: Chart
  Show dependency treegraph
 
Reported: 2020-11-18 11:00 UTC by NISZ LibreOffice Team
Modified: 2022-07-14 14:42 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
The original file saved by Calc (14.55 KB, application/vnd.oasis.opendocument.spreadsheet)
2020-11-18 11:15 UTC, NISZ LibreOffice Team
Details
Bug-Diagramme-Aspect Modifié (12.54 KB, image/jpeg)
2022-02-21 14:12 UTC, regis586
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2020-11-18 11:00:48 UTC
Description:
Chart embedded basic custom shape text missing after save and reload (ODF import)

Steps to Reproduce:
1. Open Calc
2. Insert a simple chart
3. Embed a basic shape in the chart
4. Add a custom shape text
5. Exit from the chart
6. Save the spreedsheet (choose ODF spreedsheet file type)
7. Reload the spreedsheet

Actual Results:
Basic custom shape text is missing

Expected Results:
Basic custom shape text remains


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha1+ (x64)
Build ID: 312a33b7636334f6ce3b6d1702bc5d3e45215601
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded
Comment 1 NISZ LibreOffice Team 2020-11-18 11:15:14 UTC
Created attachment 167386 [details]
The original file saved by Calc
Comment 2 Commit Notification 2020-11-27 12:10:01 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/71b66b0039819f38c935b4eb5d5951ceaf6e8468

tdf#138307 Chart import: fix lost custom shape text

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2020-11-30 11:34:02 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/1aacd856ab0cf7217e2435c2e8c84d2e00963cb2

tdf#138307 Chart import: fix lost custom shape text

It will be available in 7.1.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 NISZ LibreOffice Team 2020-12-30 10:41:29 UTC
Verified in:

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 368c56144aab5794c39d5bc2082d9b3d6d7cebdb
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded

Thanks for fixing!
Comment 5 Timur 2021-05-10 12:08:30 UTC
*** Bug 142137 has been marked as a duplicate of this bug. ***
Comment 6 Timur 2021-05-10 12:09:13 UTC
*** Bug 133827 has been marked as a duplicate of this bug. ***
Comment 7 Timur 2021-05-10 12:16:20 UTC
In now duplicate bug 133827 I bibisected this to:
Date:   Fri Nov 29 11:21:17 2019 +0100
    source 5d20213462ca346ba942ce5e03a5771d499d3518
    Previous source a12038fd8f6c7f276b616093c613c4fc19f75a59
tdf#128985: ODP: Style text directions revert to RTL on save and re-open	

This data-loss regression would profit from backport to 7.0, but seems like it's late for RC2:
https://wiki.documentfoundation.org/ReleasePlan/7.0#7.0.6_release
Comment 8 Timur 2021-05-10 12:22:04 UTC
Hi Xisco. I only now saw this fix when it's too late for 7.0 RC2. Could RC3 be created just for this? Even if not, data loss is worth asking.
Comment 9 Xisco Faulí 2021-05-10 13:23:57 UTC
(In reply to Timur from comment #8)
> Hi Xisco. I only now saw this fix when it's too late for 7.0 RC2. Could RC3
> be created just for this? Even if not, data loss is worth asking.

Hi Timur,
According to https://git.libreoffice.org/core/+/71b66b0039819f38c935b4eb5d5951ceaf6e8468%5E%21, this is a regression from https://git.libreoffice.org/core/+/6f62a5c4ee2c1b7654c7fcaa618fb495e0d32f0a, which is present in branch 7.0, 6.4 and 6.3. I agree it would have been nice to have it in libreoffie-7-0 but I don't think LibreOffice 7.0.6 deserves a third RC just for this bug
Comment 10 regis586 2022-02-21 14:12:08 UTC
Created attachment 178437 [details]
Bug-Diagramme-Aspect Modifié

Le diagramme se retrouve "hors-plage" initiale. Les commentaires ajoutés ont disparu. Impossible de reformater correctement le diagramme.
Comment 11 Timur 2022-02-21 14:20:37 UTC
Regis, this bug was fixed and if you are another problem (which seems unrelated) , you need to report separately and do *not* change status here.
Comment 12 regis586 2022-02-21 14:35:56 UTC
Hi,

Sorry, but bug reappears - in worse - with "Stable.." 7.2.5.2 release.

I dont'want losing my diagrams on files, I worked for a long time, at each new version of LO..

I think, I'll stay on 7.1.8 (which works fine (for me..)release for a while..

Best regards.