Bug 138773 - FILEOPEN: OOXML: Incorrect rotation in axis labels
Summary: FILEOPEN: OOXML: Incorrect rotation in axis labels
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Tünde Tóth
URL:
Whiteboard: target:7.2.0 target:7.1.0.2
Keywords: bibisected, bisected, regression
: 138184 (view as bug list)
Depends on:
Blocks: OOXML-Chart
  Show dependency treegraph
 
Reported: 2020-12-09 12:17 UTC by Xisco Faulí
Modified: 2023-07-24 13:23 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison MSO 2010 and LibreOffice 7.2 master (76.99 KB, image/png)
2020-12-09 12:17 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-12-09 12:17:44 UTC
Created attachment 167999 [details]
Comparison MSO 2010 and LibreOffice 7.2 master

Steps to reproduce:
1. Open attachment 93843 [details] from bug 74826

-> Axis labels have no rotation. See comparison image

Reproduced in

Version: 7.2.0.0.alpha0+
Build ID: 84af20ef3ea72190784e9e7be820684c2558ba8c
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2020-12-09 12:20:02 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=21620f9d2f50e66dffc45a5afb539edb8d54434c

author	Tünde Tóth <toth.tunde@nisz.hu>	2020-11-23 15:05:24 +0100
committer	László Németh <nemeth@numbertext.org>	2020-11-24 10:44:54 +0100
commit 21620f9d2f50e66dffc45a5afb539edb8d54434c (patch)
tree cb1f5ebdefb9053ac987b058f42c6094420249bc
parent 3be5e428d669accd841949662d601a6f6e1cdb3f (diff)
tdf#138194 Chart OOXML import: set text break to true

Bisected with: bibisect-linux64-7.2

Adding Cc: to Tünde Tóth
Comment 2 NISZ LibreOffice Team 2020-12-22 08:43:43 UTC
I have noticed this in a lot of our own chart-files too.

This chart (and a lot of other default ones) does not specify an explicit rotation value, which means the default horizontal text direction is not taken literally, it depends on the amount of axis labels and their length.

This chart also uses the Label interval setting of 2, which is not supported by LO (I'll file an enhancement :)). Play with this to see what I mean with the above:
- if you set this interval to automatic (1) in Word, double amount of axis labels is displayed, like in Writer. They get rotated to 270 degrees in Word like: |
- with the setting of 2 the labels are rotated to -45 degrees in Word like: /
- with the setting of 4 the labels are actually horizontal like _ since this way there is so few of them that they fit horizontally.

Word would in all these cases still display "Horizontal" text direction, but in reality it measures the text length and finds the most optimal rotation.

I think it would be best to revert that patch and later implement some sort of "Automatic" rotation setting.
Comment 3 Commit Notification 2021-01-08 12:54:57 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2752fd1b665694a4db3a4e34c7fdc8780a86492e

tdf138773 Chart OOXML import: set text overlap to false

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2021-01-08 18:59:52 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/7517ec45b928fff56ba4526d5877a9ed71d500a7

tdf138773 Chart OOXML import: set text overlap to false

It will be available in 7.1.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2021-01-11 16:38:29 UTC
Verified in

Version: 7.2.0.0.alpha0+
Build ID: 5adc93a9a9426ef79054751be2904896f787a8a2
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Tünde Tóth, thanks for fixing this issue!!
Comment 6 Gabor Kelemen (allotropia) 2023-07-24 13:23:42 UTC
*** Bug 138184 has been marked as a duplicate of this bug. ***