Bug 138868 - UI: object selected on canvas is not indicated in Navigator
Summary: UI: object selected on canvas is not indicated in Navigator
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0
Keywords:
: 149005 (view as bug list)
Depends on:
Blocks: Navigator
  Show dependency treegraph
 
Reported: 2020-12-12 19:32 UTC by Telesto
Modified: 2022-11-07 19:28 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (920.46 KB, application/vnd.oasis.opendocument.graphics)
2020-12-12 19:32 UTC, Telesto
Details
example drawing with Navigator selection -- highlighted & focused (344.36 KB, image/png)
2020-12-12 20:29 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-12-12 19:32:34 UTC
Description:
UI: Navigator doesn't highlight selected object

Steps to Reproduce:
1. Open the attached file
2. Open sidebar -> Navigator tab
3. Select Shape
4. Select image

Actual Results:
Image nor shape get highlighted when selected

Expected Results:
I would like it


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 796c7f612603490dda9277ced0f6ab3cce3bc116
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-12-12 19:32:47 UTC
Created attachment 168113 [details]
Example file
Comment 2 V Stuart Foote 2020-12-12 20:23:29 UTC
Can not confirm. From Sidebar -> Navigator either the shape or the image will be "highlighted" in the tree list, and also shows correspondingly with focus on the drawing canvas.

=> WFM

Maybe a screen clip to show what you see on Sidebar & document canvas?

=-testing-=

Version: 7.2.0.0.alpha0+ (x64)
Build ID: ecb916667b633f8647790e040226b093760e6cfe
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 3 V Stuart Foote 2020-12-12 20:29:27 UTC
Created attachment 168117 [details]
example drawing with Navigator selection -- highlighted & focused
Comment 4 Telesto 2020-12-12 20:37:05 UTC
Hmm, will update to latest master & check again..
Comment 5 Telesto 2020-12-12 21:28:37 UTC
(In reply to V Stuart Foote from comment #3)
> Created attachment 168117 [details]
> example drawing with Navigator selection -- highlighted & focused

Ok.. I was talking about the 'opposite' approach. Click shape/image in canvas.. and expecting it to be selected in navigator.. You likely tested clicking image/shape in navigator, which select them on canvas..

Sorry for the fuzz.. Somehow I still manage to type my STR for 50% after all this time :-(

1. Open the attached file
2. Open sidebar -> Navigator tab
3. Select Shape on canvas
4. Select image on canvas
Comment 6 V Stuart Foote 2020-12-13 16:42:43 UTC
Jim, can an object selection made on canvas be linked back to select its object in Navigator?  Should it?
Comment 7 Heiko Tietze 2020-12-15 09:56:57 UTC
It depends on the module. Writer does highlight the respective node in the Navigator when an object is selected in the document but Draw does not. Selection in the Navigator works (single click for Draw, double for Writer- which makes sense).

Version: 7.2.0.0.alpha0+
Build ID: 1b69f0c2731ec66e76073ab0f2936b7112bf1e77
CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5
Locale: de-DE (en_US.UTF-8); UI: en-US
Calc: threaded

Switching shapes in Draw shows some warnings in the console:

warn:legacy.osl:98958:98958:svx/source/dialog/rulritem.cxx:677: Wrong MemberId
warn:sd.core:98958:98958:sd/source/core/PageListWatcher.cxx:96: ImpPageListWatcher::GetSdPage(PageKind::Standard): page number 1 >= 1
Comment 8 Jim Raykowski 2020-12-17 07:22:10 UTC
While doing things for bug 34828, I looked at what it would take to do this. It seemed to me it would take some effort to achieve.
Comment 9 Jim Raykowski 2022-05-29 07:21:37 UTC
Here is effort for this request:
https://gerrit.libreoffice.org/c/core/+/135084
Comment 10 Commit Notification 2022-08-01 04:00:51 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c4fa91bf5b64e052d22d910097f2aca270fb86dc

tdf#138868 SdNavigator: track object selected on canvas

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2022-08-08 19:40:34 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/469414e66f2b55c06439aaf062aa6dae66ef3096

tdf#138868 follow up: fix selected entry not unselected

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2022-10-23 07:46:10 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/158014e9aecbec6afb0ebf3aceb8b09e4a64b8e0

tdf#138868 SdNavigator: Select in the objects tree all marked objects

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2022-10-30 06:31:30 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5f5f3173e5e51d4bf55fc043a153e20630fde4cc

tdf#138868 related: Update Navigator tree selections on UNO SelectAll

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Commit Notification 2022-10-30 06:32:38 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/79fe1c3252f685ce2f90a2243bcd1ac52d67c5bf

tdf#138868 related: Update Navigator on Esc key unmarking

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Roman Kuznetsov 2022-11-07 19:28:23 UTC
*** Bug 149005 has been marked as a duplicate of this bug. ***