Created attachment 43923 [details] explanation and screenshots of navigator problem In navigator never appears "Drawing objects". Used LibreOffice 3.3.1.2 Mandriva 64 bit Kde 4.4 and windows xp 32 bit In attachment explanation and screenshots of navigator problem.
(In reply to comment #0) > In navigator never appears "Drawing objects". If you want to see "Drawing objects" in the navigator, you may name these objects. Right-clic > Name. Don't remember, but i think it is the same in OpenOffice.
(In reply to comment #1) > (In reply to comment #0) > > In navigator never appears "Drawing objects". > > If you want to see "Drawing objects" in the navigator, you may name these > objects. Right-clic > Name. > > Don't remember, but i think it is the same in OpenOffice. Indeed you need to name the draw objects to make them appear here. This would be an enhancement to have them shown here.
Thanks about Name. I do not know about this.
[This is an automated message.] This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it started right out as NEW without ever being explicitly confirmed. The bug is changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases. Details on how to test the 3.5.0 beta1 can be found at: http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1 more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html
reproduced in LibO 3.5.0 beta 1
This is a general UI issue, right? Therefore changed 'Component' field accordingly.
In Draw Navigator shows all draw objects, even any simple line, if you enable 'Show Shapes -> All Shapes'. This problem does not exist there. Bu I can confirm the problem for Writer and Calc, there always exists an item "Draw Objects", where I even can select a 'Drag Mode', but that's useful for nothing if there are no shapes listed. So I consider this one a bug. That never worked in LibO or OOo, see "AOOo#17444 - unnamed objects in navigator" May be we simply need in heading of Navigator the icon 'Show Shapes -> All Shapes' as we have it in Draw / Impress? @Thorsten: Can you please rate the easyhack proposal? I had to learn that many issues related to inherited Draw code are not as simple as they might look.
This problem seems to come from the fact that drawing objects added in Writer are not named by default. Naming them as "Drawing 1", "Drawing 2", etc. by default could probably help.
In order to limit the confusion between ProposedEasyHack and EasyHack and to make queries much easier we are changing ProposedEasyHack to NeedsDevEval. Thank you and apologies for the noise
(In reply to Jean-Francois Nifenecker from comment #8) > This problem seems to come from the fact that drawing objects added in > Writer are not named by default. Naming them as "Drawing 1", "Drawing 2", > etc. by default could probably help. I would appreciate a default naming of drawing objects. All other objects (tables, comments,..) are named by default, only drawing objects are not named. Also particularly if an object is covered by another object this is only way to select the covered object without modifying the covering object. Furthermore I propose that the default name also indicates the kind of an object. E.g. Rectangle1, Rectangle2, Circle1, Square1, ...
Migrating Whiteboard tags to Keywords: (needsDevEval difficultyInteresting skillCpp topicUI) [NinjaEdit]
Created attachment 123588 [details] How it would look like with all shapes appearing
Have a patch for this here: https://gerrit.libreoffice.org/#/c/23265/ which enables show unnamed shapes. However, I am not sure this is the right approach. Maybe we should rather go with default names for shapes as we do with images?
I use a Version: 5.2.0.0.alpha0+ Build ID: 129d199d27f6961ea0c850686f76c83e2fc1953d CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2016-03-11_06:16:01 Locale: de-DE (de_DE) If I insert a Draw object into a Writer document, it is named automatically and therefore it is listed in the Navigator. So for Writer nothing is to do.
(In reply to Regina Henschel from comment #14) > If I insert a Draw object into a Writer document, it is named automatically > and therefore it is listed in the Navigator. So for Writer nothing is to do. Oh this seems to have changed in 5.2 - thanks for testing. So I guess this can be closed then :)
It is only solved in Writer, in Calc they are not named automatically. And for Calc the discussion remains whether to use the solution of Writer to name them automatically or use the solution of Draw/Impress to have a special mode (with icon in Navigator) to show or hide unnamed objects.
Current situation: Beginning with version 5.1.0 drawing objects are named automatically with Shape1, Shape2, ... in Writer. A differentiation between kinds of objects (line, rectangle, Circle, ...) is not performed like proposed in comment 10 and comment 12. In Calc neither in version 5.1.0 nor in version 5.2.0 an automatic naming of drawing objects is performed. Hence this bug is not completely fixed. Set back to NEW.
Replacing our use of the 'ux-advise' component with a keyword: Component -> UI Add Keyword: - No needsUXEval necessary.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Still reproducible. Version: 6.2.0.0.alpha0+ (x64) Build ID: 18c5089df091bddeb8c2dc339776671964389040 CPU threads: 8; OS: Windows 10.0; UI render: GL; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-09-12_23:24:12 Locale: de-AT (de_AT); Calc: CL
(In reply to Thomas Lendo from comment #20) > Still reproducible. When opening the first attached file (attachment 43923 [details]) I do not see them in the Navigator. But - starting a new Writer document; - using Drawing toolbar; - clicking a shape and drawing it in the document >> F5 shows "shape 1", "shape 2" etc Version: 6.2.0.0.alpha0+ Build ID: 8c20d5d4ad6f3e8c672337e3ba67be45a1ccb7c2 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-09-14_02:29:28 Locale: nl-NL (nl_NL.UTF-8); Calc: threaded So..
(In reply to Cor Nouws from comment #21) > When opening the first attached file (attachment 43923 [details]) I do not > see them in the Navigator. > But > - starting a new Writer document; > - using Drawing toolbar; > - clicking a shape and drawing it in the document > >> F5 shows "shape 1", "shape 2" etc Right, but not in Calc.
(In reply to Thomas Lendo from comment #22) > Right, but not in Calc. Ah.. better make a separate issue for that?
(In reply to Cor Nouws from comment #23) > Ah.. better make a separate issue for that? I'd go with the existing bug. All necessary information is here for future commits.
(In reply to Harald Koester from comment #17) > Beginning with version 5.1.0 drawing objects are named automatically with > Shape1, Shape2, ... in Writer. A differentiation between kinds of objects > (line, rectangle, Circle, ...) is not performed like proposed in comment 10 > and comment 12. For reference, this was done by the following commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3647626309ef89bf90d8b6a6539d41d8deb6b482 author Caolán McNamara <caolanm@redhat.com> 2015-09-17 13:55:28 +0100 committer Caolán McNamara <caolanm@redhat.com> 2015-09-17 14:12:08 +0100 Give drawing objects unique names by default
*** Bug 124989 has been marked as a duplicate of this bug. ***
Please add keyword 'needsUXEval' and CC 'libreoffice-ux-advise@lists.freedesktop.org' if input from UX is needed.
*** Bug 134344 has been marked as a duplicate of this bug. ***
*** Bug 134378 has been marked as a duplicate of this bug. ***
*** Bug 137837 has been marked as a duplicate of this bug. ***
Shall we switch the default of the Show Shapes selection from "Named Shapes" to "All Shapes"?
(In reply to Heiko Tietze from comment #32) > Shall we switch the default of the Show Shapes selection from "Named Shapes" > to "All Shapes"? From my perspective +1
We discussed the topic in the design meeting and recommend to change the default from "Only named shapes" to "All shapes" but keep both for the rare workflows where unnamed objects should be hidden. This applies also to other modules. Jim, one for you or make it an easyhack?
I'll take this as it is something that is able to utilize effort made to ensure object name uniqueness when cloning draw objects. If this patch proves correct, current code specific for draw objects name uniqueness in Writer should be able to be removed. It works the same across all modules. https://gerrit.libreoffice.org/c/core/+/105774
(In reply to Jim Raykowski from comment #35) > I'll take this as it is something that is able to utilize effort made to > ensure object name uniqueness when cloning draw objects. Uniqueness is one reason but the other is the ability to hide items in the Navigator. Removing the option might feel like a regression for many.
(In reply to Heiko Tietze from comment #36) > Uniqueness is one reason but the other is the ability to hide items in the > Navigator. Removing the option might feel like a regression for many. An object can be hidden by editing the name and setting it empty. Better might be a setting somewhere in the Options dialog to enable or disable automatic object names.
Additional effort to provide unique names based on object type has been done in patch set 3. The patch seems to also fix crash reported in Bug 130629.
Created attachment 167325 [details] unique drawing object names demo 1
(In reply to Jim Raykowski from comment #39) > Created attachment 167325 [details] > unique drawing object names demo 1 yes please this is the way to go. thanks a lot
In addition to the command label name the command icon should be used. If you need new icons for something, let me know.
Created attachment 167326 [details] unique drawing object names demo 2
That's great that text boxes (Fontwork) use the text as label name. This is well known from Gimp or PS. how would it work with Text boxes where you have a lot text? show only the first 2 names,.. ?
Created attachment 167327 [details] unique drawing object names demo 3
(In reply to andreas_k from comment #43) > That's great that text boxes (Fontwork) use the text as label name. This is > well known from Gimp or PS. how would it work with Text boxes where you have > a lot text? show only the first 2 names,.. ? I don't think Fontworks with a lot of text will affect the label name. They are created from the STR_ObjNameSingul defines in include/svx/strings.hrc
(In reply to andreas_k from comment #41) > In addition to the command label name the command icon should be used. > I'll look into it. > If you need new icons for something, let me know. Thanks!
Wouldn't Shape 1 Shape 2 Shape n be better than Shape Shape_0 Shape_1 Shape_n (Start with 1, add a number to every item; and double-check what happens when "Shape X" is deleted- replace the number or keep empty)
(In reply to Jim Raykowski from comment #45) > I don't think Fontworks with a lot of text will affect the label name. They > are created from the STR_ObjNameSingul defines in include/svx/strings.hrc True. When you add an a Text Box in writer it was listed as >>Shape 1<<. If possible I suggest for Text Boxe to use the label first x names of the Text Box.
(In reply to Heiko Tietze from comment #47) > Wouldn't > > Shape 1 > Shape 2 > Shape n > FWIW: This reminds me about a image/shape naming issue in Writer. I did argue about different naming style (especially in case of copy's of names items) and order they are presented in. In Writer Shape 100 can be first shape on page etc. While number suggesting a hierarchical order. Will search for the relevant bug report/comment soon
(In reply to Telesto from comment #49) > Will search for the relevant bug report/comment soon Bug 134960 [mostly containing my own opinion, without magic bullet]. However not big fan of numbering items. And if this would be numbering, don't start with 0. But with say 0001 to get a nice list. Or align with what with digital camera's use. Say: IMGP3606 IMG (Image) + P (Picture) + Number (And everything BOLD and without space to make it it easy to read. Smallcap/Caption bit restless to look at, IMHO Of course not knowing what the format would be for say shape? SHPP? Shape (SHP) + P (Picture?) + number?
Forgot: Maybe name everything internally: IMGP0001 and up (ideally in order with document structure). While next to that is a naming attribute/column with the user defined name. As long as empty they User Defined name will be the internal name. Additional option would be to make unique IMG dynamic. So if image IMGP0200 is pasted before IMGP0001, IMGP0001 will change in IMGP0002 and IMGP0200 becoming IMGP0001. But that's my fantasizing around. Not sure how useful (and CPU expensive) that would become; or how hard to follow code-wise. Only some thoughts :-)
Created attachment 167490 [details] unique drawing object names demo 4
Created attachment 167491 [details] unique drawing object names demo 5
(In reply to Heiko Tietze from comment #47) > Wouldn't > > Shape 1 > Shape 2 > Shape n > > be better than > > Shape > Shape_0 > Shape_1 > Shape_n > > (Start with 1, add a number to every item; and double-check what happens > when "Shape X" is deleted- replace the number or keep empty) I agree. Please see demo 4 and 5 which show patch set 5 effort to do this.
They demo is about they initial insertion phase. Or is this they scope as such? Else i would like to know what happens on open foreign formats. Or if someone opens a file with say multiple objects without name? Anyhow thanks for looking at this
(In reply to Telesto from comment #55) > Else i would like to know what happens on open foreign formats. Or if > someone opens a file with say multiple objects without name? > When a file is opened objects without names remain without names. As far a I can tell foreign file formats are unaffected on opening.
(In reply to Jim Raykowski from comment #54) > I agree. Please see demo 4 and 5 which show patch set 5 effort to do this. Awesome! I wonder what happens when you delete "Shape 2" and three have been added. And it's also important to allow both show and hide the "unnamed" objects (now with inverted logic where all are shown by default).
Created attachment 167525 [details] unique drawing object names demo 6 (In reply to Heiko Tietze from comment #57) > Awesome! I wonder what happens when you delete "Shape 2" and three have been > added. The next shape added will receive the name "Shape 2". Demo 6 shows this and a self surprise finding that inserted controls fall under drawing objects. > And it's also important to allow both show and hide the "unnamed" > objects (now with inverted logic where all are shown by default). Is this only for Draw/Impress? With this patch, the only way to make an "unnamed" object is to rename the object with no name.
(In reply to Jim Raykowski from comment #58) > > And it's also important to allow both show and hide the "unnamed" > > objects (now with inverted logic where all are shown by default). > > Is this only for Draw/Impress? With this patch, the only way to make an > "unnamed" object is to rename the object with no name. It's relevant for all modules, see also bug 137837. Most users struggle with not visible objects but some may use it to hide a number of objects by not naming them. And the idea was to keep the function but switch its default. I would expect to not see any "<Shape|PolyLine|etc> 1..n" object when the option is off.
Created attachment 167656 [details] patch set 7 Draw/Impress demo Patchset 7 makes selection of an unnamed or named object in the Draw/Impress Navigator tree select the object in the document. For Draw/Impress, order plus object type is used for unnamed shape object identification in the Navigator tree. These names are not assigned to the shape object. Calc and Writer Navigators do not have the unnamed/named object feature. For these, unique object names are assigned to the shape object. Demo7 shows Draw/Impress Navigator unnamed/named object selection and that object name assignment does not happen automatically.
(In reply to Jim Raykowski from comment #60) > Patchset 7 makes selection of an unnamed or named object... Awesome! I assume renaming "Shape 1 (Circle)" not to shape1 but again "Shape 1 (Circle)" makes it also a user-named object. Does it? Not a big deal if not, the type in addition to the actual name makes it very unlikely that users use this exact string.
(In reply to Heiko Tietze from comment #61) > Awesome! I assume renaming "Shape 1 (Circle)" not to shape1 but again "Shape > 1 (Circle)" makes it also a user-named object. Does it? I didn't test this case until you mentioned it. Indeed it does make it a user-named object. Automatic unnamed object naming appears to work as expected after doing so. Patchset 8 makes the Draw/Impress Navigator list all shapes by default. Possibly this patch should be split into four parts, 1) Writer and Calc drawing object automatic naming. 2) Draw/Impress unnamed shape name (shape type) is appended. 3) Draw/Impress Navigator unnamed shape object selection selects shape object in the document. 4) Draw/Impress Navigator list all shapes by default. or just keep these all together in one patch as is already done?
(In reply to Jim Raykowski from comment #62) > or just keep these all together in one patch as is already done? No preference from my side here.
(In reply to Heiko Tietze from comment #63) > (In reply to Jim Raykowski from comment #62) > > or just keep these all together in one patch as is already done? > > No preference from my side here. Splitting maybe useful for debugging/bibisecting. Delivering more specific results. And would make it possible to selectively revert something in worse case. But the unwritten rules on this can be found in the irc dev channel; long term experts on the matter. No idea which kind of side-effects should be expected, if there is something....
Splitting the patch up seems like the best thing to do. Here are links to each: sd navigator: make 'All shapes' the default https://gerrit.libreoffice.org/c/core/+/106955 sd navigator: enhance automatic shape name https://gerrit.libreoffice.org/c/core/+/106957 sd navigator: make unnamed shape select, select shape object https://gerrit.libreoffice.org/c/core/+/106958 Give draw object a name when made https://gerrit.libreoffice.org/c/core/+/105774
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/70fd160ea0c2a2afeee520f450f1ed4f81fa88f3 tdf#34828 sd navigator: make 'All shapes' the default It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cbc43bef143f3109bdf3bf981317ae74b73cde5a tdf#34828 sd navigator: enhance automatic shape name It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f0878173e1963cf8db5f60ced6d19da24e18bc41 tdf#34828 sd navigator: make unnamed shape select select shape object It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/986952dd52861563006d0ba178e8bdd44247af81 tdf#34828 sd navigator: fix crash when page item entry is selected It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 90277 has been marked as a duplicate of this bug. ***
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/50b731c84cb17d7f05a690d90588e90ee267d1c2 tdf#34828 Give draw object a name when made It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Notes for unit test writers: Revert has to be done manually. Could be a bit complicated as there are multiple commits.