Created attachment 157831 [details] Backtrace Crash only happens when the shape is inserted with the single click method, by Ctrl-clicking on the toolbar button. - Start a new document. - Add a shape by Ctrl-clicking on the basic shape icon on the toolbar. - Press undo until there are no more undo steps (takes 2 undos for some reason). - Click on the basic shape icon on the toolbar (this just unselects the button). - Ctrl-click on the basic shape icon on the toolbar. => Crash. Attaching backtrace. Observed using LO 7.0.0.0.alpha0+ (d41d7ecb60fb38204fafcb1aa4595992721855e6), 3.3.0 / Ubuntu.
Created attachment 158902 [details] tdf130629_attempt.patch: only works for gdb Outside of GDB, it crashes even when mpImpl has a value.
I noticed this while poking around bug 34838 and was going to report but found it has already been reported. Here is a patch to fix what seems to be the cause of the crash: https://gerrit.libreoffice.org/c/core/+/105955
(In reply to Jim Raykowski from comment #2) > I noticed this while poking around bug 34838 and was going to report but poking around bug 34828
(In reply to Jim Raykowski from comment #2) > I noticed this while poking around bug 34838 and was going to report but > found it has already been reported. Here is a patch to fix what seems to be > the cause of the crash: > https://gerrit.libreoffice.org/c/core/+/105955 Hi Jim, Thanks for the fix. UItest submitted here: https://gerrit.libreoffice.org/c/core/+/105956
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5110cca39cc55c8977b81f7b09873e626144b29b tdf#130629 Don't add object insert undo twice It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f7c8535a1e0bf2deda6c5f6d8d8469f5ab7fa07f tdf#130629: sw: Add UItest It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/46d6effe3373a39938bde57b43dc45c4a30ce33f tdf#130629 Don't add object insert undo twice It will be available in 7.0.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
@Áron: Is it possible, that Jim's commit has fixed this issue?
Indeed, it certainly looks fixed, the bug report was just forgotten about. Thanks for the fix, Jim!
UITest added. Setting to VERIFIED
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/48aac3c1d06994d17f20dbdc2ad8add722192ec3 tdf#130629: sw: Move UItest to CppUnitTest It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.