Bug 140074 - Clicking on items in Autofilter does not change their checked state (gtk3)
Summary: Clicking on items in Autofilter does not change their checked state (gtk3)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.1.0.2 rc
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: GTK3 AutoFilter
  Show dependency treegraph
 
Reported: 2021-02-01 22:28 UTC by Petr Valach
Modified: 2022-07-20 09:07 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
autofilter (9.53 KB, application/vnd.oasis.opendocument.spreadsheet)
2021-02-02 11:50 UTC, Petr Valach
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Valach 2021-02-01 22:28:12 UTC
Step for reproduce:
1. Install LibreOffice 7.1 RC3.
2. Run Calc.
3. Fill cells in table, make Autofilter.
4. Try to select items in Autofilter by clicking on them.

Result:
Nothing happened. You can select items only via checkboxes.

Note:
Solved in tdf#116675.


Version: 7.1.0.3 / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded
Comment 1 Peter S Anderson 2021-02-02 07:09:24 UTC Comment hidden (obsolete)
Comment 2 Petr Valach 2021-02-02 11:50:01 UTC
Created attachment 169391 [details]
autofilter
Comment 3 Petr Valach 2021-02-02 11:50:44 UTC
(In reply to Peter S Anderson from comment #1)
> Hi Petr,
> Would you please send us a spreadsheet which behaves as you describe.
> Thanks…..Peter.

Of course. Any Calc file.
But I see one interesting thing:

In KDE: It's OK only with KDE integration pack (I don't use it because I cannot use Unicode commands for inserting characters)
In Cinnamon: bug in any case.
Comment 4 QA Administrators 2021-02-03 04:16:12 UTC Comment hidden (obsolete)
Comment 5 Buovjaga 2021-02-16 06:00:27 UTC
Repro with file, but only with gtk3

Arch Linux 64-bit
Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: dcce840cb2383873cc77da04b0bdc4526042c212
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 14 February 2021
Comment 6 Petr Valach 2021-02-20 19:49:51 UTC
(In reply to Buovjaga from comment #5)
> Repro with file, but only with gtk3
> 
> Arch Linux 64-bit
> Version: 7.2.0.0.alpha0+ / LibreOffice Community
> Build ID: dcce840cb2383873cc77da04b0bdc4526042c212
> CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
> Locale: fi-FI (fi_FI.UTF-8); UI: en-US
> Calc: threaded
> Built on 14 February 2021

Yep, as I said, in KDE no problem but only with kde-integration pack installed. Using this pack is problematic (bug #140251).
Comment 7 Caolán McNamara 2022-07-19 11:13:55 UTC
Looking at gtk3-demo and glade where there is a treeview with such toggle buttons in them I don't find cases where clicking on the text auto-toggles the toggle button so the defacto expectation for that toolkit doesn't seem to be to auto-toggle in this case. Though its probably possible to bodge it in some way. (FWIW keyboard "space" will toggle them)
Comment 8 Attila Szűcs 2022-07-20 09:07:41 UTC
Sorry, tdf#116675 is only for generic vcl plugin, i don't know how to implement the same for gtk.

A related change is: tdf#139115 what limit this 1-click-toggle behaviour to a very few treelists.
Also added an other behaviour, the 2 clicks to toggle (first only select, second toggle), but i think it is not used anywhere yet.
All other treelist will toggle only with the checkbox.

A quick search for "set_clicks_to_toggle" in the code, shows it is used only in 4 places.