Bug 140755 - Blurred text in images
Summary: Blurred text in images
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
7.1.1.2 release
Hardware: All All
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 140768 141185 (view as bug list)
Depends on:
Blocks: SoftEdgeFallout
  Show dependency treegraph
 
Reported: 2021-03-02 10:18 UTC by Xisco Faulí
Modified: 2022-02-21 13:30 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot (73.80 KB, image/png)
2021-03-02 10:18 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2021-03-02 10:18:24 UTC
Created attachment 170173 [details]
screenshot

Steps to reproduce:
1. Open attachment 167713 [details] from bug 138598

-> Text in images is blurred. See screenshot

Reproduced in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 94283af977246c70dbed4452d197b003d8bb14b9
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2021-03-02 10:26:01 UTC
Not reproducible in

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a889bca4a1912da1e402181d8acd6ef7683e2f53
CPU threads: 16; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-US
Calc: threaded

thus, SKIA rendering is not affected
Comment 2 Xisco Faulí 2021-03-02 10:27:55 UTC
Using GTK3 on Linux or default rendering on Windows, the issue started to happen after

https://cgit.freedesktop.org/libreoffice/core/commit/?id=9d89d98d3349502b56da4bdd6ea287ac4cde9ce5

author	Luboš Luňák <l.lunak@collabora.com>	2021-02-10 17:15:19 +0100
committer	Luboš Luňák <l.lunak@collabora.com>	2021-02-12 11:18:09 +0100
commit 9d89d98d3349502b56da4bdd6ea287ac4cde9ce5 (patch)
tree 4858b412c5322a9a6f23ea191dba40143b520649
parent f52c5bea7775ac07cfacc232f0979a03bbdf9aa7 (diff)
always optimize bitmap transform to translate+scale if possible (tdf#138068)

Bisected with: bibisect-linux64-7.2

Adding Cc: to Luboš Luňák
Comment 3 Xisco Faulí 2021-03-02 10:29:05 UTC
OTOH, if I use GEN on Linux, the issue happens since

https://cgit.freedesktop.org/libreoffice/core/commit/?id=bf021c369f2306ee507da9bd3cc4cd10ac5d234c

author	Mike Kaganski <mike.kaganski@collabora.com>	2020-08-13 18:12:37 +0300
committer	Mike Kaganski <mike.kaganski@collabora.com>	2020-08-14 01:00:04 +0200
commit bf021c369f2306ee507da9bd3cc4cd10ac5d234c (patch)
tree a3dc2552801cfe31cb524c6f375980eaa48e844b
parent 56d5531373cf0588e02c254ea8ffa00221c8342b (diff)
tdf#135500: always use transparent and clear content vdev in impBufferDevice

Bisected with: bibisect-linux64-7.1

Adding Cc: to Mike Kaganski
Comment 4 Xisco Faulí 2021-03-03 08:10:38 UTC
*** Bug 140768 has been marked as a duplicate of this bug. ***
Comment 5 Alberto Salvia Novella 2021-03-03 10:13:08 UTC Comment hidden (no-value)
Comment 6 Telesto 2021-03-03 15:51:39 UTC
@Xisco
Would a meta-bug be helpful? There are bunch of bugs pointing to the same commit
Comment 7 Mike Kaganski 2021-03-03 15:53:49 UTC
(In reply to Telesto from comment #6)
> Would a meta-bug be helpful? There are bunch of bugs pointing to the same
> commit

... and there is one.
Comment 8 Xisco Faulí 2021-03-09 16:15:51 UTC
This issue is fixed by

author	Luboš Luňák <l.lunak@collabora.com>	2021-03-04 15:35:44 +0100
committer	Luboš Luňák <l.lunak@collabora.com>	2021-03-08 13:46:36 +0100
commit 6b8c157a0b4f37a09fdbf656919b2df06a3abc3e (patch)
tree 52451b3b5152511cb4fb68a2f09867bc9db85592
parent db2e9619397f1e53232824a649b5ad0ba3dd368a (diff)
make RenderMaskPrimitive2DPixel() clip using clipping (tdf#140797)
Comment 9 Luboš Luňák 2021-03-09 18:33:30 UTC
If my change "fixes" this, then it's rather just worked around. Rotate the image slightly, that should still use the old code path and the problem should be still there. Also the impBufferDevice class is used in other places, so those may be possibly also affected.
Comment 10 Xisco Faulí 2021-03-10 19:13:22 UTC
(In reply to Luboš Luňák from comment #9)
> If my change "fixes" this, then it's rather just worked around. Rotate the
> image slightly, that should still use the old code path and the problem
> should be still there. Also the impBufferDevice class is used in other
> places, so those may be possibly also affected.

For your information, your commit also fixed bug 136841, bug 138573 and bug 136570. Maybe it also fixed some other reports...
Comment 11 Xisco Faulí 2021-03-31 09:04:25 UTC
*** Bug 141185 has been marked as a duplicate of this bug. ***
Comment 12 Justin L 2022-02-21 13:30:47 UTC
(In reply to Luboš Luňák from comment #9)
> If my change "fixes" this, then it's rather just worked around. Rotate the
> image slightly, that should still use the old code path...

I rotated attachment 167713 [details]'s image by 2 degrees. It looked relatively good in 7.0, and didn't seem to be affected by Mike's 7.1 patch (comment 3).

Marking as FIXED again. A problematic sample document would be needed to re-open.