Bug 141192 - EDITING: Incorrect width/height in table after undoing cell merging
Summary: EDITING: Incorrect width/height in table after undoing cell merging
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Crash
  Show dependency treegraph
 
Reported: 2021-03-23 08:11 UTC by Xisco Faulí
Modified: 2023-09-22 02:35 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
How the table looks after undo (17.29 KB, image/png)
2021-03-23 08:11 UTC, Xisco Faulí
Details
incorrect table width at undo merge v.24.2 (1.86 KB, image/png)
2023-09-22 02:35 UTC, Kira Tubo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2021-03-23 08:11:26 UTC
Created attachment 170649 [details]
How the table looks after undo

This is a follow-up of bug 136956

Steps to reproduce:
1. Open Impress
2. Insert a 3x3 table ( the whole table is selected )
3. Merge Cells
4. Undo

-> The rows in the table have incorrect height. Same for the columns, they have incorrect width

Reproduced in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 5262a9e88037decc26da84e7fa62f2955d4cdb85
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 pavlog 2021-04-15 18:20:05 UTC
I've got a crash both in 

Version: 7.2.0.0.alpha0+ (x64)
Build ID: ecb916667b633f8647790e040226b093760e6cfe
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

https://crashreport.libreoffice.org/stats/crash_details/53c07f24-63f4-4242-99ca-1b37fa2b47e0

Version: 7.1.2.2 (x64) / LibreOffice Community
Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

https://crashreport.libreoffice.org/stats/crash_details/3dcc5291-5579-4d25-93de-100f97b92664
Comment 2 pavlog 2021-04-15 19:32:42 UTC
Repro in

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 6e6e531b564cdc9d5b25287c215cdc5a1fcbb346
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL
Comment 3 QA Administrators 2023-04-16 03:24:46 UTC Comment hidden (obsolete)
Comment 4 Kira Tubo 2023-09-22 02:34:05 UTC
Bibisected win64-7.2. Adding Mark Hung to cc. 

Regression occurring at: https://git.libreoffice.org/core/+/f3f7cc53efda828af8897fa45fa2a8f18cf3b48b

Commit mentioned above was done to fix crashing at Undo as mentioned in Comment 1. See Bug 136956 for more info. 

---------------------
commit f3f7cc53efda828af8897fa45fa2a8f18cf3b48b	[log]
author	Mark Hung <marklh9@gmail.com>	Thu Mar 11 23:44:06 2021 +0800
committer	Mark Hung <marklh9@gmail.com>	Tue Mar 16 15:23:58 2021 +0100
tree 4a3655bed2157107a74b256e9d5316a550d24120
parent fd9b1fbcae5d90d7e542dae999cffda9a0f928f0 [diff]
---------------------
commit acbfaaab9453bf3f4bbc5f01d7f11fd6fbaf28d2
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Fri Mar 26 10:15:40 2021 -0700

    source f3f7cc53efda828af8897fa45fa2a8f18cf3b48b
Comment 5 Kira Tubo 2023-09-22 02:35:02 UTC
Created attachment 189749 [details]
incorrect table width at undo merge v.24.2

Issue mentioned in OP steps is still reproducible in daily master build, though the result is slightly different. Row heights are correct, but the column width is incorrect.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 486ae5db6987411d5e394de94b2b077099d03856
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded