Bug 143452 - Two buttons in the date form control became untranslatable
Summary: Two buttons in the date form control became untranslatable
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
7.1.4.2 release
Hardware: All All
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:7.3.0 target:7.2.0.2 target:7.1.6
Keywords: bibisected, regression
Depends on:
Blocks: Not-Localizable
  Show dependency treegraph
 
Reported: 2021-07-20 07:33 UTC by Ming Hua
Modified: 2024-07-22 10:01 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ming Hua 2021-07-20 07:33:40 UTC
This is a bug report forwarded from l10n mailing list, see thread starting at:
https://listarchives.libreoffice.org/global/l10n/2021/msg00231.html

Steps to reproduce:
1. Start a new document in Writer;
2. Menu Form > More Fields > Date Field;
3. Use mouse to create a date form control in the document;
4. Right-click on the control, choose "Control Propeties..." from context menu;
5. In the Properties dialog, General tab, scroll down and find "Dropdown" property, set it to "Yes";
6. Close Properties dialog;
7. Turn off form editing in menu Form > Design Mode;
8. Now one can click the dropdown arrow of the form control, there should be a date picker widget popping up.  Two buttons "Today" and "None" are on the widget, they became not localizable since version 7.1, according to the reporter.

Additional information:
I can reproduce that it's not translated for zh-CN in 7.2.0 RC1:
Version: 7.2.0.1 (x64) / LibreOffice Community
Build ID: 32efc3b7f3a71cfa6a7fa3f6c208333df48656cc
CPU threads: 2; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: zh-CN (zh_CN); UI: zh-CN
Calc: threaded
... but did not investigate more about whether it's indeed not localizable or it's a regression from 7.0.
Comment 1 Christian Lohmaier 2021-07-20 12:44:56 UTC
The strings in svtools/uiconfig/ui/calendar.ui don't have the translatable attribute, so not available for translation
Comment 2 Julien Nabet 2021-07-20 21:07:32 UTC
Here's the patch:
https://gerrit.libreoffice.org/c/core/+/119293
Comment 3 Commit Notification 2021-07-21 14:11:51 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/73503ce975ce0923bfe2cfd075ac8b91de20f29e

tdf#143452: make 2 buttons in the date form control translatable

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Julien Nabet 2021-07-21 15:43:49 UTC
fix for 7.2 here: https://gerrit.libreoffice.org/c/core/+/119257

We already know what's the commit which brought the pb=>bibisected.

So we can put this as FIXED now.

Thank you Ming for having spotted this!
Comment 5 Commit Notification 2021-07-21 16:55:39 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/df1453f355fc30cb7a645639ae38d3012098f98a

tdf#143452: make 2 buttons in the date form control translatable

It will be available in 7.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 lol 2021-07-31 05:48:40 UTC
Will this also be fixed in LO 7.1?

In

Version: 7.1.4.2 (x86) / LibreOffice Community
Build ID: a529a4fab45b75fefc5b6226684193eb000654f6
CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

is this also present.
Comment 7 Julien Nabet 2021-07-31 06:47:13 UTC
(In reply to lol from comment #6)
> Will this also be fixed in LO 7.1?
> 
> In
> 
> Version: 7.1.4.2 (x86) / LibreOffice Community
> Build ID: a529a4fab45b75fefc5b6226684193eb000654f6
> CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
> Skia/Raster; VCL: win
> Locale: de-DE (de_DE); UI: de-DE
> Calc: threaded
> 
> is this also present.

I don't think so because the string freeze has been done at the end of 2020
(see https://wiki.documentfoundation.org/ReleasePlan/7.1) but I may be wrong because these were translatable before.
Comment 8 Ming Hua 2021-07-31 18:06:22 UTC
(In reply to Julien Nabet from comment #7)
> (In reply to lol from comment #6)
> > Will this also be fixed in LO 7.1?
> > 
> > In
> > 
> > Version: 7.1.4.2 (x86) / LibreOffice Community
> > Build ID: a529a4fab45b75fefc5b6226684193eb000654f6
> > CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
> > Skia/Raster; VCL: win
> > Locale: de-DE (de_DE); UI: de-DE
> > Calc: threaded
> > 
> > is this also present.
> 
> I don't think so because the string freeze has been done at the end of 2020
> (see https://wiki.documentfoundation.org/ReleasePlan/7.1) but I may be wrong
> because these were translatable before.
I agree with Julien that since 7.1 is a release branch, the string freeze is definitely making things complicated.

That said, exceptions can be made.  If fixing this for 7.1.x series is important to anyone, he/she should follow the procedure, first by writing to the l10n mailing list [1] asking for permission to break the string freeze, and present the case.  As Julien said, since these two strings were not translatable before, technically this change doesn't introduce *new* untranslated strings to any language UI.  So there is probably a good chance the permission is granted.  Once he/she gets the permission, please come back to this bug and ask Julien or other developers to backport this fix to 7.1 branch.

7.1 branch only has two scheduled releases left [2], 7.1.6 in early September and 7.1.7 in early November.  So anyone planning to work on this please have the timeline in mind.

1. Address: l10n@global.libreoffice.org
   Archive: https://listarchives.libreoffice.org/global/l10n/
2. https://wiki.documentfoundation.org/ReleasePlan/7.1
Comment 9 lol 2021-08-06 06:27:10 UTC
It is right that string freeze has been done at the end of 2020. But for  correcting mistakes in the UI and Help strings there can be made an exception. This is written on the follow Wiki page

https://wiki.documentfoundation.org/ReleasePlan#String_freeze

So I think this is such a mistake because the strings were translated in LO 7.0 but not in LO 7.1.
Comment 10 Ming Hua 2021-08-06 07:24:12 UTC
(In reply to lol from comment #9)
> So I think this is such a mistake because the strings were translated in LO
> 7.0 but not in LO 7.1.
If fixing this issue is important to you, act yourself.

I've outlined the needed work in comment #8.  Everything except the last "backporing the commit to 7-1 branch" can be done by an ordinary user like you and I.  And I've done it for a string I feel important to me.

LibreOffice is a project driven by many volunteers.  Don't just comment on Bugzilla and expect the work get done by others.  Put in the work yourself and get your pet bug fixed.
Comment 11 Commit Notification 2021-08-16 14:01:39 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/126952823d3cb8e8227a0b0d2cc7afe404ef12cd

tdf#143452: make 2 buttons in the date form control translatable

It will be available in 7.1.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Ming Hua 2021-09-11 04:14:47 UTC
Confirm fixed with 7.1.6 and 7.2.0 RC3:

Version: 7.1.6.2 (x64) / LibreOffice Community
Build ID: 0e133318fcee89abacd6a7d077e292f1145735c3
CPU threads: 2; OS: Windows 10.0 Build 19043; UI render: default; VCL: win
Locale: zh-CN (zh_CN); UI: zh-CN
Calc: threaded

Version: 7.2.0.3 (x64) / LibreOffice Community
Build ID: 2a7ea282da28d665a7dc086360567b4aea27bf08
CPU threads: 2; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: zh-CN (zh_CN); UI: zh-CN
Calc: threaded

Thanks Julien and everyone involved!