Bug 144016 - Using redo that deletes textbox while textbox is active crashes Draw
Summary: Using redo that deletes textbox while textbox is active crashes Draw
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: high critical
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, haveBacktrace, regression
Depends on:
Blocks: Crash
  Show dependency treegraph
 
Reported: 2021-08-23 07:53 UTC by Sašo Smolej
Modified: 2023-07-28 00:36 UTC (History)
7 users (show)

See Also:
Crash report or crash signature: ["sd::View::SdrEndTextEdit(bool)"]


Attachments
GDB trace of crash (16.62 KB, text/plain)
2021-09-01 06:14 UTC, Buovjaga
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sašo Smolej 2021-08-23 07:53:41 UTC
Description:
After entering a textbox to edit, if the textbox was deleted and deletion undone right before that, using redo will crash Draw.

Steps to Reproduce:
1. Create new Draw document
2. Create a text box with some text
3. Delete the textbox
4. Undo deletion
5. Enter textbox to edit it (do not do anything)
5. Redo deletion

Actual Results:
Crash

Expected Results:
Text box deletion/nothing (nothing to undo in textbox)


Reproducible: Always


User Profile Reset: No



Additional Info:
Crash report: https://crashreport.libreoffice.org/stats/crash_details/e80d3f83-4ad4-4505-bbe9-31be4c50f151
Comment 1 Henrik Palomäki 2021-08-24 12:24:50 UTC
Crash confirmed.

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 0224d859b8a497779611cc15943c017ec42f9b90
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: fi-FI (fi_FI); UI: en-US
Calc: CL
Comment 2 Xisco Faulí 2021-08-24 14:17:58 UTC
Reproduced in

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: fbe183bbb05220a4ccc51952445b1797bb498403
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

and

Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Threads 4; Ver: 5.10; Render: default; 

Locale: en-US (en_US.UTF-8)
Comment 3 Buovjaga 2021-09-01 06:14:34 UTC
Created attachment 174686 [details]
GDB trace of crash

Arch Linux 64-bit
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: a58b9010b38ca43d4b3a2b30fcd6bec28db1b344
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 31 August 2021
Comment 4 Xisco Faulí 2021-09-01 11:51:08 UTC
Hi Mark,
Since you fixed bug 131634 I thought you might be interested in this issue
Comment 5 Aron Budea 2021-09-06 04:06:04 UTC
This regressed from the same commit Caolán identified in bug 131634 comment 7.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=12a4200e8ff7f045efcc7e9d15a24b15b248c437
author		Armin Le Grand <alg@apache.org>	2012-08-09 08:42:27 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2013-05-28 15:55:23 +0100

Related: #i120498# Enhanced Undo/Redo and user experience...
Comment 6 Matt K 2023-07-28 00:06:31 UTC
Seems to be fixed in the following:

Version: 7.3.2.2 (x64) / LibreOffice Community
Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Setting to NEEDINFO
Comment 7 Aron Budea 2023-07-28 00:36:26 UTC
Yes, this seems to be fixed in 7.3.0.3, redoing is greyed out when the caret is in the textbox.