Bug 144208 - Slow File OPEN of 477 pages ODT with 282 comments and track changes
Summary: Slow File OPEN of 477 pages ODT with 282 comments and track changes
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium major
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0 target:25.2.0 target:24...
Keywords: perf
: 144533 (view as bug list)
Depends on:
Blocks: Track-Changes Comments Performance
  Show dependency treegraph
 
Reported: 2021-08-31 09:21 UTC by Telesto
Modified: 2024-06-25 07:55 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-08-31 09:21:49 UTC
Description:
File OPEN ODT: 120 seconds with 7.3| 100 se with 7.0|  70 sec with 6.0

Steps to Reproduce:
1. Open attachment 167028 [details] (bug 137491)
2. Measure time until visible on screen

Actual Results:
120 seconds with 7.3| 
100 sec with 7.0|  
70 sec with 6.0
45 seconds with 4.2

Expected Results:
As fast as possible


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 05ff3d67d0e2e436406786c949eb7cfca107ba33
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

rather good in
4.2
Comment 1 Timur 2021-09-09 09:51:16 UTC
Hi, Telesto, not sure if you are aware:
in Linux, you may start LO with 'time OOO_EXIT_POST_STARTUP=1 instdir/program/soffice' and it will measure and exit, you don't have to measure manually start time. 
in Windows, I guess it can be done with power-shell or ptime or timemem utility.
So, while what you found is useful, you had better find exact branches of slowdown. I hope a good example is bug 144395.
Comment 2 Timur 2021-09-09 12:14:59 UTC
OO 3.3 Linux
real	1m26,533s   user	1m70,703s   sys	0m1,059s
4.3all oldest
real	2m37,436s   user	2m35,723s   sys	0m0,362s
4.1max master
real	2m56,234s   user	2m47,434s   sys	0m0,878s
4.2max master
real	3m23,532s   user	3m19,044s   sys	0m0,634s
4.3max master
real	4m08,712s   user	4m04,007s   sys	0m0,619s
5.2 gtk3
real	3m25,973s   user	3m20,107s   sys	0m0,594s
6.0 gtk3
real	4m20,577s   user	4m15,235s   sys	0m1,050s
7.0 gtk3
real	4m25,326s   user	4m14,292s   sys	0m1,292s
7.3 gtk3
real	3m54,018s   user	3m51,589s   sys	0m1,241s

While LO 4.x was faster, difference is not that big with those Lin numbers.
Real difference is compared to OO. Should be checked for content, though.

But if track changes are accepted than 7.3+ is:
real	0m8,283s
user	0m7,024s
sys	0m0,544s

So this is a duplicate of some track changes perf bug.
Comment 3 Timur 2021-10-01 11:08:06 UTC
*** Bug 144533 has been marked as a duplicate of this bug. ***
Comment 4 Timur 2021-10-01 11:15:12 UTC
Here are times from different machine with GEN.
I don't see it faster in 5.2 (I think that's wrong in duplicate bug which is the same file by the same reporter), only in OO time, so preBibisect.

OO 3.3	      	074,71s user 1,03s system 87% cpu 1:26,25 total
43all oldest 	161,90s user 0,73s system 94% cpu 2:51,95 total
41max master	162,83s user 0,83s system 95% cpu 2:50,58 total
50max		182,22s user 0,66s system 93% cpu 3:15,11 total
5.2		174,28s user 0,82s system 92% cpu 3:09,48 total
5.4		200,23s user 1,07s system 92% cpu 3:38,08 total
7.3+		168,09s user 0,89s system 98% cpu 2:51,27 total	 

OO opened 477 pages and 7.3+ opens 509 pages and only later changes to 477.
That shouldn't be reported without finding version where it started and searching first, I remember seeing it.

I didn't confirm because I guess it's already reported, should be found, and raised priority. LO sucks here.
Comment 5 Buovjaga 2022-12-20 11:48:30 UTC
Similar results here. Let's set to new anyway.

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9cd0f4c2d25462feba0ffcbd906c199273821243
CPU threads: 8; OS: Linux 6.0; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Comment 6 Roman Kuznetsov 2024-05-24 09:01:04 UTC
https://gerrit.libreoffice.org/c/core/+/167892
Comment 7 Commit Notification 2024-06-01 08:24:25 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a06946271e7139352501e0840256402ac43f4c65

tdf#144208 speedup doc with lots of redline

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2024-06-01 10:56:16 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1291edd7ed369ee97177cab2910f2396302ebacf

tdf#144208 speedup doc with lots of redline(2)

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Buovjaga 2024-06-01 18:00:18 UTC
I built with the three patches on Linux. Time with OOO_EXIT_POST_STARTUP=1

real    0m26,429s
user    0m26,304s
sys     0m0,392s

With 24.2 the time is

real    2m59,777s
user    2m58,274s
sys     0m0,910s

Time to document/UI responsiveness is greater in reality. Close to 2 minutes even with the patches.
Comment 10 Commit Notification 2024-06-02 15:42:56 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bcc30f482b0833460e38a48c07295a8e86b23478

tdf#144208 speedup doc with lots of redline(3)

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2024-06-10 16:40:16 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5fe53e6b2e951f2f8f834386827bf96610d6acb6

tdf#144208 speedup doc with lots of redline(4)

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2024-06-12 13:17:35 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/13874ba730ed94a38271e3b053e11a28f7d8268f

tdf#144208 speedup doc with lots of redline (5)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2024-06-12 19:13:23 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5723e2054bb90f07fff7368e3f38fbe0311f6b83

tdf#144208 speedup doc with lots of redline (6)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Commit Notification 2024-06-13 08:30:19 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/27e9fd67260b8ad321cf0f8722e2db8a08473927

tdf#144208 speedup doc with lots of redline (7)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2024-06-13 17:54:03 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ad51d8b6f691524f3c6d270419264e3d2e1201b6

tdf#144208 speedup doc with lots of redline (8)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Commit Notification 2024-06-14 07:56:58 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dbcc7f7c609ff9254ff3f44f0cb6cc4ae20e72e7

tdf#144208 speedup doc with lots of redline (9)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Commit Notification 2024-06-14 08:58:19 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0e33dff4252f3124c7ecc591befa56f0fb0e1895

tdf#144208 speedup doc with lots of redline (10)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Commit Notification 2024-06-14 11:52:48 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/4d83967f16a56a964dfd9218685d5f082fa0280c

tdf#144208 speedup doc with lots of redline (10)

It will be available in 24.8.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Commit Notification 2024-06-14 20:08:35 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/365e356b66ed98426ba06347ef29e58a02885579

tdf#144208 speedup doc with lots of redline (11)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 20 Commit Notification 2024-06-15 13:24:56 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/04c1a93f8b718f6cd824696f9ffac10acfd32731

tdf#144208 speedup doc with lots of redline (12)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 Commit Notification 2024-06-19 09:46:03 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/e83f7dd8bcb40105d933f72b80eb337f716b94e8

tdf#144208 speedup doc with lots of redline (10)

It will be available in 24.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 22 Commit Notification 2024-06-19 17:45:26 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d8ddd3f1c9faa3338703217967bae5c363df0e45

Revert "tdf#144208 speedup doc with lots of redline(4)"

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 23 Commit Notification 2024-06-20 14:20:53 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2ab4c442a57686eae47a9d9f06d3662544aa591b

tdf#144208 speedup doc with lots of redline(4) II

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 24 Commit Notification 2024-06-20 14:20:56 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1be12e6d298a1e22871cdb9eecb7b6440b0d1d88

tdf#144208 speedup doc with lots of redline(13)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 25 m_a_riosv 2024-06-21 02:26:17 UTC
About 12 seconds to open with
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 151d997365f7bf271d63af535d29a9c3439c6d46
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 26 Telesto 2024-06-21 18:13:59 UTC
There is substantial an improvement file-open performance :-).

But, I want to note, the fixes here create a hug discrepancy between opening performance and the overall experience working with the document itself
 
A) scroll document with mouse scroll wheel or by Pressing Page Down in single page view causes. A very choppy scroll experience (waiting 5 second before a page appears on my old machine). Independent if the changes being visible or hidden

B) Opening Manage changes dialog is slow. Reject entry inside the manage changes dialog being slow as well (bug 161736) 

I somewhat optimistically expected/hoped those would be gone (indirectly) by all the optimizations done for file-open. Appears not to be the case.
Comment 27 Buovjaga 2024-06-21 18:21:14 UTC
(In reply to Telesto from comment #26)
> There is substantial an improvement file-open performance :-).
> 
> But, I want to note, the fixes here create a hug discrepancy between opening
> performance and the overall experience working with the document itself
>  
> A) scroll document with mouse scroll wheel or by Pressing Page Down in
> single page view causes. A very choppy scroll experience (waiting 5 second
> before a page appears on my old machine). Independent if the changes being
> visible or hidden
> 
> B) Opening Manage changes dialog is slow. Reject entry inside the manage
> changes dialog being slow as well (bug 161736) 
> 
> I somewhat optimistically expected/hoped those would be gone (indirectly) by
> all the optimizations done for file-open. Appears not to be the case.

For slowness in editing we do have bug 60418, bug 61558 and bug 119175.
Comment 28 Commit Notification 2024-06-24 07:20:12 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ba28df4fb2c1bc151eebb2d1d2c385be0b71c49d

tdf#144208 speedup doc with lots of redline(14)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 29 Commit Notification 2024-06-24 07:20:14 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/168eb2e64b7ad08645f62b45e15af2ee7260100c

tdf#144208 speedup doc with lots of redline(15)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 30 Commit Notification 2024-06-24 16:32:35 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/857eee7c2cf8baaab556db6ce888db0db1c8a858

tdf#144208 speedup doc with lots of redline(16)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 31 Commit Notification 2024-06-25 07:55:35 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/3514eb75459f4eb3131ae072a04fd3c3d971dfab

Revert "tdf#144208 speedup doc with lots of redline(4)"

It will be available in 24.8.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.