Created attachment 178423 [details] Navigation Pane comments arrows Actual behaviour: With the resolved comments view option unchecked and the resolved comments invisible, using the navigation pane's arrows (see screenshot attached), browses through resolved (invisible) comments as well (in this case nothing is shown but the user is taken to the place where the resolved comment is). Expected behaviour With the resolved comments view option unchecked, the the navigation pane's arrows should browse only through unresolved comments. Reproduce Reproduce steps in "Actual behaviour"
Created attachment 178430 [details] Example file 1. Open example file 2. Uncheck View -> Resolved comments 3. Sidebar -> Navigator -> Notice 2 entry's (expected only the visible comments)
Repro Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 2bb10a827ac13d0caf009e8526ccd9f17dc71653 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL Jumbo
Hi Anduril, Bug 146191 proposes to change the Navigate by Comment behavior to move the cursor to the comment anchor in the document versus moving it into the comment edit window. This would prevent the cursor from being lost when comment navigation is to resolved comments that are not shown. Not exactly what you have requested as expected behavior but probably better than the cursor disappearing. The the move handler for comment navigation is here: sw/source/uibase/uiview/viewmdi.cxx IMPL_LINK( SwView, MoveNavigationHdl, void*, p, void ) case NID_POSTIT:
(In reply to Telesto from comment #1) > Created attachment 178430 [details] > Example file > > 1. Open example file > 2. Uncheck View -> Resolved comments > 3. Sidebar -> Navigator -> Notice 2 entry's (expected only the visible > comments) @Telesto, separate ticket please so https://gerrit.libreoffice.org/c/core/+/130471 can be assigned to it.
Hi Jim, thank you for coming back to me on this. I have doubts on moving the cursor to the comment anchor rather than to the comment edit window, because when working, it is more useful to have the cursor in the edit window of the comment, which is where your attention (and action) is needed, rather than the spot in the text where the comment is anchored to (this is where you focus next, once you have read the comment). The problem with the present behaviour is not really the disappearance of the cursor, since after a while you guess that it is going through all the comments (visible or invisible), but the fact that you are not able to focus on the non resolved. Ex. Imagine a text where 90% of the comments have been resolved. If the collaborator only wants to see the non solved ones, he can either scroll the document visually, or use the navigation. In this latter case, he would like a similar experience to the one of scrolling, i.e. being brought from non solved to non solved comment.
Here is a patch that skips hidden comments when using the Navigate By control for Comments. It also fixes a recent issue that navigated comments are not scrolled into view: https://gerrit.libreoffice.org/c/core/+/130518
Great patch Jim! This is what I was looking for! I imagine that this will be merged in some future version of Libreoffice and no further action from me is needed.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5df0289f6af5aa7142017b56a8e17c134d54fe41 tdf#147565 Make navigate by comments skip hidden comments It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Anduril from comment #7) > Great patch Jim! This is what I was looking for! I imagine that this will be > merged in some future version of Libreoffice and no further action from me > is needed. You can test the patch by following instructions given here: https://wiki.documentfoundation.org/Testing_Daily_Builds
Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/fc0f1eb3f99369988cdf68344bba8a66d5d394cd tdf#147565 Make navigate by comments skip hidden comments It will be available in 7.3.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thanks for your post, it's very helpful I hope in the future you will provide more information. I will visit and support the article for you https://drift-hunters.com
It's so great. Young people will love it https://tunnelrush2.com
These tips seem simple but extremely useful, can not be without it. More information can be found at https://deathrun3d.com
Reading your article was incredibly beneficial and educational. If you have some spare time, join me in playing https://snakeio.co
Drift Hunters is a one-of-a-kind game in which you can design your own car. https://drift-hunters.io
How did you conquer the slope ball tracks? Do you press the joystick when reaching the obstacles or let the character fall on his own? Use the item only when there is an arrow icon on the item. Avoid items marked with an X. And how's your score? https://slopeball.io
Hi, can anyone suggest how to prevent the spam messages that keep comint to this bug issue? Thanks!