Created attachment 178740 [details] Comment context menu change proposal Also, similar to Menu->View->Resolved Comments, include a check menu item "Show Resolved Comments in Document". The "in Document" part is meant to convey this will toggle visibility in the document but the comments will always be visible in the Navigator. WIP for enhancement Bug 147746 means to grey out comments that aren't visible in the document.
It seems it fits current functionality. However, the wording *seems* to imply that there might be "show/hide all comments by Foo", or "Hide this", and if those implemented, the "show all" is not the same as a checkbox to enable comments display. But anyway, until it's implemented, my concern is moot.
Mike, I think I understand what you are saying. We are able to "Delete All Comments by Author" but not yet implemented is "Show/Hide All Comments by Author". The reason for this proposed change is that "Show All" and "Hide All" Comments context menu items in the Navigator don't toggle the UNO command state for Menu->View->Comments or the Comments visibility button next to the ruler.
Without support from (many) users I doubt this function is needed. (struggle even with the "Delete all by"). And FN_HIDE_NOTE_AUTHOR/FN_DELETE_NOTE_AUTHOR were included before the big bang. My take: simplicity first and "[x] Show Comments" (no reason for "in document"). And I would remove the "by author" flavors.
The topic was on the agenda of the design meeting but didn't receive further input. needsDevAdvice for comment 3 (remove hide/deletebyauthor functions)
Reading the ticket again it seems reasonable to combine the two commands. We use .uno:ShowAnnotations in the View menu for this purpose. The ContextLabel (View >) "Comments" might be inappropriate for the Navigator popup; not sure if this menu shows the pure "Show Comme~nts" or some PopupLabel needs to be added. Code pointer: sw/uiconfig/swriter/ui/navigatorcontextmenu.ui and probably some magic in sw/source/uibase/utlui/content.cxx and sd/source/ui/dlg/navigatr.cxx
I would like to work on this.
Sujatro Bhadra committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/194adf065e572699e0d77d359e6625c1713c31c1 tdf#147864 Replace 'Show All' and 'Hide All' in the Comments category It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thanks for solving this bug. Working well in Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: cdcfd8b1df94a9e58557bfb195accd7cb43d2e3c CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Sujatro Bhadra, you can mark this bug as Resolved, if you know nothing is to be done more.
Verified, based on comment 8.