Bug 147864 - Navigator: Proposal to combine Comment category context menu items 'Show All' and 'Hide All' to check menu item 'Show Comments in Document'
Summary: Navigator: Proposal to combine Comment category context menu items 'Show All'...
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Sujatro Bhadra
URL:
Whiteboard: reviewed:2024
Keywords: difficultyMedium, easyHack, skillCpp
Depends on:
Blocks: Navigator Writer-Comments
  Show dependency tree / graph
 
Reported: 2022-03-09 08:48 UTC by Jim Raykowski
Modified: 2024-04-09 23:25 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Comment context menu change proposal (25.52 KB, image/png)
2022-03-09 08:48 UTC, Jim Raykowski 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2022-03-09 08:48:46 UTC 
Created attachment 178740 [details]
Comment context menu change proposal

Also, similar to Menu->View->Resolved Comments, include a check menu item "Show Resolved Comments in Document". The "in Document" part is meant to convey this will toggle visibility in the document but the comments will always be visible in the Navigator. WIP for enhancement Bug 147746 means to grey out comments that aren't visible in the document.
Comment 1 Mike Kaganski 2022-03-09 09:45:37 UTC 
It seems it fits current functionality. However, the wording *seems* to imply that there might be "show/hide all comments by Foo", or "Hide this", and if those implemented, the "show all" is not the same as a checkbox to enable comments display.

But anyway, until it's implemented, my concern is moot.
Comment 2 Jim Raykowski 2022-03-10 02:38:15 UTC 
Mike, I think I understand what you are saying. We are able to "Delete All Comments by Author" but not yet implemented is "Show/Hide All Comments by Author".

The reason for this proposed change is that "Show All" and "Hide All" Comments context menu items in the Navigator don't toggle the UNO command state for Menu->View->Comments or the Comments visibility button next to the ruler.
Comment 3 Heiko Tietze 2022-12-19 14:01:25 UTC 
Without support from (many) users I doubt this function is needed. (struggle even with the "Delete all by"). And FN_HIDE_NOTE_AUTHOR/FN_DELETE_NOTE_AUTHOR were included before the big bang.

My take: simplicity first and "[x] Show Comments" (no reason for "in document"). And I would remove the "by author" flavors.
Comment 4 Heiko Tietze 2022-12-22 09:43:10 UTC 
The topic was on the agenda of the design meeting but didn't receive further input.
needsDevAdvice for comment 3 (remove hide/deletebyauthor functions)
Comment 5 Heiko Tietze 2024-01-06 11:13:42 UTC 
Reading the ticket again it seems reasonable to combine the two commands. We use .uno:ShowAnnotations in the View menu for this purpose. The ContextLabel (View >) "Comments" might be inappropriate for the Navigator popup; not sure if this menu shows the pure "Show Comme~nts" or some PopupLabel needs to be added.

Code pointer: sw/uiconfig/swriter/ui/navigatorcontextmenu.ui and probably some magic in sw/source/uibase/utlui/content.cxx and sd/source/ui/dlg/navigatr.cxx
Comment 6 Sujatro Bhadra 2024-04-09 18:25:40 UTC 
I would like to work on this.