Bug 148465 - Rework Sparklines's context menus
Summary: Rework Sparklines's context menus
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Context-Menu Sparklines
  Show dependency treegraph
 
Reported: 2022-04-08 11:38 UTC by Roman Kuznetsov
Modified: 2022-09-09 10:24 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2022-04-08 11:38:48 UTC
Description:
Rework Sparklines's context menus

So, after a great Tomaž's work we have Sparklines support in Calc. Let's look at sparklines's context menus:

Case 1: When selected a cell with sparkline we have Sparkline item in context menu with some submenu:

Sparklines->
    Insert sparkline
    Delete sparkline
    Delete sparkline group
    Edit sparkline group
    Group sparklines
    Ungroup sparklines

Why we need "Insert sparkline" here if we already have the sparkline in the cell?
Why we need "Delete sparkline group" here if we selected only one cell?
Why we need "Group sparklines" here if we selected only one cell?
Why edit item has name "Edit sparkline group" if we selected only one cell?

I suggest rework it to:

Sparklines->
    Edit sparkline
    Delete sparkline
    Ungroup sparklines - this one should be active only if we have already grouped sparklines

Case 2: When selected empty cell without any sparkline we have Sparkline item in context menu with some submenu too:

Sparklines->
    Insert sparkline
    Group sparklines
    Ungroup sparklines

We have no any sparklines in selected cell and we don't need Group/Ungroup items here.

I suggest in an empty cell case just have one "Insert sparkline" item in main cell context menu. Or even delete sparklines from context menu at all in this case (not sure in it)




Steps to Reproduce:
-

Actual Results:
We have some strange sparklines's context menu items now

Expected Results:
We have more clear and user friendly sparklines's context menu items


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: efe854bf9b6daff3d0ecf6e3d04bd9a50bfaa3f3
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded
Comment 1 Heiko Tietze 2022-04-11 11:24:17 UTC
(In reply to Roman Kuznetsov from comment #0)
> Sparklines->
>     Edit sparkline
>     Delete sparkline
>     Ungroup sparklines - this one should be active only if we have already
> grouped sparklines

Ideally the menu is hidden when the cell does not contain sparklines.
 
> Case 2: When selected empty cell without any sparkline we have Sparkline
> item in context menu with some submenu too:
> 
> Sparklines->
>     Insert sparkline
>     Group sparklines
>     Ungroup sparklines

Wouldn't expect a context related function that either requires input from other cells (input range) or a different target (output range). OTOH, a pivot table or other functions that leads to a more complex interaction and have an entry in the context menus as well.

Btw, why is it named (and works as) Output _Range_?
Comment 2 andreas_k 2022-04-13 06:52:47 UTC
when the sparkline commands are context related commands, can it have a context related notebookbar tab (like MSO)?
Comment 3 Heiko Tietze 2022-04-22 08:45:21 UTC
The topic was on the agenda for the design meeting.

To summarize, do not list sparkline commands at all for cells w/o sparklines (my take) or at least have only "Insert Sparkline" at the root level. With SL context it's not needed to have Insert but users expect Edit. Ideally we show/enable Ungroup only if we have a group and vice versa.