Bug 148539 - Notebookbar, Insert tab: lacks InsertSparkLine button
Summary: Notebookbar, Insert tab: lacks InsertSparkLine button
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
(earliest affected) alpha0+
Hardware: All All
: medium enhancement
Assignee: Justin L
Whiteboard: target:24.2.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on: 157779
Blocks: Notebookbar-ContextualGroups Notebookbar-Groupedbar Notebookbar-Tabbed Sparklines
  Show dependency treegraph
Reported: 2022-04-12 15:03 UTC by pedro.silva
Modified: 2023-10-17 11:23 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description pedro.silva 2022-04-12 15:03:05 UTC
I think the new Sparklines feature (https://tomazvajngerl.blogspot.com/2022/03/sparklines-in-calc.html TLDR check Edwards Tufte to see this or check this old article for some context https://www.linux-magazine.com/Issues/2016/183/Calc-Conditional-Formatting)
- needs an icon
- changes on the UI file for the Tabbed view in order to have the InsertSparkLine exposed within the Insert tab

Note: We might want to expose the other uno commands also in other tabs and throughout the other user interface variants but probably better to create additional bug reports for that, I think.

Gerrit feature related patches: https://gerrit.libreoffice.org/q/owner:quikee%2540gmail.com+sparklines+branch:master

Steps to Reproduce:
1. Open Calc master
2. Switch to Tabbed view
3. Switch to Insert tab

Actual Results:
No icon to insert Sparkline

Expected Results:
Icon to insert sparkline (as it already happens with for example insert chart)

Reproducible: Always

User Profile Reset: No

Additional Info:
commit f0801aba21f20c6305ae2b9083443d74bad01d3e (HEAD -> master, origin/master, origin/HEAD)
Comment 1 Heiko Tietze 2022-04-12 15:28:20 UTC
(In reply to pedro.silva from comment #0)
> - needs an icon
Rizal, Andreas: Got an idea?

> - changes on the UI file for the Tabbed view in order to have the
> InsertSparkLine exposed within the Insert tab

My take: Insert and Edit but not Group/Ungroup (I might be wrong here with the importance) and Delete (could be done with Del key). Edit needs to be enabled only in case the cell contains a SL.

This is easy hackable. Code pointers on request.
Comment 2 Pedro 2022-04-13 08:05:32 UTC
This should be included, definitely.
Comment 3 Justin L 2023-10-14 13:16:25 UTC

Ideally this would be a single menu that could be used everywhere. However, Format - Sparklines includes a reduced set, though I suppose it wouldn't hurt to expand it here.

Additionally, "Insert Sparkline" is used separately, where it is (properly) ContextLabel'd "Sparklines...", so in the submenus it is also labelled this way instead of "Insert Sparkline". But since it opens a dialog, that also seems to be OK. [No change here, just noting it is a little strange...]
Comment 4 Commit Notification 2023-10-16 13:20:05 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":


tdf#148539 sc notebookbar: add Sparklines to MenuData

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:

Affected users are encouraged to test the fix and report feedback.