Bug 148539 - Notebookbar, Insert tab: lacks InsertSparkLine button
Summary: Notebookbar, Insert tab: lacks InsertSparkLine button
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Notebookbar-ContextualGroups Notebookbar-Groupedbar Notebookbar-Tabbed Sparklines
  Show dependency tree / graph
 
Reported: 2022-04-12 15:03 UTC by pedro.silva
Modified: 2022-09-09 10:24 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:
Regression By:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description pedro.silva 2022-04-12 15:03:05 UTC 
Description:
I think the new Sparklines feature (https://tomazvajngerl.blogspot.com/2022/03/sparklines-in-calc.html TLDR check Edwards Tufte to see this or check this old article for some context https://www.linux-magazine.com/Issues/2016/183/Calc-Conditional-Formatting)
- needs an icon
- changes on the UI file for the Tabbed view in order to have the InsertSparkLine exposed within the Insert tab

Note: We might want to expose the other uno commands also in other tabs and throughout the other user interface variants but probably better to create additional bug reports for that, I think.


Gerrit feature related patches: https://gerrit.libreoffice.org/q/owner:quikee%2540gmail.com+sparklines+branch:master

Steps to Reproduce:
1. Open Calc master
2. Switch to Tabbed view
3. Switch to Insert tab

Actual Results:
No icon to insert Sparkline

Expected Results:
Icon to insert sparkline (as it already happens with for example insert chart)


Reproducible: Always


User Profile Reset: No



Additional Info:
commit f0801aba21f20c6305ae2b9083443d74bad01d3e (HEAD -> master, origin/master, origin/HEAD)
Comment 1 Heiko Tietze 2022-04-12 15:28:20 UTC 
(In reply to pedro.silva from comment #0)
> - needs an icon
Rizal, Andreas: Got an idea?

> - changes on the UI file for the Tabbed view in order to have the
> InsertSparkLine exposed within the Insert tab

My take: Insert and Edit but not Group/Ungroup (I might be wrong here with the importance) and Delete (could be done with Del key). Edit needs to be enabled only in case the cell contains a SL.

This is easy hackable. Code pointers on request.
Comment 2 Pedro 2022-04-13 08:05:32 UTC 
This should be included, definitely.