Bug 148699 - kf5: No tooltips for shapes in Impress's "Basic Shapes" toolbar item (and others)
Summary: kf5: No tooltips for shapes in Impress's "Basic Shapes" toolbar item (and oth...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0 target:7.3.3
Keywords:
Depends on:
Blocks: KDE, KF5
  Show dependency treegraph
 
Reported: 2022-04-21 07:10 UTC by Michael Weghorn
Modified: 2022-04-27 13:45 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (49.67 KB, image/png)
2022-04-21 07:10 UTC, Michael Weghorn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Weghorn 2022-04-21 07:10:50 UTC
Created attachment 179696 [details]
Screenshot

Steps to reproduce:

1) start LO Impress with the kf5 VCL plugin
2) click on the arrow right of the "Basic Shapes" toolbar item
3) hover with mouse over one of the shapes (s. screenshot)

Actual result: No tooltip.

Expected result: Tooltip that explains what shape this is.

Work fine with e.g. gtk3 VCL plugin instead.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: d81c26a1b9220c176f2d7162ac3b01983d6c8e4f
CPU threads: 12; OS: Linux 5.16; UI render: default; VCL: kf5 (cairo+wayland)
Locale: en-US (en_GB.UTF-8); UI: en-US
Calc: threaded

(same with QT_QPA_PLATFORM=xcb)
Comment 1 Michael Weghorn 2022-04-21 07:13:28 UTC
Regression from:

commit af6dd54d53eee0d0de1164bff0a77c6b433b3935
Author: Jan-Marek Glogowski
Date:   Tue Apr 12 00:29:56 2022 +0200

    tdf#148115 Qt handle tooltips via event loop
    
    Instead of calling QToolTip::showText directly from LO, this
    defers showing the tooltip to the QEvent processing, which takes
    the tooltip timeouts into account. So tooltips are shown with
    a slight delay, therefore they happen less fast on mouse move,
    reducing / avoiding artifacts of fast changing windows.
    
    This unfortunately comes with yet an other hack in the area of
    our fake popup windows...
    
    New handling is based on the code of the Qt Tool Tips example.

Adding CC: to Jan-Marek Glogowski

It looks like the hack for fake popups included there isn't enough.
Comment 2 Commit Notification 2022-04-21 12:03:27 UTC
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/347622a98f512dae709f938a85498dcdcf9f225a

tdf#148699 Qt track the active / shown popup

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Michael Weghorn 2022-04-21 12:22:39 UTC
Thanks!

Works fine with the fix in place.
Comment 4 Commit Notification 2022-04-21 16:57:28 UTC
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/06c51d61e4a16057f945effe85b1ff9457f8cffb

tdf#148699 Qt track the active / shown popup

It will be available in 7.3.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-04-27 10:50:56 UTC
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-3-3":

https://git.libreoffice.org/core/commit/6603bd259d6e8abbb6af68fae0eba3f4d876b4f8

tdf#148699 Qt track the active / shown popup

It will be available in 7.3.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.