Bug 148756 - Document Type in Options dialog should correspond to the application that opened the dialog
Summary: Document Type in Options dialog should correspond to the application that ope...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.3.2.2 release
Hardware: x86-64 (AMD64) Windows (All)
: medium enhancement
Assignee: Baole Fang
URL:
Whiteboard: target:7.6.0
Keywords: difficultyMedium, easyHack, skillCpp, topicUI
: 88589 (view as bug list)
Depends on:
Blocks: Options-Dialog-Load-Save
  Show dependency treegraph
 
Reported: 2022-04-24 16:47 UTC by Pete
Modified: 2024-09-01 18:35 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pete 2022-04-24 16:47:51 UTC
I'm a new user to LibreOffice and I watched a YouTube video on how to get started (using version 7.3.2).

The video showed how to set default font to something that would be compatible with "other" office packages and also how to set the "document type" when Saving/Loading", this was done for the "Write" application when it was open.

So, I get into "CALC Spreadsheet" app and I try to do the same for it, to save/load in "xlsx" format, and I could not figure it out for hours (yes, I know, Im DUMB!)

Each time I opened +Save/Load, the "Document Type" was always "Text" and I just did not realize that "Document Type" with its "Text" value was just a default and there is a drop down menu to select "Spreadsheet"!!!

So, my request to improve LibreOffice is"
have the "Document Type" reflect the application that is open and being currently used, so I have Calc open and I go to the +Save/Load->General, it should by default show that its "Document Type" is Spreadsheet.

If I have the Impress Presentation app open and use the Tools->Options->+Save/Load->General, its Document Type should be "Presentation" by default! The same for the other applications, Writer=Text, Calc=Spreadsheet, Presentation=Presentation, etc....

This would go a long way to make the product more intuitive.

Of course, if you go to the Tools->Options->+Save/Load page directly from the main screen (without being in any of the applications, than the default can remain "Text" and if you're a knowledgeable user, you know to use the drop down menu to set its type and the how you want that document to be saved.

Thanks,
Pete
Comment 1 sdc.blanco 2022-04-24 23:47:07 UTC
Summarizing: 

Tools > Options > Load/Save > General > Default File Formats and ODF Settings

with command sequence initiated from Calc.

Actual:  Document Type shows "Text document"
Expected:   "       "  shows "Spreadsheet"     

Enhancement request:

"Document type" (and "Always save as") should correspond to the application used to open this dialog.  (Did I get it right Pete?)

Asking Design Team....
Comment 2 Heiko Tietze 2022-04-25 08:35:28 UTC
Yes, Pete is right. The connected dropdown lists are not intuitive and to initialize it per module is an improvement.

Some types are yet not associated with a specific module, namely HTML and Master document. Not a big deal. What bothers me more is what we show when started without module context meaning from the start center. Just the first entry as today, I'd say. 

And I also struggle with "Text document" thinking of ASCII rather than formatted text. My proposal is to rename the module specific entries with their module name: "Text Documents (Writer)", "Spreadsheets (Calc)"... similar to bug 118330 and bug 118435.

It would also be an improvement if the arrangement of the two controls indicate the relationship. Might be a bit too large if we place the two next to each other, though.
Comment 3 Jim Raykowski 2022-04-28 19:12:51 UTC
code pointers:

  cui/uiconfig/ui/optsave.ui
  cui/source/options/optsave.hxx
  cui/source/options/optsave.cxx
  
  void SvxSaveTabPage::Reset
  m_xDocTypeLB set_active_id
  
  hints on how to identify the module:
  cui/source/customize/acccfg.cxx SfxAcceleratorConfigPage::InitAccCfg
  git grep -n 'xModuleManager->identify'
Comment 4 Baole Fang 2023-05-06 23:59:08 UTC
Start working on this
Comment 5 Baole Fang 2023-05-08 02:42:28 UTC
(In reply to Heiko Tietze from comment #2)

> And I also struggle with "Text document" thinking of ASCII rather than
> formatted text. My proposal is to rename the module specific entries with
> their module name: "Text Documents (Writer)", "Spreadsheets (Calc)"...
> similar to bug 118330 and bug 118435.

To change modeule name, I current change:
Text Document -> Text Documents (Writer)
HTML document -> HTML documents (Writer Web)
Master document -> Master documents (Writer)
Spreadsheet -> Spreadsheets (Calc)
Presentation -> Presentation (Impress)
Drawing -> Drawings (Draw)
Formula -> Formulas (Math)

Do you see anything counter-intuitive? For example
- Should we use plural form?
- Should we use all capital letters like you suggest in bug 118330?
- What do we add from Master documents? Is Writer good enough?
Comment 6 Baole Fang 2023-05-08 02:56:47 UTC
In this patch[1], I use:
Text Document -> Text Documents (Writer)
HTML document -> HTML documents (Writer Web)
Master document -> Master documents (Writer Master)
Spreadsheet -> Spreadsheets (Calc)
Presentation -> Presentation (Impress)
Drawing -> Drawings (Draw)
Formula -> Formulas (Math)

I'm open to any comments.

[1] https://gerrit.libreoffice.org/c/core/+/151455
Comment 7 Mike Kaganski 2023-05-08 06:00:48 UTC
Oh! I am sure that we had a better idea of replacing this awful drop-down UI with something better, like tabbed or something.
Comment 8 Mike Kaganski 2023-05-08 06:16:41 UTC
*** Bug 88589 has been marked as a duplicate of this bug. ***
Comment 9 Heiko Tietze 2023-05-08 08:10:48 UTC
(In reply to Baole Fang from comment #5)
> - Should we use plural form?
Yes, please (applies to Presentations). 
> - Should we use all capital letters like you suggest in bug 118330?
Yes, please (see also https://wiki.documentfoundation.org/Design/Guidelines/UIWriting)
> - What do we add from Master documents? Is Writer good enough?
Yes, Master Documents are handled in Writer.

(In reply to Mike Kaganski from comment #7)
> Oh! I am sure that we had a better idea of replacing this awful drop-down UI
> with something better, like tabbed or something.
Minor issue, simple solution. Not many users will care about this option.
Comment 10 Mike Kaganski 2023-05-08 08:36:16 UTC
(In reply to Heiko Tietze from comment #9)
> (In reply to Mike Kaganski from comment #7)
> > Oh! I am sure that we had a better idea of replacing this awful drop-down UI
> > with something better, like tabbed or something.
> Minor issue, simple solution. Not many users will care about this option.

I like the bold statements - even more when they are unfounded.

https://ask.libreoffice.org/t/save-as-xlsx-pptx-files-by-default-with-calc-impress/40953
https://ask.libreoffice.org/t/always-save-documents-as-doc/41643
https://ask.libreoffice.org/t/default-save-for-calc-files/34051
https://ask.libreoffice.org/t/windows-mandatory-profile-always-save-as-formats/37451
https://ask.libreoffice.org/t/save-as-ms-office-format-by-default/1445
https://ask.libreoffice.org/t/save-for-the-extension-docx-or-xlsx-by-default/8135
https://ask.libreoffice.org/t/how-do-i-set-libreoffice-to-default-save-as-xml-when-installing-the-app-instead-of-after-i-install-it/26881
https://ask.libreoffice.org/t/default-save-on-mso-format/2072
https://ask.libreoffice.org/t/how-to-set-microsoft-files-as-default-extension-in-libreoffice-7-04/70601
https://ask.libreoffice.org/t/msi-property-for-save-as-type/495
https://ask.libreoffice.org/t/how-can-i-choose-a-default-export-filetype-for-libreoffice-draw/23626
https://ask.libreoffice.org/t/writer-how-do-i-make-doc-the-default-save-format/10593

... just some of the questions on Ask, regarding the "Always save as". Pleaple use it, and get confused.
But shrug.
Comment 11 Heiko Tietze 2023-05-08 08:58:27 UTC
(In reply to Mike Kaganski from comment #10)> ... just some of the questions on Ask, regarding the "Always save as".
> People use it, and get confused.
Okay, good argument.
Comment 12 Commit Notification 2023-05-27 07:00:59 UTC
Baole Fang committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9e92437cbb2180d51fdabc0d5efff24b530ba27a

tdf#148756: Fix document type in option dialog

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.