Created attachment 180842 [details] screenshot image 128646 str: open file: badge_kor_sablon.docx on bug #104260 observe: missing image similar to file: Screenshot of the original document side by side in Word and Writer. on bug #128646 actual: images appear Version: 7.3.4.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 4; OS: Linux 3.18; UI render: default; VCL: x11 Locale: en-US (C); UI: en-US Debian package version: 1:7.3.4~rc2-1 Calc: threaded
Created attachment 180843 [details] strace log 128646 104260
I can't reproduce it in Version: 7.4.0.0.beta1+ / LibreOffice Community Build ID: cdf48e57da6b8a6a5eb4131340fa2c14be135714 CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: es-ES (es_ES.UTF-8); UI: en-US Calc: threaded Could you please explain where the missing image is? I can't see it in your screenshot
hello Xisco Faulí, the missing image or logo is "MAGYARY PROGRAM" in all boxes and inverted half circles in box (top right corner box). the screenshot on bug #128646 contains logo/image.
(In reply to vis_qa from comment #3) > hello Xisco Faulí, > > the missing image or logo is "MAGYARY PROGRAM" in all boxes and inverted > half circles in box (top right corner box). the screenshot on bug #128646 > contains logo/image. Indeed. Regression introduced by author Oleg Shchelykalnov <olegshtch@yandex.ru> 2021-05-26 22:11:49 +0300 committer Michael Stahl <michael.stahl@allotropia.de> 2021-06-09 11:10:01 +0200 commit b5e07b1339f73841664b28c65639f1638bd7edf4 (patch) tree 05bf42cab6d53bfbbeda1eb54a04dcf85bb0cf1a parent c96b61f86ef3f4cdc34f84043fed2724b6d9732b (diff) tdf#137469 Implement and test excluding hidden text in text filter Bisected with: bibisect-linux64-7.2
This is an interesting issue. In b5e07b1339f73841664b28c65639f1638bd7edf4 the condition else if (!pNd->IsHidden() || bIncludeHidden) was added, However, the issue is not reproduced if the condition is changed to else if (bIncludeHidden || !pNd->IsHidden()) because pNd->IsHidden() is not called. IsHidden() calls HasHiddenCharAttribute( true ), which calls CalcHiddenCharFlagsm which calls SwScriptInfo::GetBoundsOfHiddenRange with the comment "Update of the flags is done inside GetBoundsOfHiddenRange()" @Miklos, @Michael S., is it expected that IsHidden() which returns a bool hides images?
Created attachment 180847 [details] simplifier document
SwTextNode::IsHidden() calls HasHiddenCharAttribute(), which does some some caching behind the scenes, perhaps that goes wrong here?
Dear vis_qa, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Looks good in nightly: Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: cdf2681d996286953dffa8a033de1b947ae23768 CPU threads: 14; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: default But not exactly yet (image is visible, but in top left corner of the document) in bibisect 25.2: Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2afdc61dd3138b383fb73dae2242ba1a9c8de901 CPU threads: 14; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: threaded meaning this got good somewhere in this range: cdf2681 tdf#134204 sw: notify when para style inherited a new property by Justin Luth · 3 days ago a1295cb python: upgrade to 3.10.14 (master only) by Xisco Fauli · 3 days ago 4a3706d pyuno: fix deprecated warnings by Xisco Fauli · 3 days ago e4cbe16 Related tdf#161461: break out of loop once data flavor is set by Peter Hagen · 3 days ago 5e7c94c fill in more SfxItemType values by Noel Grandin · 3 days ago c409c83 package: avoid throwing RuntimeException in getZipFileContents() by Michael Stahl · 3 days ago 958cabd Bundle fonts of Google's DocRepair Project by Andras Timar · 3 days ago 7216a5a CppunitTest_dbaccess_embeddeddb_performancetest: fix dependencies by Xisco Fauli · 3 days ago 4c3f2194b LOK: fixed incorrect Logic point calculation for Map mode by Pranam Lashkari · 3 days ago 355e553 libxslt: upgrade to 1.1.42 by Xisco Fauli · 3 days ago 74b312d Add escape direction support for glue points in the preset shapes by Tibor Nagy · 3 days ago a14531e The connector shape is losing its connection by Tibor Nagy · 3 days ago 2afdc61 package: ZipFile: treat junk at the start of zip as invalid by Michael Stahl · 3 days ago Image got visible in the top left corner first in 24.8 at: https://git.libreoffice.org/core/+/fc1e6a64bd0517a7e67f08860c29b44d030220eb author Mike Kaganski <mike.kaganski@collabora.com> Tue May 28 09:04:51 2024 +0500 committer Mike Kaganski <mike.kaganski@collabora.com> Wed May 29 13:17:30 2024 +0200 tdf#161202: lowers shouldn't move forward because of lack of space
false alert: it looks good in my nightly because I have the Options - Writer - Formatting Aids - Hidden characters enabled. Disabling that moves the image back to the top left corner upon reload. Guess we still have the IsHidden issue mentioned in comment #5