Bug 151377 - ENHANCEMENT: Collapse or hide toggle for individual effect details in animation sidebar
Summary: ENHANCEMENT: Collapse or hide toggle for individual effect details in animati...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyMedium, easyHack, skillDesign, topicDesign
Depends on:
Blocks: Sidebar-Animation
  Show dependency treegraph
 
Reported: 2022-10-06 12:03 UTC by Telesto
Modified: 2023-09-11 08:40 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Add animation menubutton in MS PowerPoint (32.99 KB, image/png)
2023-03-13 13:18 UTC, Eyal Rozenberg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2022-10-06 12:03:13 UTC
Description:
ENHANCEMENT: Hide/show system to hide the effect list with purpose to increase the size of animation list (for sorting and such)

Steps to Reproduce:
1. Open Impress (ignore template manager)
2. Sidebar -> Animation tab

Actual Results:
50% space of the sidebar is used for effect list/ 50% for showing the existing animations.

The animation list can hold 8 entry's before a scrollbar appears. Scrollbar makes arranging animations pretty clumsy. Adding a seperate/ allowing collapse and expand (similar to collapsing expanding/the sidebar as a whole) might give some additional room

Expected Results:
There are cases where multiple animations are used for single object. At some point the list becomes to small..


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 9063d99ff5ee43cc1239fc1dbb5d9897bdda1c9b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 1 Telesto 2022-10-06 12:04:58 UTC
@Eyal
Only a wild idea. Not sure if would be helpful or not..
Comment 2 Eyal Rozenberg 2022-10-07 10:12:17 UTC
I would go with something like the collapsible regions we have in the Properties sidebar. Support this.
Comment 3 Telesto 2022-10-07 14:33:28 UTC
(In reply to Eyal Rozenberg from comment #2)
> I would go with something like the collapsible regions we have in the
> Properties sidebar. 

I agree
Comment 4 Heiko Tietze 2022-10-10 09:14:04 UTC
Added a splitter between the list of used and available animations to resolve bug 145028 and bug 145037. You can show more than 8 items. => WFM
Comment 5 Eyal Rozenberg 2022-10-10 09:36:54 UTC
(In reply to Heiko Tietze from comment #4)
> Added a splitter

MMM. Yeah. Well, this is not my bug, but - I can live with this.
Comment 6 Telesto 2022-10-10 14:17:43 UTC
(In reply to Heiko Tietze from comment #4)
> Added a splitter between the list of used and available animations to
> resolve bug 145028 and bug 145037. You can show more than 8 items. => WFM

The splitter does technically work, but it still feels like the "wrong" (workflow/esthetical) solution for the issue .. So this keeps nagging/hunting me.

* If you drag the insert animation panel down to the bottom, you can't pick it up anymore, if the sidebar being on minimum size (because of a horizontal scrollbar at the bottom). But the horizontal scrollbar shouldn't be present at the first place, I guess (larger minimum size of the sidebar) so maybe unrelated to this
* You don't need the 'Insert Effects' part of the sidebar at all, if you you want to rearrange the inserted effects... You don't want to reduce the size of the insert animation, you actually want to hide that part of the panel temporally. 
* Dragging it down to the bottom, and restoring it by dragging it up again, is bit of unusual. At some points some elements of the panel disappear. I actually would have expected a minimum size. It shouldn't be possible to hide controls out of sight this way. 
* Sliding the panel out of sight, seems to be slightly inconsistent with the approach at the properties deck of the sidebar (collapse/expand).
 * It pretty hidden feature. 

I admit that position the up/down buttons & delete button for sorting effects being a problem when considering collapsible regions.

Obviously also fixable (here we go again with scope extension). Sorting animations should - in my opinion - be have the same workflow/design as the slide sorter bar. Consistent design for same type of actions. And well comfort. The slide sorter bar being the superior design, in my view.

The Slide sorter bar has no visual buttons for arranging or adding slides. 
Arranging or adding or deleting slides is done by Drag & Drop (and/or) Keyboard Control (and/or) Context Menu

And well - lets face it - the 'Add' button is on weird place anyhow, at least in my workflow. When I insert an animation effect, work the dialog from top to bottom. First setting the category, next the effect, Next start, and duration.. (mouse being at the bottom of the sidebar panel). Now I have the do large mouse movement, to move the add button. I would expect somewhere near the bottom to finish it. Apply/OK buttons are also at the bottom of the dialog, not at the left right corner of dialog window (or the title bar).

I always experience it as rather counter-intuitive/ un-logical/ unnatural.

The position of the 'add' button is the outcome of a concession. You get to this if you assume those buttons (delete/move up/down) being a necessity. Those buttons do control the effect list (so below the effect list makes sense). Also Add/delete are the opposite of each other (so combined location seems sensible) And well up/down buttons need a place too.

The fact that I think I know why current design being as it is, doesn't improve practical usage..
Comment 7 QA Administrators 2022-10-11 03:35:50 UTC Comment hidden (obsolete)
Comment 8 Heiko Tietze 2022-10-11 07:26:32 UTC
(In reply to Telesto from comment #6)
> * If you drag the insert animation panel down to the bottom, you can't pick
> it up anymore, if the sidebar being on minimum size (because of a horizontal
> scrollbar at the bottom). But the horizontal scrollbar shouldn't be present
> at the first place, I guess (larger minimum size of the sidebar) so maybe
> unrelated to this

Agreed, should be fixed

> * You don't need the 'Insert Effects' part of the sidebar at all, if you you
> want to rearrange the inserted effects... You don't want to reduce the size
> of the insert animation, you actually want to hide that part of the panel
> temporally. 

But you do normally switch between the two lists when adding animations to objects. Rearranging is not the primary function.

> * Sliding the panel out of sight, seems to be slightly inconsistent with the
> approach at the properties deck of the sidebar (collapse/expand).

We could replace the slider by a collapsing section similar to the print dialog. There are some use cases where you want to maximize the lower list of available animations and there is your rearrangement situation. Which makes it two collapsible panels and I'm concerned about both being closed. Would be awkward. Could be solved per code but is a special solution

> I admit that position the up/down buttons & delete button for sorting
> effects being a problem when considering collapsible regions.

Better placed right hand of the list anyway. 
 
> The Slide sorter bar has no visual buttons for arranging or adding slides. 
> Arranging or adding or deleting slides is done by Drag & Drop (and/or)
> Keyboard Control (and/or) Context Menu

You need some means to pick the animation from a long list, which is not the fact for the slide pane. Dragging items is possible as well.

> And well - lets face it - the 'Add' button is on weird place anyhow...

The described workflow with Apply/Cancel is true for dialogs when you finalize the configuration. But I admit instead of Add it could be Insert placed at the end of this section and with all controls enabled. Workflow would be to set-up the animation and insert then. The Insert button could become, or rather accomplished by, another button to Modify the selected animation. Also not perfect.
Comment 9 Telesto 2022-10-13 19:57:48 UTC
(In reply to Heiko Tietze from comment #8)
> (In reply to Telesto from comment #6)
> > * If you drag the insert animation panel down to the bottom, you can't pick
> > it up anymore, if the sidebar being on minimum size (because of a horizontal
> > scrollbar at the bottom). But the horizontal scrollbar shouldn't be present
> > at the first place, I guess (larger minimum size of the sidebar) so maybe
> > unrelated to this
> 
> Agreed, should be fixed

Check

> 
> > * You don't need the 'Insert Effects' part of the sidebar at all, if you you
> > want to rearrange the inserted effects... You don't want to reduce the size
> > of the insert animation, you actually want to hide that part of the panel
> > temporally. 
> 
> But you do normally switch between the two lists when adding animations to
> objects. Rearranging is not the primary function.

Any new animation add will but at the bottom of the list. I'm personally don't now in advance how my presentation will look like. I have some notion what I want to achieve, the core building blocks. However the details are designed along the way.

You press F5, run the slide show, and thing.. well here an textbox is missing, that animation should be first etc. 

Same as 'improving' changing some presentation someone else build.. 

There is no hierarchical order of importance.. Inserting/deleting an arranging are equal functions.  

> 
> > * Sliding the panel out of sight, seems to be slightly inconsistent with the
> > approach at the properties deck of the sidebar (collapse/expand).
> 
> We could replace the slider by a collapsing section similar to the print
> dialog.
I personally don't care: implementation details to me.. I do prefer consistency and coherence in UI. Not sure what UI guidelines dictate. Exceptions can be made, but require some explanation.  

> There are some use cases where you want to maximize the lower list
> of available animations and there is your rearrangement situation. Which
> makes it two collapsible panels and I'm concerned about both being closed.
> Would be awkward. Could be solved per code but is a special solution

True
> 
> > I admit that position the up/down buttons & delete button for sorting
> > effects being a problem when considering collapsible regions.
> 
> Better placed right hand of the list anyway. 

Still undecided. For sorting up/down, tend to for yes. Except it gets cramped if you set the sidebar to minimum size.. And the slide sorter bar doesn't have those buttons... 

> > The Slide sorter bar has no visual buttons for arranging or adding slides. 
> > Arranging or adding or deleting slides is done by Drag & Drop (and/or)
> > Keyboard Control (and/or) Context Menu
> 
> You need some means to pick the animation from a long list, which is not the
> fact for the slide pane. Dragging items is possible as well.

I have no clue what this is about. What intended to say. The Slide Sorter bar has no button controls for moving existing slides up/down. It can be done by drag & drop or cut/paste, keyboard ALT+SHIFT+PAGE UP or entry in the right click context menu.

There is also no Delete Slide button. Done by keyboard delete/backspace or right click context menu. I don't see the additional value of a delete button in the animation deck of the sidebar.. 

A difference between slide sorter bar and the sidebar animation panel is that new slides can by added everywhere to the list. Where new animations end up at the bottom of the list by design. Consequence:

A)Sorting of animations being needed more often :-(
B)Greater distances to move, with long list of animations. 

* The ability to expand the animation list, improves drag & drop, but has still limitations with lots of animations 
* Allowing cut/paste of animations maybe also option (obviously only functioning within the animation panel)
* Moving animations up/down with keyboard shortcut (could also have a move to top shortcut)
* Making the list more compact would improve the oversight too. The old sidebar - say LibreOffice Impress 4.4.7.2 - is pretty compact.  Not proposing to revert tot 4.4.7.2 layout :-). 
But I do ask myself, can the animation icon (say the pause button icon in case of Misc Effects, Toggle Pause) not be aligned with the on click icon. So both icons in the same row. Currently text spacing between: Shape Name & effect being pretty large. Probably because of the icon

> 
> > And well - lets face it - the 'Add' button is on weird place anyhow...
> 
> The described workflow with Apply/Cancel is true for dialogs when you
> finalize the configuration. But I admit instead of Add it could be Insert
> placed at the end of this section and with all controls enabled. Workflow
> would be to set-up the animation and insert then. The Insert button could
> become, or rather accomplished by, another button to Modify the selected
> animation.

Note: An animation gets modified straight away, if you touch the effect panel with an animation selected.. And the current UI isn't clear about this behaviour either. There is a possibility for accidental changes to animations. For example changing the animation with the wrong animation selected. 

I don't thinking placing the add animation button (somewhere) at the bottom of the section would make much of difference; It's surely doesn't make it terrible. If you press add, you simply get another entry.. I pretty sure people will learn how to use it pretty quick. I find the current position of the add button slowing down the process inserting; that's a structural problem. The incident with the add button while modifying will probably happen once or twice.
Comment 10 Telesto 2022-10-14 15:19:31 UTC
Another remark, which can be split, but not separated 

1. Open Impress (empty slide)
2. Sidebar -> Animation deck
3. Select click here to add text textbox
4. You need to Press Add to enable the effect list. So you're always inserting (Entrance -> Appear) by default. The next step is modifying the inserting effect to the one you want. 

I would expect the list of available animations being enabled by default.. Being able to pick the right entry, before insertion.
Comment 11 Heiko Tietze 2022-11-08 09:49:11 UTC
The topic was on the agenda of the design meeting but didn't receive further input. Anyway, I'm happy to help with a collapsible section for the effects (and drop the splitter).

If someone else wants to do the easyhack, the file sd/uiconfig/simpress/ui/customanimationspanel.ui needs to be changed and the variables in sd/source/ui/animations/CustomAnimationPane.cxx
Comment 12 Eyal Rozenberg 2023-03-13 13:18:52 UTC
Created attachment 185928 [details]
Add animation menubutton in MS PowerPoint

While this is not what's proposed here, we should perhaps keep in mind Microsoft's approach to this matter in PowerPoint: They don't list any effects on their animation ribbon, they offer a button which opens something between a menu and a dialog (which is quite large and has nice illustration graphics).
Comment 13 Heiko Tietze 2023-09-11 08:40:54 UTC
The splitter (GtkPaned) was silently removed with https://gerrit.libreoffice.org/c/core/+/136343.