Bug 153119 - Crash on paste after convert table to text
Summary: Crash on paste after convert table to text
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.4.2 release
Hardware: All All
: medium critical
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 target:7.6.1
Keywords: bibisected, bisected, haveBacktrace, regression
Depends on:
Blocks: Paste Writer-Tables Crash
  Show dependency tree / graph
 
Reported: 2023-01-19 22:04 UTC by Telesto
Modified: 2024-07-31 06:56 UTC (History)
7 users (show)

See Also:
Crash report or crash signature: ["DelFullParaMoveFrames(SwDoc&, SwUndRng const&, SwRedlineSaveDatas const&)"]

Attachments
Sample (1.19 MB, application/vnd.oasis.opendocument.text)
2023-01-19 22:04 UTC, Telesto 		Details
assertion (9.29 KB, text/plain)
2023-01-20 18:41 UTC, Julien Nabet 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2023-01-19 22:04:22 UTC 
Description:
Crash on paste

Steps to Reproduce:
1. Open the attached file (based attachment 178841 [details] bug 147938
2. Select the table on the last page with "Crash" written in it
3. Select the table
4. Table -> Convert -> table to text -> OK (with default settings)
5. CTRL+Z
6. CTRL+C
7. CTRL+V

Actual Results:
Crash

Expected Results:
No crash


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 37e3455a13ab5741104bf41d05a80e60a4612682
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 1 Telesto 2023-01-19 22:04:55 UTC 
Created attachment 184788 [details]
Sample
Comment 2 m_a_riosv 2023-01-19 22:22:45 UTC 
Repro
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fc441f3886330c4ae2abeb67c0758b935ba23f47
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo
Comment 3 Telesto 2023-01-20 10:57:40 UTC 
Assert Assertion failed: (!pLayout->HasMergedParas() || pNd->GetRedlineMergeFlag() != SwNode::Merge::Hidden), function InsertCnt_, file frmtool.cxx, line 1977. at CTRL+Z

Same as for bug 153115
Comment 4 Julien Nabet 2023-01-20 18:41:04 UTC 
Created attachment 184796 [details]
assertion

Here's an assertion retrieved on pc Debian x86-64 with master sources updated today.
Comment 5 Stéphane Guillou (stragu) 2023-07-19 21:58:44 UTC 
Adding crash signature for good measure. Crash report for 7.5.5.2: https://crashreport.libreoffice.org/stats/crash_details/e0ef61ce-4916-41f9-9d30-1f57c5cb1579

Also in 7.3.7.2: https://crashreport.libreoffice.org/stats/crash_details/dc369695-34ae-4912-aa5e-f72d55bdee7e
Comment 6 Stéphane Guillou (stragu) 2023-07-20 06:22:15 UTC 
Still crashing in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 46d7119b8be03968017e59d882e5671350304e15
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Bibisected with linux-64-7.3 repo to first bad commit 4e5a4d294a0fb49c5a891d365c5c3b9f1fc8834d which points to core commit f0254aaea7d4a6a261731f76c99cb06f1b5ab2b1 which is a cherrypick of:

commit b97116791047f89b768ab4aa8126e543df826be3
author	László Németh Fri Apr 22 20:34:32 2022 +0200
committer	László Németh Mon Apr 25 17:43:47 2022 +0200
tdf#141391 sw: don't paste as nested table in first cell paragraph
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133377

László, can you please have a look?
Comment 7 Stéphane Guillou (stragu) 2024-07-31 06:12:14 UTC 
No crash in:

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 233af54afb6e493c3538efe7c93d0f53f1b4c3ab
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3

Version: 24.2.5.2 (X86_64) / LibreOffice Community

Version: 7.6.7.2 (X86_64) / LibreOffice Community

Bibisected the fix with linux-64-7.6 to first good build [70552073ab0084f11812ac76a76b3622102c1e04] which is 28a3435cda15509dd9832f48607aac908bde3954, a cherrypick of:

commit 3d8697dab9a4a29666440a30c5c7a6d9d9f76d76	[log]
author	Michael Stahl 	Fri Aug 04 13:06:51 2023 +0200
committer	Michael Stahl 	Fri Aug 04 18:14:02 2023 +0200
tdf#147938 sw: Undo of table to text uses ContentIdxStore wrong
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155344

Thanks mst!