Bug 153880 - Make Calc text hyperlinks stand out more
Summary: Make Calc text hyperlinks stand out more
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.2.0.3 release
Hardware: All All
: medium enhancement
Assignee: Balázs Varga (allotropia)
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: Hyperlink-Calc
  Show dependency treegraph
 
Reported: 2023-02-28 09:21 UTC by Gabor Kelemen (allotropia)
Modified: 2024-02-19 16:16 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file with hyperlink and Hyperlink styled cell (11.93 KB, application/vnd.oasis.opendocument.spreadsheet)
2023-02-28 09:21 UTC, Gabor Kelemen (allotropia)
Details
Screenshot of the example file in Calc master (49.85 KB, image/png)
2023-02-28 09:22 UTC, Gabor Kelemen (allotropia)
Details
Screenphoto of how it looks on my external monitor (6.75 MB, image/jpeg)
2023-02-28 09:24 UTC, Gabor Kelemen (allotropia)
Details
Different colors (40.94 KB, image/png)
2023-02-28 10:30 UTC, Heiko Tietze
Details
The example file under Windows - Light theme (28.31 KB, image/png)
2023-03-01 10:21 UTC, Gabor Kelemen (allotropia)
Details
The example file under Windows - Dark theme (31.18 KB, image/png)
2023-03-01 10:24 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-02-28 09:21:39 UTC
Created attachment 185633 [details]
Example file with hyperlink and Hyperlink styled cell

Since bug 66545 was fixed, a text based hyperlink in Calc is distinguished by a light blue color (see Options - Application Colors - General - Unvisited links).
This is somewhat difficult to see, on certain monitors.

It would be better to make it stand out more of unformatted text.
For comparison there is a Hyperlink cell style, which has a more bright blue color and underlining set. This stands out better, see attached file.
Adding underlining and maybe changing the font color could work here.

1. Open attached file
2. Lean back and tell which cell is hyperlink.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2da16ff9f018fae68c53a801e5a234dafc2ebcec
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: default
Comment 1 Gabor Kelemen (allotropia) 2023-02-28 09:22:08 UTC
Created attachment 185634 [details]
Screenshot of the example file in Calc master
Comment 2 Gabor Kelemen (allotropia) 2023-02-28 09:24:07 UTC
Created attachment 185635 [details]
Screenphoto of how it looks on my external monitor

Perhaps it's just my monitor, but probably not.
This was originally noticed by a customer of ours.
Comment 3 Heiko Tietze 2023-02-28 10:30:27 UTC
Created attachment 185640 [details]
Different colors

The link color is read from the OS (svtools/source/config/colorcfg.cxx #430). On my KDE/Breeze it is #2980b9. The official Wikipedia link color is #3366cc, a bit more blueish but still not "out standing". Plus, if we use hard-coded values we loose the system integration (eg. orange link color on some weird theme). OTOH, system colors are designed for a certain background, dark in my case, and do not necessarily suit editing controls.

We also have the underline attribute. And I could imagine this has been omitted intentionally to not clutter the appearances.

Optional? If, as expert option to not pollute the options dialog.
Comment 4 Gabor Kelemen (allotropia) 2023-03-01 10:21:27 UTC
Created attachment 185662 [details]
The example file under Windows - Light theme
Comment 5 Gabor Kelemen (allotropia) 2023-03-01 10:24:10 UTC
Created attachment 185663 [details]
The example file under Windows - Dark theme

There is indeed a bit of difference in color under Windows depending on the light/dark theme setting.

Still: I think adding automatic underlining here would be probably helpful.
Comment 6 Cor Nouws 2023-03-09 08:42:29 UTC
I agree that keeping consistent behavior with themes etc is needed. But within that limit, is there a possibility to improve visibility? It's not a strange idea, looking at the current vague situation.
Comment 7 Heiko Tietze 2023-03-09 16:53:46 UTC
We discussed the topic in the meeting.

The proposed underlining for links is welcome without an extra option. Possibly easyhackable.
Comment 8 Commit Notification 2023-04-04 18:17:18 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/89e65e6afdfc942cf8232886d6703947167eaec3

tdf#153880 sc: Make Calc text hyperlinks stand out more

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Gabor Kelemen (allotropia) 2023-04-13 08:49:23 UTC
Verified in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fc6806c4be8585ce0d35a6b581bf8b3dbf858500
CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded

Underlining now appears, making the link stand out more under light theme of Windows.

Added to https://wiki.documentfoundation.org/ReleaseNotes/7.6#Calc