Bug 154547 - Hebrew fonts in drop-down list don't show the full expected phrase
Summary: Hebrew fonts in drop-down list don't show the full expected phrase
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.5.1.2 release
Hardware: All All
: medium minor
Assignee: ⁨خالد حسني⁩
URL:
Whiteboard: target:7.6.0 target:7.5.5
Keywords:
Depends on:
Blocks: Hebrew Fonts-Name-Combobox RTL-UI
  Show dependency treegraph
 
Reported: 2023-04-01 20:20 UTC by Eyal Rozenberg
Modified: 2023-07-31 18:48 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
The font family selection drop-down menu with a bunch of different wants (191.54 KB, image/png)
2023-04-01 20:20 UTC, Eyal Rozenberg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2023-04-01 20:20:13 UTC
Created attachment 186398 [details]
The font family selection drop-down menu with a bunch of different wants

When selecting a font (family) on the formatting toolbar of Writer or the Text Formatting toolbar of Impress etc, there's a drop-down list of font families. For each of these we see its name in English, and in the case of fonts somehow associated with an RTL-CTL language, a phrase in that language: אָלֶף־בֵּית עִבְרִי for Hebrew, or ابجدية عربية for Arabic etc.

... except that this fails for many Hebrew fonts.

Some of these fonts don't have glyphs for Hebrew Nikkud, and _probably_ for this reason, they only show some, or none, of the phrase, e.g. just אב . This is true for fonts such as Abraham, Daniel, Amit, and even Anka CLM (most CLM fonts show the full phrase, you see).

Some have weirder behavior, like the Aharoni (not CLM) font, which shows a bunch of final-form letters with Dagesh (emphasis) marks and other Nikkud - and they do have Nikkud. The Acheneli font shows the phrase גלצ for some reason.

Seeing this with:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b5c3a7502f7ff6ccf0f829c1f3a2ba50b8584c41
CPU threads: 4; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: he-IL (en_IL); UI: en-US

... but I think this issues goes waay back/
Comment 1 Eyal Rozenberg 2023-04-01 20:22:01 UTC
This is not a Gtk issue, seeing the same behavior with:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b5c3a7502f7ff6ccf0f829c1f3a2ba50b8584c41
CPU threads: 4; OS: Linux 6.1; UI render: default; VCL: kf5 (cairo+xcb)
Locale: he-IL (en_IL); UI: en-US
Calc: threaded

and with qt5.
Comment 2 Eyal Rozenberg 2023-04-01 20:23:26 UTC
I should mention I don't really see this particular with Arabic, although it may be just a fluke, since I don't have many Arabic fonts.
Comment 3 Buovjaga 2023-04-20 12:50:34 UTC
Downloaded Anka from https://culmus.sourceforge.io/fancy/index.html and it seems to be showing only three glyphs, which I guess is the wrong result, so let's set to NEW.

Arch Linux 64-bit, X11
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 68912948e376ce0b080a0d2a76dd9d951f8bcdf6
CPU threads: 8; OS: Linux 6.2; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 20 April 2023
Comment 4 ⁨خالد حسني⁩ 2023-05-28 10:04:54 UTC
The sample text was introduced in bug 33510, but I agree that including Nikkud is not necessary.

Currently if the font does not have glyphs for all preview characters, a shorter text is used and for Hebrew that is אב.
Comment 5 Commit Notification 2023-05-28 11:07:59 UTC
Khaled Hosny committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/da09513ae6221f46ee453943b3669d1d922a4aa3

tdf#154547: Improve Hebrew font preview sample text

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-05-30 14:03:41 UTC
Khaled Hosny committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/547bfbdbdaaa3b44f76952275bf87453f7c8293a

tdf#154547: Improve Hebrew font preview sample text

It will be available in 7.5.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.