Created attachment 191113 [details] shows and describes the bug with screenshots This bug came up with LO Writer Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b3fdd999f87312447d03915585812b3a5cd48141 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: en-US Calc: threaded but if I remember right, it was already present in earlier versions. Consider you want to insert a hyperlink. After clicking Apply, the sub-dialog Target in document should automatically terminate because all choices have been done at that point. The button for the other choice Close currently has to be used in addition after Apply in order to leave that dialog. The button Close is only used if one wants to leave the dialog without assigning a target. (Probably Back would be a better label for this button). One still could do without the button Close because of the close window X button at the top of the window.) After closing (which is currently necessary after one has applied, the parent-Window of the shown one is shown like an inactive one. Instead the main LibreOffice Writer window behind it is shown with a blue title bar. I would have expected that the main LO Window has a gray title bar and the sub dialog window "Hyperlink" appears with a highlighted title bar. Further all buttons of the dialog “Hyperlink” are grayed out. But they work, and one has to Apply them in order to assign the hyperlink to the highlighted portion of the LO Writer document. BTW: But one could do without the button Apply in the dialog "Hyperlink": one should subsume its function under OK. The button Close seems to be totally equivalent to X on the top so one could do without it. It leads you out of the dialog without any change whereas Reset just resets all entries made in this dialog to the state it had when the dialog was invoked but keeps you in the dialog. I consider this bug a minor one. Nevertheless, it should be fixed, because it will only cause a beginner to stumble with LibreOffice.
László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7059a1858ddb044c5f3f0c8e0386d3e1d9dd2b5f tdf#119908 tdf#158439 sw smart justify: fix freezing with NBSP It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
1) I agree that there should be an extra "OK" button to apply + close the dialog. However, keeping the "Apply" button in this dialog is important because both dialogs can be kept open and used at the same time to go through a document and insert many hyperlinks at once without having to constantly reopen the same dialog. Let's focus this report on this enhancement. Setting as "new" but just copying the UX/Design team in to confirm. 2) Regarding the focus of the Hyperlink dialog: I can't reproduce the issue. In any case, better to report this separately. Tested in OOo 3.3 and a recent trunk build: Version: 24.2.0.0.beta1 (X86_64) / LibreOffice Community Build ID: 5f390384195b7264c6e52add9e90a39790285249 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded
(In reply to Adalbert Hanßen from comment #0) > After clicking Apply, the sub-dialog Target in document should automatically > terminate because all choices have been done at that point. +1, any objection? @Adalbert: Please write the report directly in Bugzilla (ideally very short). The attached document is quite inconvenient.
(In reply to Heiko Tietze from comment #3) > (In reply to Adalbert Hanßen from comment #0) > > After clicking Apply, the sub-dialog Target in document should automatically > > terminate because all choices have been done at that point. > +1, any objection? Yes, my comment 2, point (1). I think some workflows rely on the Target in Document staying opened, so I vote for keeping the current Apply button as it is, but adding an OK button to apply and close at once.
In reply to Heiko Tietze Comment #3. Yes, I have a major objection, for the reason stated by Stéphane Guillou in comment#4. This ill conceived proposal has been raised in the past and closed as a Won't Fix, because NOT "all choices have been done at the point." where the user may wish to "Apply" and continue to add more Hyperlinks. I have clients using LO Calc spreadsheets where a number of hyperlinks need to be updated in the same session, so it will be an inconvenience and a likely customer objection to using LO. If new users don't understand the difference between the words "Apply" and "Close", add tooltips to the buttons.
We talk about Hyperlink > Target in Document, which has Apply and Close buttons. What would you do after picking a target from the list and applying it? Sounds reasonable to close the dialog with Apply ( => Ok) or to close without ( => Cancel). (In reply to Daveo from comment #5) > This ill conceived proposal has been raised in the past and closed as a Won't Fix Vaguely I might remember. Do you have a bug number?
I propose no change and to leave the functionality the same as it is now, after clicking "Apply" the dialog remains open and the user is free to click on a cell to add/edit a hyperlink in the open spreadsheet. No, "Apply" closing the dialog does not sound reasonable to me or my clients. The proposal was made some years ago and I can't immediately find my record of the bug number. I will see if I can track it down and post back.
Take a look at Bug #56456 dated 2012-10-27
Found it, and since there is some resistance the WF verdict is still valid. *** This bug has been marked as a duplicate of bug 90679 ***
(In reply to Daveo from comment #8) > Take a look at Bug #56456 dated 2012-10-27 Wasn't this rather about the "main" hyperlink dialog? Anyway, the other ticket is a perfect match.
(In reply to Daveo from comment #5) > ... > This ill conceived proposal has been raised in the past and closed as a > Won't Fix, because NOT "all choices have been done at the point." where the > user may wish to "Apply" and continue to add more Hyperlinks. > I have clients using LO Calc spreadsheets where a number of hyperlinks need > to be updated in the same session, so it will be an inconvenience and a > likely customer objection to using LO. > ... My proposal is about LO Writer. I have checked: it is not possible to apply multiple hyperlinks to something in LO Writer (what should it be good for? Which of multiple hyperlinks associated should be followed after a Ctl-click operation?) I have not seen a selection coming up to select from multiple hyperlinks I have tried to associate to some token. Also I was unable to edit any of the earlier applied hyperlinks: It looks like at most one hyperlink can be associated to some token visible in the edit area and I see no real benefit if one could associate more than one to a particular token. If I would like to offer say three choices, I would write something like "here are three hyperlink choices: first, second and third and I would associate to each of first..third one of the relevant hyperlinks. What other choice than apply and close or undo do you really want to make after selecting a hyperlink target?
(In reply to Heiko Tietze from comment #6) > We talk about Hyperlink > Target in Document, which has Apply and Close > buttons. What would you do after picking a target from the list and applying > it? (In reply to Adalbert Hanßen from comment #11) > I have checked: it is not possible to apply multiple hyperlinks to something > in LO Writer (what should it be good for? Which of multiple hyperlinks > associated should be followed after a Ctl-click operation?) What I meant by that use-case: 1. Select some text 2. Ctrl + K 3. Click Target button, select a target, click Apply 4. Select another piece of text in the document 5. Click another target (or keep the same) in the Target dialog, click Apply 6. Repeat steps 4 and 5 as many times as needed. I can imagine users going through a document to hyperlink many different bits of text to various targets. Keeping the dialog open is important for that. (In reply to Heiko Tietze from comment #9) > Found it, and since there is some resistance the WF verdict is still valid. I don't think Andreas was against the proposal of adding a OK button in bug 90679 comment 5, but rather against removing the existing Apply and Close buttons. Any issue for an extra "OK" button, to apply + close at once, just like in many other dialogs? Everyone would be happy: nothing taken away, but an option to save one click, and consistency with other dialogs.
While Bug #56456 mainly references Writer, the same reasoning applies to both Calc and Writer.
(In reply to Stéphane Guillou (stragu) from comment #12) > 1. Select some text > 2. Ctrl + K > 3. Click Target button, select a target, click Apply > 4. Select another piece of text in the document > 5. Click another target (or keep the same) in the Target dialog, click Apply > 6. Repeat steps 4 and 5 as many times as needed. (sorry, missing step 5b: click "Apply" in Hyperlink dialog too)
(In reply to Heiko Tietze from comment #10) > (In reply to Daveo from comment #8) > > Take a look at Bug #56456 dated 2012-10-27 > Wasn't this rather about the "main" hyperlink dialog? Anyway, the other > ticket is a perfect match. Indeed, it is a perfect match! And https://bugs.documentfoundation.org/show_bug.cgi?id=56456#c3 also proposed a feasible solution. Despite that, a non-ending discussion followed in that thread. And don't forget another minor quirk mentioned at the end of my post: After closing the sub-dialog the then-again active window, it is not shown as active window with the title bar of the active window in blue but with a gray title bar like all other currently non active windows (some system themes don't show this distinction, but under Linux Adwaita+Moheli does so and that's why I use this combination).