Bug 158761 - Add Show/Hide comment or Show all Comments command to right click menu of comments in Calc Navigator
Summary: Add Show/Hide comment or Show all Comments command to right click menu of com...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Navigator
  Show dependency treegraph
 
Reported: 2023-12-18 10:28 UTC by Gabor Kelemen (allotropia)
Modified: 2024-01-24 15:07 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
How a long comment looks in the Navigator (53.67 KB, image/png)
2023-12-18 10:28 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-12-18 10:28:54 UTC
Created attachment 191480 [details]
How a long comment looks in the Navigator

This is a followup to bug 158514

If a cell has a long comment text, the comment can be longer than what the Navigator in the sidebar can display. In this case the text appears in a popup balloon.

It would be convenient to add some commands to the context menu, so that the display of comments can be enabled/disabled in the document.

I see several options for this:
- Add the View - Comments command, so that every comment can be shown/hidden. This can be good when one wants to check all comments quickly with the Navigator
- Or from the cells context menu Show Comment / Hide Comment commands to show/hide an individual cells comment. This can be convenient if there are many comments overlapping each other.
- Both? Maybe 4 items (Edit, Delete, Show all, alternating Show/Hide) in the context menu would be too many?
Or this is still fine for the different use cases?

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: bcbc0857bf4bc24b5ea36e445a367cce0a382da4
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded
Comment 1 Heiko Tietze 2023-12-19 08:08:03 UTC
The "popup balloon" is just a tooltip for not fully shown text (I'd expect ellipsis, btw). And it has little to do with the context menu...

The View > Comments option exist (also via comment pane header in case of Writer) and I see no contextual reason to add this at the Navigator's popup menu. But likewise for Writer we should provide functions for the individual comments such as Edit, Delete, and Go-to. The latter exists as default (double-click) but adds not much value. We could rather show the comment temporarily and automatically hide / fade-out after a few seconds. Or we show the comment on hover and go into edit per double-click.

In a nutshell, yes to all but "Show All".
Comment 2 Rafael Lima 2024-01-09 14:25:56 UTC
IMO we could either (i) add the Show/Hide commands to the context menu or (ii) create a "Go to" entry to be more similar to Writer.

The "Go to" command would simply focus the cell containing the note and show it in non-edit mode.
Comment 3 Heiko Tietze 2024-01-15 15:25:24 UTC
Not much controversial here, go ahead.
Comment 4 ady 2024-01-19 04:00:02 UTC
I'm not sure anymore in/to which enhancement request I should post feedback (of the several reports opened in the last few weeks related to adding UI features regarding comments in Calc).

In the cell’s context / right click menu, we used to have (until LO 7.6 included):

* for cells with no comments, 1 entry "Insert Comment";

* for cells that already have a comment, 3 entries: Edit, Delete, Show comment (or Hide Comment instead of the latest, still 3 entries max).

After the changes related to Calc comments introduced in the last few weeks, we now have, at all times, permanently, unconditionally, 5 items in the cell's context menu: Insert, Edit, Delete, Show, Hide Comments.

Moreover, if we select/focus on just one cell, only part of these 5 items can be applied at any time:

* without a comment, only 1 item is usable, 4 are wasting screen space and bothering (which clearly explains the 2+ different alternative menus I described above).

* in a cell with a comment, 2 items are not usable.

Insert Comment cannot be usable at the same time as Edit Comment, ever, so what’s the point of having them simultaneously in the context menu? Similarly, Show and Hide Comment should not be displayed simultaneously, and not at all when there is no comment to be shown nor hidden. I could describe each and every item and conditions, but probably you get the point by now.

When selecting _more than 1_ cell, of which some have a comment and some do not, the result of each of these items is unclear/undefined, which makes them even more confusing and more of a waste (of screen usability / visibility, if nothing else). OTOH, I can think of several alternatives that might result useful in some situations.

I hope this new permanent waste and abuse of screen areas can be reduced to a minimum, not more than the really necessary; more similar to what it used to be until recently.
Comment 5 Heiko Tietze 2024-01-19 09:27:38 UTC
(In reply to ady from comment #4)
> Insert Comment cannot be usable at the same time as Edit Comment...
Commented on this myself.

> When selecting _more than 1_ cell, of which some have a comment...
You could file a ticket "Hide commenting actions on multiselection".

> I hope this new permanent waste and abuse of screen areas can be reduced...
Fully agree. But this ticket requests an entry in the Navigator.
Comment 6 ady 2024-01-19 10:09:42 UTC
(In reply to Heiko Tietze from comment #5)
> > I hope this new permanent waste and abuse of screen areas can be reduced...
> Fully agree. But this ticket requests an entry in the Navigator.

I apologize. As I mentioned in comment 4, I am no longer able to really keep track of each of the recently opened enhancement requests related to comments. There is a combination of actions (insert, edit, show, hide, toggle view, all comments...) with the UI area (cell's context menu; navigator and its context menu and what happens next; tabbed toolbar), and more. I would appreciate anyone pointing me to the adequate report to comment in it. TIA.

Although my comment 4 refers to the cell's context menu, I guess the main point is applicable to the other UI areas in which these comment-related changes are being implemented.
Comment 7 Rafael Lima 2024-01-24 15:07:20 UTC
(In reply to ady from comment #6)
> Although my comment 4 refers to the cell's context menu, I guess the main
> point is applicable to the other UI areas in which these comment-related
> changes are being implemented.

I guess you're referring to the issue being tracked on bug 158101.