Bug 158514 - Add Edit command to right click menu of comments in Calc Navigator
Summary: Add Edit command to right click menu of comments in Calc Navigator
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Rafael Lima
URL:
Whiteboard: target:24.8.0
Keywords:
Depends on:
Blocks: Calc-Comments Navigator
  Show dependency treegraph
 
Reported: 2023-12-04 13:14 UTC by Gabor Kelemen (allotropia)
Modified: 2024-01-03 23:50 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Current Calc Navigator behavior (29.20 KB, image/png)
2023-12-04 13:14 UTC, Gabor Kelemen (allotropia)
Details
Opening existing comments like this is cumbersome (30.64 KB, image/png)
2023-12-04 13:15 UTC, Gabor Kelemen (allotropia)
Details
Example Calc file to test (8.93 KB, application/vnd.oasis.opendocument.spreadsheet)
2023-12-04 13:15 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-12-04 13:14:30 UTC
Created attachment 191222 [details]
Current Calc Navigator behavior

Currently when a cell contains a comment in Calc, the Navigator lists the comment and by double clicking on it, allows to edit the cell contents.

To edit the content of the comment itself, one needs to position the highlight in the cell, right click and select Edit Comment.

It would be more user friendly to have a right click Edit menu item in the Navigator that would directly open the comment for editing.
This works already in Writer, so the behavior would be consistent.

Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 43967453e15e1d054972a7586cfef8f8e0866270
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded
Comment 1 Gabor Kelemen (allotropia) 2023-12-04 13:15:12 UTC
Created attachment 191223 [details]
Opening existing comments like this is cumbersome
Comment 2 Gabor Kelemen (allotropia) 2023-12-04 13:15:36 UTC
Created attachment 191224 [details]
Example Calc file to test
Comment 3 Rafael Lima 2023-12-08 15:06:49 UTC
I support this request.

How about showing the comment when you double-click it in the Navigator, instead of having to right click it?
Comment 4 Heiko Tietze 2023-12-11 11:14:48 UTC
Bug 64701 asks for "Show Comments Should Select Comment for Editing" and I wonder if double clicking the Navigator should not only select the cell but also enter the edit mode directly.

Otherwise, the proposed Edit function should not change the content within the Navigator (like F2 to rename a file name) but activate the item itself.
Comment 5 Rafael Lima 2023-12-12 00:38:17 UTC
Here's a proposed solution:
https://gerrit.libreoffice.org/c/core/+/160582

When the user double-clicks the comment, it is automatically made visible.
Comment 6 Gabor Kelemen (allotropia) 2023-12-14 16:09:11 UTC
(In reply to Heiko Tietze from comment #4)
> Bug 64701 asks for "Show Comments Should Select Comment for Editing" and I
> wonder if double clicking the Navigator should not only select the cell but
> also enter the edit mode directly.
> 
I think going directly to edit would make sense. Filed as bug 158707.

Bug 64701 on the other hand is WFM, if someone wants to quickly edit a comment, they should just use the Edit Comment command and press Esc when done. Show comment is not made for this use case.
Comment 7 Commit Notification 2023-12-16 00:25:01 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/46c1ce9ac9fa8eff069d5998a6d96a639f277a8e

tdf#158514 Add "Edit Comment" entry to the navigator popup

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Gabor Kelemen (allotropia) 2023-12-19 09:07:10 UTC
Thanks Rafael for fixing this!
Further improvement ideas / problems added to See Also.
Comment 9 Stéphane Guillou (stragu) 2023-12-28 16:29:01 UTC
Thanks Rafael. I tested with the gtk3 VCL plugin and see an issue:
1. Right-click > Edit comment
2. Use Delete key: characters are removed from the beginning (OK)
3. Type extra characters: the Navigator filter is focused instead. (not OK)

Not reproduced with gen VCL plugin.
Behaviour should be the same as the (current) result of double-clicking the comment in the Navigator (works as intended for gtk3).

Do you want to follow-up here or should I open a separate report?

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 40617d867346956588ac023511f31210107217f4
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 10 Stéphane Guillou (stragu) 2024-01-03 23:50:42 UTC
(In reply to Stéphane Guillou (stragu) from comment #9)
> [...] the Navigator filter is focused instead. (not OK)
> Not reproduced with gen VCL plugin.
> Behaviour should be the same as the (current) result of double-clicking the
> comment in the Navigator (works as intended for gtk3).
> 
> Do you want to follow-up here or should I open a separate report?
Ah, Gabor already followed-up with bug 158763 :)