Bug 159196 - Deleting a column of a floating table with Track changes ON and show OFF deletes the whole table
Summary: Deleting a column of a floating table with Track changes ON and show OFF dele...
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium minor
Assignee: László Németh
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Undo-Redo Track-Changes-Table
  Show dependency tree / graph
 
Reported: 2024-01-15 13:44 UTC by Telesto
Modified: 2024-06-05 14:38 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2024-01-15 13:44:09 UTC 
Description:
Deleting a column of a floating table with Track changes ON and show OFF deletes the whole table and no restore with undo 

Steps to Reproduce:
1. Open attachment 191950 [details] (bug 159195)
2. Make sure track changes show being turned OFF
3. Delete a column -> Table gone
4. Press undo -> short freeze and no restoration


Actual Results:
* Whole table deleted
* No undo

Expected Results:
* only column deleted
* undo


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 25276df12abd9d002f7f899900434617b256f745
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 1 Telesto 2024-01-15 13:45:10 UTC 
With show ON the whole table gets marked as deleted, undo works
Comment 2 Buovjaga 2024-01-26 14:20:56 UTC 
The deletion behaves like this already in 3.5.0 (Linux bibisect-43all repo).
Comment 3 Buovjaga 2024-01-27 07:40:26 UTC 
Hmm, what's the fix?
Comment 4 Telesto 2024-01-27 15:54:18 UTC 
(In reply to Buovjaga from comment #3)
> Hmm, what's the fix?

No clue what happened here.. The log doesn't lie, so I'm the one to blame for changing the status.. human error
Comment 5 Stéphane Guillou (stragu) 2024-02-21 05:03:18 UTC 
Whole table gone in OOo 3.3 as well. However, undo does bring back the whole table.
The undo issue is a recent 7.6 regression, let's track it separately in bug 159812 (bibisected to a different commit to bug 159195).
Comment 6 Stéphane Guillou (stragu) 2024-02-22 03:37:58 UTC 
Actually, the disappearance of the whole table from OOo 3.3 to LO 7.5 was unrelated to track changes. It also happens with track changes off, and was resolved in 7.5.

Issues with deleting a column while tracking changes started in 7.6. Bibisected with linux-64-7.6:

0) No issue at oldest

1) Column not deleted, table's contents deleted instead since [93946771cff6ca5a85d02a2276a691f051223e50], which is an implementation error from when deletion of columns started being tracked:

commit d1004cdd6a445ae73673b0ca360ae034b0ec09f2
author	László Németh <nemeth@numbertext.org>	Tue May 09 16:51:06 2023 +0200
committer	László Németh <nemeth@numbertext.org>	Thu May 11 13:51:47 2023 +0200
tdf#150673 sw offapi: add change tracking of table column deletion

(same at [ef40a621e99ce3c3abd2ad9b67915eec060f3ef8] e91faddabdf5d586c0044a3e125bdea6c2e21532, which is when bug 159812 started)

2) Whole table gone when deleting the column since [88d9624e446f3362be67a141b4c5725c54746bca], which is dfa57ee45bf9aef73f8bf385b089739ee0572998, a cherrypick of:

commit 43b128a960d1712b984402e1b69cefecdb75462a
author	László Németh 	Tue Aug 08 19:46:15 2023 +0200
committer	László Németh 	Wed Aug 09 16:28:37 2023 +0200
tdf#156487 sw tracked table column: fix Hide Changes

László, can you please have a look?