Bug 160293 - When clicking inside a pivot table, GroupedBar Compact hides all its groups except "File" and "Edit"
Summary: When clicking inside a pivot table, GroupedBar Compact hides all its groups e...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.1.0.3 release
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:24.8.0
Keywords: implementationError
Depends on:
Blocks: Pivot-Table Notebookbar-Groupedbar
  Show dependency treegraph
 
Reported: 2024-03-21 03:45 UTC by Jeff Fortin Tam
Modified: 2024-04-19 03:20 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Fortin Tam 2024-03-21 03:45:45 UTC
1. Create a spreadsheet with a pivot table
2. Set LibreOffice's toolbar UI layout mode to "Groupedbar compact"
3. Click a cell inside the existing pivot table

Result: all the toolbar group sections other than "File" and "Edit" disappear.

Expected result: they should not disappear; or at _least_, the "Data" group section should remain shown, because it contains various things relevant to pivot tables, if I am not mistaken.

In comparison, when using the other toolbar modes, such as "Standard" (traditional toolbars), "Tabbed" (notebookbar), or "Tabbed Compact", the UI doesn't change at all when clicking inside a pivot table's cells area.

----

Tested with:

Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 8; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Flatpak
Calc: threaded
Comment 1 Stéphane Guillou (stragu) 2024-04-06 23:01:01 UTC
Reproduced in 6.1.0.3, likely an implementation error.

Also in recent trunk build:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 30c6e51fc9cb0fa864e1755271343d847fcced25
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded
Comment 2 Stéphane Guillou (stragu) 2024-04-06 23:10:48 UTC
Justin, you digged a bit into the context sensitivity of the compact Groupedbar. Maybe this one is a more obvious fix than bug 123056?
Comment 3 Justin L 2024-04-10 16:44:34 UTC
ScTabViewShell::SetPivotShell calls SetCurSubShell(OST_Pivot) which seems to be what triggers the lost notebookbar.

This ends up calling ContextVBox::SetContext, which disables the tab unless it supports context-any or context-Pivot. 

So the solution appears to be indicating that sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui needs to add context-Pivot to ContextVBox containing the styles thru extensions tab definitions.
Comment 4 Commit Notification 2024-04-10 21:13:23 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7b515b473cfb706c9fa0b474f27d61351aeec3a3

tdf#160293 sc NBB: tabbed groupbar_compact keep tabs in Pivot context

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Stéphane Guillou (stragu) 2024-04-19 03:20:46 UTC
Thank you for the quick fix, Justin! Verified with:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: bdf3b5ce49b0e4ee1b4525d344cfb037ef473059
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded