Bug 160525 - Crash in: Edit::ImplSetText(rtl::OUString const &,Selection const *) when opening Bullets and Numbering dialog in Impress (Skia)
Summary: Crash in: Edit::ImplSetText(rtl::OUString const &,Selection const *) when ope...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All Windows (All)
: high critical
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, haveBacktrace, regression
Depends on:
Blocks: Impress-Bullet-Number Skia Crash
  Show dependency treegraph
 
Reported: 2024-04-04 23:16 UTC by Leonard
Modified: 2024-06-15 18:40 UTC (History)
3 users (show)

See Also:
Crash report or crash signature: ["Edit::ImplSetText(rtl::OUString const &,Selection const *)"]


Attachments
test ODP (12.18 KB, application/vnd.oasis.opendocument.presentation)
2024-04-05 02:32 UTC, Stéphane Guillou (stragu)
Details
WinDbg backtrace for LO 24.2.2.2 (9.44 KB, text/plain)
2024-04-06 06:34 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Leonard 2024-04-04 23:16:29 UTC
This bug was filed from the crash reporting server and is br-bd42ce44-b7db-4c93-9305-4a29e7c66ae8.
=========================================

2 Crashes:
https://crashreport.libreoffice.org/stats/crash_details/0874ac49-4d39-457c-ba8c-141de9b4bf6e
https://crashreport.libreoffice.org/stats/crash_details/bd42ce44-b7db-4c93-9305-4a29e7c66ae8
===

Impress Presentation:
- Bullet of type "C. Some Text" (starting at 3);
- Right-Click on a word => "Bullet points" => Crash;
Comment 1 Stéphane Guillou (stragu) 2024-04-05 02:32:01 UTC
Created attachment 193501 [details]
test ODP

Not reproduced on Linux with the sample file I created above:

Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

- Can you reproduce the crash with this file?
- If not, do you have a sample file that you could share?
Comment 2 Stéphane Guillou (stragu) 2024-04-05 03:37:53 UTC
Ah, reproduced on Windows 11 with my sample file:

https://crashreport.libreoffice.org/stats/crash_details/761c4bf0-dc69-48f7-a99e-ce568a9d79e8

Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

However, not reproduced in current trunk build:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7b9905df455b47977968a185a7c43f35541e018b
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Nor in 24.2.2.2:

Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Nor in 7.6.6.3:

Version: 7.6.6.3 (X86_64) / LibreOffice Community
Build ID: d97b2716a9a4a2ce1391dee1765565ea469b0ae7
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Nor in 7.5.0.3.

Regression that is already fixed, but not sure by which commit included in 24.2.2.2.
Comment 3 Leonard 2024-04-06 01:27:06 UTC
New Crash with version 24.2.2:
https://crashreport.libreoffice.org/stats/crash_details/bdd7d520-f563-4695-94a0-5c8d84907fbf

====

1. Opened my previous file
2. Right clicked word in bullet level 3 ("C."): worked fine;
3. Changed to level 4: OK;
4. Next slide: clicked on similar bullet with level 3 ("C");
5. Changed to level 5 ("E")
=> Crash

After restarting LibreOffice:
- changed to bullet level 4: NO crash;
- changed then to bullet level 5: still NO crash;
- but did not check if changing directly to level 5 will repeat the crash;
Comment 4 Stéphane Guillou (stragu) 2024-04-06 05:02:59 UTC
Indeed, there are still more issues.
Using the same attachment, I still reproduce a crash with 24.2.2.2, but can't figure out a 100% consistent set of steps. It can happen on first opening of the dialog, or on the third go, and duplicate the slide or getting in and out of text box edit mode might help.

Note that if the dialog does open and close successfully, there is an active drag-and-drop selection on the text for some reason. Might be related?

Result: https://crashreport.libreoffice.org/stats/crash_details/15e22769-6691-47ab-b842-3766dfd0fdba
Comment 5 Stéphane Guillou (stragu) 2024-04-06 06:34:17 UTC
Created attachment 193534 [details]
WinDbg backtrace for LO 24.2.2.2
Comment 6 gladys 2024-06-13 19:39:31 UTC
 crash still appear in version:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 74185b8edf7f046a3372319da86a1d8ca0024c87
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: CL threaded

try to bibisect on windows10 version 24.2. Seem to point to commit cc79cd60e98804bbb0f23234f45fa214040970ae but not sure.

author	Noel Grandin <noel.grandin@collabora.co.uk>	
Date: Fri Jul 21 12:27:34 2023

 message:
remove unused SvtPathOptions methods

ever since
commit 519876dffdc8c93710af543cc11332dab9a50c14
    Author: Mike Kaganski <mike.kaganski@collabora.com>
    Date:   Tue Jul 18 23:45:47 2023 +0300
    Cleanup SfxApplication::Get/SetOptions, and drop unused SIDs
Comment 7 Buovjaga 2024-06-14 06:23:21 UTC
(In reply to gladys from comment #6)
>  crash still appear in version:
> 
> Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: 74185b8edf7f046a3372319da86a1d8ca0024c87
> CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL:
> win
> Locale: en-GB (en_GB); UI: en-GB
> Calc: CL threaded
> 
> try to bibisect on windows10 version 24.2. Seem to point to commit
> cc79cd60e98804bbb0f23234f45fa214040970ae but not sure.

I tried with the same bibisect repo and I was able to make it crash even with the preceding commit. As discussed in previous comments, there are no reliable steps. The last time I changed the "Start at" value in Bullets and Numbering dialog almost 15 times until it crashed. So it might be bibisected, but it takes a lot of time...
Comment 8 Buovjaga 2024-06-15 18:40:56 UTC
Ugh, this was a cursed bibisect. Unfortunately there was a large number of commits, where the file crashed upon opening! At least it gave birth to a PowerShell example in https://wiki.documentfoundation.org/QA/Bibisect#Unable_to_start_soffice

Bibisected with win64-7.6 to 9c9a711ac5d8f32ac318d0e4ecab7b3a26bc2150
Update skia to m111

Indeed, in the crash report we see Skia stuff.

I won't add the committer as this is just about updating Skia.

Leonard: if you deactivate Tools - Options - LibreOffice - View - Use Skia for all rendering, you will not get the crash anymore.