Bug 161304 - context menu "Delete ~Columns" deletion needlessly duplicates ~Cut mnemonic "C", allow auto assignment for the Columns entry
Summary: context menu "Delete ~Columns" deletion needlessly duplicates ~Cut mnemonic "...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks: Shortcuts-Accelerators
  Show dependency treegraph
 
Reported: 2024-05-28 13:21 UTC by V Stuart Foote
Modified: 2024-05-30 08:38 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description V Stuart Foote 2024-05-28 13:21:07 UTC
For bug 114286, the column deletion strings were consolidated into GenericCommands.xcu and picked up a ~C fixed accelerator assignment. That conflicts with the <Ctrl>+C cut shortcut.

While the Row deletion strings were also changed to ~R, but that caused bug 155442 and was reverted kept their auto assignment and receive a _D accelerator.

Should simply remove the ~C from the Generic Command and remove the conflict with the Cut shortcut. 

https://gerrit.libreoffice.org/c/core/+/131680
Comment 1 V Stuart Foote 2024-05-28 13:24:07 UTC
Issue raised on User mail list by Ian Oliphant
Comment 2 Julien Nabet 2024-05-28 20:48:22 UTC
Defining shortcuts became quite complicated, you must take into account:
- letters chosen must be in the entry name
- letters may change depending on the language interface
- avoid duplicate letters
- there are some universal shortcuts expected (C to copy, P to print) at least for English and French, I don't know for other languages.
- people accustomed to MsOffice want to find same shortcuts (I can understand this)
- depending on the OS, keys (like "Command") may exist or not
...
I suppose I forget some constraints.
Comment 3 Heiko Tietze 2024-05-29 08:09:55 UTC
(In reply to V Stuart Foote from comment #0)
> That conflicts with the <Ctrl>+C cut shortcut.
You mean Alt+C. Nothing users would do often as the context menu is typically opened per right mouse button. And if you press keys, typing alt+C again is pretty simple. Another argument is the localization that allows (and usually does) changing the accelerator.

=> NAB
Comment 4 V Stuart Foote 2024-05-29 12:57:58 UTC
(In reply to Heiko Tietze from comment #3)
> (In reply to V Stuart Foote from comment #0)
> > That conflicts with the <Ctrl>+C cut shortcut.
> You mean Alt+C. Nothing users would do often as the context menu is
> typically opened per right mouse button. And if you press keys, typing alt+C
> again is pretty simple. Another argument is the localization that allows
> (and usually does) changing the accelerator.
> 
> => NAB

Sorry, misstated the issue. Neither <Ctrl>+C shortcut for Copy, nor the <Ctrl>+X for Cut are involved. Those legacy CUA/Apple/CDE keyboard shortcut norms are picked up in menu as annotation of the UNO.

Rather, it is the *unnecessary* duplicated assignment with "~" of mnemonic "C" both to "~Cut" a selected column and also to delete a selected column with "Delete ~Columns (for unprotected cells)" menu entry.

The key sequence is by column's context menu (right mouse) -> C, or  <Alt> + S -> C via the sheet menu.

This is reachable via keyboard movements, and is also an accessibility issue.

In this case, simply resolved by removing the "~" from the "Delete ~Columns (for unprotected cells)" associated with the uno.DeleteColumns UNO in .uno:GenericCommands.xcu, and allowing it to auto assign. Just as the handling for "Delete Rows (for unprotected cells)" .uno:DeleteRows still resident in CalcCommands.xcu
Comment 5 Heiko Tietze 2024-05-30 08:38:16 UTC
(In reply to V Stuart Foote from comment #4)
> The key sequence is by column's context menu (right mouse) -> C, or  <Alt> +
> S -> C via the sheet menu.
It is menu key (at least on my keyboard left of the right ctrl key) and 2x C.

> In this case, simply resolved by removing the "~" from the "Delete ~Columns...
Sounds okay but we should keep the ~Cut fix at the well established alt+C.

Ultimately still NAB but no objection to drop the mnemonic on ~Column.

officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu -> .uno:DeleteColumns