Bug 161364 - Add option to search not in either values or formulae but everywhere
Summary: Add option to search not in either values or formulae but everywhere
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Find-Search
  Show dependency treegraph
 
Reported: 2024-05-31 13:22 UTC by Orwel
Modified: 2024-06-21 13:19 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Orwel 2024-05-31 13:22:56 UTC
Description:
I do not know if it is possible, but Search in Scalc would be (for me) much more efficient if a possibility of Search "everything" (instead of Values/Formulae/Comments) would exist. Remember to change the value each time is pretty uncomfortable.

Steps to Reproduce:
1. Open sheet
2. CTRL+F


Actual Results:
Search in: Formulae/Values/Comments

Expected Results:
Search in: Everything/Formulae/Values/Comments


Reproducible: Always


User Profile Reset: No

Additional Info:
And if possible, the "everything" value could be the default one.
Comment 1 m_a_riosv 2024-06-01 00:12:28 UTC
+1, looks like a good request for me.
Comment 2 ady 2024-06-01 02:41:14 UTC
If this gets implemented (and I am not saying I am particularly in favor), instead of "Everything", I would rather see a different, more clear term.

The term "Everything" would be closer to _what_ you are looking for (as in "*" in wildcards).

Examples:

* Search in: All/Formulas/Values/Comments/Validity/Conditional_Format/Worksheet_name/...

* Search in: (All)/Formulas/Values/Comments/Validity/Conditional_Format/Worksheet_name/...

* Search (in): Everywhere/Formulas/Values/Comments/Validity/Conditional_Format/Worksheet_name/...


As for being the default setting, I would _not_ agree.
Comment 3 Heiko Tietze 2024-06-04 12:57:01 UTC
Ctrl+F is the quicksearch toolbar that follows the configuration of the F&R dialog, which opens on ctrl+H. And in fact we may add some option to find all.
Comment 4 V Stuart Foote 2024-06-19 12:16:34 UTC
+1, sure the 'Search in:' listbox selector on F&R dialog could benefit with addition of an 'All' as suggested by ady in comment 2.

(In reply to Heiko Tietze from comment #3)
> Ctrl+F is the quicksearch toolbar that follows the configuration of the F&R
> dialog, which opens on ctrl+H. And in fact we may add some option to find
> all.

Umm, does it? We've worked hard to keep the Quick Find unencumbered by Find & Replace settings. Bleed over from F&R has been a major annoyance for the Quick Find, i.e. see bug 115665 or bug 112270

Scope of search on the QF and I assume QFS is currently in "Values" which replaced the legacy in "Formula" quick search at 7.3 [1]

Consensus then was to make the Quick Find for values and to guide folks to the Find & Replace dialog for searching within Formulas. And to limit the options of the Quick Find to keep it light weight. See no reason to change for the TB or the Sidebar QFS.

=-ref-=
[1] https://gerrit.libreoffice.org/c/core/+/126490
Comment 5 Heiko Tietze 2024-06-20 07:45:09 UTC
We discussed the topic in the design meeting.

The new filter "All" (or "None" if we rename the option to Filter) or "Everywhere" is welcome. The QFS finds currently only Values (we may have a switch in the advanced settings) and should probably tweaked to return results from everywhere.
Comment 6 ady 2024-06-20 16:52:13 UTC
FWIW...

(In reply to Heiko Tietze from comment #5)
> We discussed the topic in the design meeting.

Sadly, I am quoted incorrectly in the Minutes from the UX/design meeting 2023-Jun-19.

I suggested to use a different terminology, specifically ***not*** "Everything".

I also hinted (as a relevant matter) that there are other areas in which Calc does not perform a search, so any such "All" terminology (or similar/equivalent term) could be a problem. How would you explain users that the current search on "All" will not provide results for those other areas? And if those areas are included in the future, how would you differentiate the current suggested enhancement with such future potential expansion? Although this is beyond the scope of this particular ticket, it is still relevant but it was not discussed in the meeting. Once again, the lack of advance user experience in spreadsheets influences the results in Calc.


Clearly I keep failing in communicating clearly and effectively.
Comment 7 Heiko Tietze 2024-06-21 09:53:07 UTC
(In reply to ady from comment #6)
> I suggested to use a different terminology, specifically *not* "Everything".
Sorry for this, both labels work for me but not a native speaker.

But essentially we agree on the wildcard metaphor, which the QFS should perform.

>Clearly I keep failing in communicating clearly and effectively.
Blame me for not reading carefully ;-)
Comment 8 ady 2024-06-21 13:19:57 UTC
(In reply to Heiko Tietze from comment #7)
> both labels work for me

I explicitly explained why they don't in comment 2.

And the second issue is still not even considered.

Let's assume a spreadsheet includes a custom Conditional Format using a formula ("Formula is"). When you search within formulas, the CF is not included in the search results. The same goes for Validity. When you add "All", the search results will not include those items either, until and unless those items are added to the F&R feature in some form (which advance users of spreadsheet would welcome, for sure).

In this scenario, some users will expect that "All" should provide such results too. Even if you reply to them "No, it is not included in the F&R feature", if later-on those items will be added at some point then the meaning of "All" will change – a matter that is always a problem – and then someone else will ask for "the same results as it used to be".

This is only one scenario, hinted in comment 2 with:

 "All/Formulas/Values/Comments/Validity/Conditional_Format/Worksheet_name/..." 

The F&R filter would then have to use check-boxes, for clarity and flexibility, instead of just having one "All".