Bug 115665 - Format in the CTRL+H search affects the CTRL+F search
Summary: Format in the CTRL+H search affects the CTRL+F search
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords:
: 147566 157744 (view as bug list)
Depends on:
Blocks: Find-Toolbar
  Show dependency treegraph
 
Reported: 2018-02-12 22:10 UTC by Eltomito
Modified: 2024-10-09 18:55 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eltomito 2018-02-12 22:10:27 UTC
Description:
Setting Format in the CTRL+H search dialog affects the search performed by the CTRL+F dialog.

This is similar to this former bug https://bugs.documentfoundation.org/show_bug.cgi?id=62601 but it isn't the same and it isn't fixed.


Steps to Reproduce:
1. Write "This is happiness." in a document (and don't put any font effects on it).
2. Open the CTRL+H search dialog
     and in Other options -> Format -> Font Effects,
     set "Effects:" to "Capitals"
3. Close the search dialog and try to do a CTRL+F search for the string "happiness".
   

Actual Results:  
"happiness" isn't found.


Expected Results:
"happiness" should be found.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 6.0.1.1
Build ID: 1:6.0.1~rc1-0ubuntu0.16.04.1~lo1
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group



User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Comment 1 ace_dent 2018-02-13 21:36:56 UTC
Reproduced as described.

Version: 6.0.1.1
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; 
Locale: en-GB (en_GB.UTF-8); Calc: group
Comment 2 Xisco Faulí 2018-02-27 11:49:55 UTC
Also reproduced in 

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4
Comment 3 QA Administrators 2019-02-28 03:52:02 UTC Comment hidden (obsolete)
Comment 4 Eltomito 2019-02-28 11:20:04 UTC
Yep, this bug is still there in LO 6.2.0.3.

Version: 6.2.0.3
Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 5 Cor Nouws 2020-01-16 13:50:00 UTC
where are the duplicates of this issue?
Comment 6 Eltomito 2020-01-16 14:25:33 UTC
Take a look at "See also: 62601 (https://bugs.documentfoundation.org/show_bug.cgi?id=62601)"
There's a bunch of them there.
Comment 7 Timur 2020-10-22 11:36:25 UTC
We may discuss if this is the bug at all. Also makes sense to keep setting from CTRL+H in CTRL+F.
For me, bug is that after setting from CTRL+H is cleared, search still doesn't work.
Comment 8 QA Administrators 2022-10-23 03:55:46 UTC Comment hidden (obsolete)
Comment 9 V Stuart Foote 2022-10-23 04:24:48 UTC
STR of comment 0 and result remain valid, settings made in the Find and Replace dialog are bleeding into the Find Bar search.  

Here it is a setting made to the Format -> Font Effects 'Case' values, when set they affect searches from the Find Bar.

@Jim and thoughts on connectivity between the Find Bar and settings of the Find & Replace dialog? And which, if any, should affect the Find Bar & Sidebar Navigator 'Repeat search' actions...
Comment 10 V Stuart Foote 2022-10-23 04:39:14 UTC
UX gave direction in see also bug 72080 -- the Find Bar query should be as simple (basic) as possible with no bleed over from the Find & Replace dialog--the dialog being used for any more demanding searches across the modules.
Comment 11 V Stuart Foote 2022-10-23 05:28:28 UTC
A bit off topic, but in context of doing something with Search support.

It would be nice to have ICU lib RegEx available to use from Find Bar ( bug 119200 ) but the consistency of no bleed over from the F&R dialog is better--as stated elsewhere no configuration of the Find Bar search that doesn't include visible control in the UI for it.

So, can make a case that establishing a consolidated search deck for the Sidebar ( bug 95405 ) would be a good way to move forward.  To expose the UI controls of the F&R dialog as content panels to fully configure the search. With a content panel to input the search strings. And content panels to hold results and reposition the canvas to focus at the results. Reuse the good stuff that Jim R. has been adding to SB Navigator deck.

Would add that for a SB based Search it would be better UX to have ability to detach the deck from the SB, like current secondary <F5> Navigator.

Or possibly to finally implement the SB framework needed ( bug 85905 ) to support detachable "tear away" SB decks. And eliminate the need for the <F5> Navigator duplicate, or any need to duplicate a new "Search" deck as for here. Instead just one of each but they could be torn away to float or to dock as user prefered.
Comment 12 Buovjaga 2023-10-27 13:11:25 UTC
*** Bug 157744 has been marked as a duplicate of this bug. ***
Comment 13 Jim Raykowski 2024-06-27 03:43:31 UTC
Proposed patch with UI test:
https://gerrit.libreoffice.org/c/core/+/169606
Comment 14 Commit Notification 2024-06-28 21:43:15 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3621ddfb9a490c58cfa70679d9bd89099a91e663

Resolves tdf#115665 Format in the CTRL+H search affects

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 V Stuart Foote 2024-10-09 12:09:23 UTC
*** Bug 147566 has been marked as a duplicate of this bug. ***
Comment 16 Jim Raykowski 2024-10-09 18:55:03 UTC
Using the STR I get the expected results of '"happiness" should be found.' with:

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b20e79494c8e7627e941343b0acc3dd74df6cb75
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

I must have forgot to mark this as Resolved Fixed :-o so I'll do it now :-).