Created attachment 195981 [details] gdb log file Issues with -a- Adding Elements to custom Theme doesn't work -b- Crash on opening Gallery after restart One bug report, since I expect them to be related, since: I made a fresh build after https://git.libreoffice.org/core/commit/0afb4cfc5ed1e926dfd287007c5a35585584daec (bug 162555) 1 - Added _TestTheme as gallery theme. 2 - Could 'add' elements via the UI (find files, add, ok) a. => But these were not visible. 3 - Closed and restarted, opened Impress. b. => Trying to open the Gallery reliably crashes. Attaching a backtrace.log. Also: removing /user/gallery and restarting makes the crashing disappear. Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2c9821d391c243ae83a408163f054d7a7a9a1daa CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
I can reproduce a similar issue with 1. Open any component 2. Go to the sidebar in the Gallery 3. Click on NEW 4. Click on Cancel -> Crash
Also reproduced in Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b93c179b44e8b76e036e6fba560325c5cceb7103 CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 10240); UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: threaded
However i can't reproduce it in Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 4ac1015b58a676324443de54188c16abf28d642f CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: x11 Locale: es-ES (es_ES.UTF-8); UI: en-US Calc: threaded nor in Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 480281006ff9ea43fe6e9c357909ed55d0011c8f CPU threads: 16; OS: Windows 8.1 X86_64 (6.3 build 9600); UI render: Skia/Raster; VCL: win Locale: el-GR (en_GB); UI: en-US Calc: threaded using the bisect repositories...
*** Bug 162565 has been marked as a duplicate of this bug. ***
(In reply to Xisco Faulí from comment #1) > I can reproduce a similar issue with > > 1. Open any component > 2. Go to the sidebar in the Gallery > 3. Click on NEW > 4. Click on Cancel > > -> Crash That scenario doesn't crash for me.
@Cor, are you using a build from https://dev-builds.libreoffice.org/daily/master/ or your own build ?
Neither scenario crashes for me, non-debug build from this morning. Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e1a4cdb3564c38ac1b75cc076c6762369e79137c CPU threads: 8; OS: Linux 6.10; UI render: default; VCL: gtk3 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: CL threaded
I did get the same "added objects not visible in theme", but after reopening Impress I could see the object I added.
No repro with a daily build either Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ea61bee5bcca7ad7cb05bc66fdf973c04b3d3396 CPU threads: 8; OS: Linux 6.10; UI render: default; VCL: gtk3 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded
(In reply to Xisco Faulí from comment #6) > @Cor, are you using a build from > https://dev-builds.libreoffice.org/daily/master/ or your own build ? Was a local build, with a fresh pull. (will try a daily soon)
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 8843081f91e206b4749b83b186caaceaf1f8c4e3 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Added '_TestTheme' Added svg files => not visible Closed LO with I think Gallery open in Impress. Now every time I start an Impress file .. > crash (4 or 5 reports just sent) Crashing stops by renaming user/galley/ to user/gallery_BAK/
A blind attempt on *crash* is https://gerrit.libreoffice.org/c/core/+/172280
By the way: my suspicion is some *specific* file added to the gallery, which gives a failure at acquire time. And it would indeed be nice to find out the specific object that does that, and have a separate bug on that - but crash itself is not nice, so my fix avoids the crash here (but the problematic object will likely still be not shown / processed).
Created attachment 196016 [details] Callstack by VS Start a new text document. Draw a "Star"-shape, for example. Drag it to a custom theme in the Gallery. In a debug build, I get a failed assertion, see attached call stack.
Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ed0ef16bb01225ab4ab1c6fd5a4959f76d77b11d tdf#162593: blind crash fix It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Cor Nouws from comment #0) > Issues with > -a- Adding Elements to custom Theme doesn't work > -b- Crash on opening Gallery after restart (In reply to Regina Henschel from comment #14) > Start a new text document. Draw a "Star"-shape, for example. Drag it to a > custom theme in the Gallery. In a debug build, I get a failed assertion, see > attached call stack. Wow, wow, wow! :-D Wait a second! If Cor and Regina were newbies, I would write something like > Dear Cor, dear Regina! Please note that the rule is to have a single bug per issue. > So please file anything except the crash after the reload as separate bug reports. > Thank you! But in this case, I actually don't know what to tell, so let me write this: Dear Cor, dear Regina! Please note that the rule is to have a single bug per issue. So please file anything except the crash after the reload as separate bug reports. Thank you! And Cor, could you please test if the crash-after-reload itself is fixed by the commit in comment 15. Thanks!
(In reply to Mike Kaganski from comment #16) > Dear Cor, dear Regina! > .. :) > And Cor, could you please test if the crash-after-reload itself is fixed by > the commit in comment 15. Thanks! With pleasure, dear Mike. For now, I tested if some specific image file caused the issue. Couldn't find it. What I did notice: some x-sequence of closing/changing status of Sidebar/Gallery, apparently completes some initiation work, with as result that there is no crash, also not if in a later run of LO, I add an image to the gallery theme, close LO directly and restart (which does cause the 1st crash).
(In reply to Mike Kaganski from comment #12) > A blind attempt on *crash* is https://gerrit.libreoffice.org/c/core/+/172280 Triggered a new daily build -> https://ci.libreoffice.org/job/lo_daily_tb_win/1861/ once it's ready I'll test it as well
Created attachment 196028 [details] zip of the user-gallery folder that reliably crashes on my side (In reply to Cor Nouws from comment #17) > What I did notice: some x-sequence of closing/changing status of > Sidebar/Gallery, apparently completes some initiation work, with as result > that there is no crash, also not if in a later run of LO, I add an image to > the gallery theme, close LO directly and restart (which does cause the 1st > crash). So attached a folder that does crash.. Reproducing the situation as such, is difficult.
(In reply to Xisco Faulí from comment #18) > (In reply to Mike Kaganski from comment #12) > > A blind attempt on *crash* is https://gerrit.libreoffice.org/c/core/+/172280 > > Triggered a new daily build -> > https://ci.libreoffice.org/job/lo_daily_tb_win/1861/ once it's ready I'll > test it as well Still reproducible in Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 6ea40d129e53c676970d3c0ca1db561394422419 CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 10240); UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: threaded
Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-24-8": https://git.libreoffice.org/core/commit/091f927d74cff4813c477e842b6658f93623bbb2 tdf#162593: blind crash fix It will be available in 24.8.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-24-8-1": https://git.libreoffice.org/core/commit/9b16eb9b44214852709f32c849ce415bc1f71e1d tdf#162593: blind crash fix It will be available in 24.8.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.