Description: "Donate" is not showing with middle vertical alignment. "Help" is shown with middle vertical alignment. Reproduced with Linux Mint Cinnamon. Not reproduced with Windows. Steps to Reproduce: 1. Open LibreOffice without any application nor file open 2. 3. Actual Results: "Donate" is not showing with middle vertical alignment. Expected Results: "Donate" showing with middle vertical alignment. Aligned with "Help" Reproducible: Always User Profile Reset: No Additional Info: Version: 24.8.0.3 (X86_64) / LibreOffice Community Build ID: 0bdf1299c94fe897b119f97f3c613e9dca6be583 CPU threads: 12; OS: Linux 6.8; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Flatpak Calc: threaded
Created attachment 196155 [details] LibreOffice Donate
On pc Debian x86-64 with master sources updated today, I could reproduce this. Just for the record, if we remove the icon with this patch for example: diff --git a/sfx2/source/dialog/backingwindow.cxx b/sfx2/source/dialog/backingwindow.cxx index 3c90d1ea2ade..f7bc57a3608e 100644 --- a/sfx2/source/dialog/backingwindow.cxx +++ b/sfx2/source/dialog/backingwindow.cxx @@ -196,7 +196,7 @@ BackingWindow::BackingWindow(vcl::Window* i_pParent) // tdf#161796 make the extension button show the donation page if (officecfg::Office::Common::Misc::ShowDonation::get()) { - mxExtensionsButton->set_from_icon_name(BMP_DONATE); // icon first needed on gtk3 to apply the label + //mxExtensionsButton->set_from_icon_name(BMP_DONATE); // icon first needed on gtk3 to apply the label OUString sDonate(SfxResId(STR_DONATE_BUTTON)); if (sDonate.getLength() > 8) { it's ok. Heiko: thought you might be interested in this one.
Created attachment 196163 [details] LibreOffice Impress Status Bar An image in the Status Bar in LibreOffice Impress may also need investigation. Perhaps the image to the left of that image which is correct can provide code pointers to fix the Status Bar image and the Donate text. Thank you
Weird, but can you try again with a nightly build? Made a change for bug 162615... but on system with KDE running with VCL=gtk3 it has a few pixels offset.
Let's try with a smaller icon.
Created attachment 196200 [details] LibreOffice Start Center "Open File" and "Writer Document" vertical alignment (In reply to Heiko Tietze from comment #5) > Let's try with a smaller icon. Can you please ensure that your fix has the text labels middle vertical alignment for the other icons too. Please see the read annotations on "Open File" and "Writer Document" in the attached screenshot. Thank you
Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/91f0b84675b20332e618922494809d75d49e4fd6 Resolves tdf#162732 - Donate label not vertical centered It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Óvári from comment #6) > Can you please ensure that your fix has the text labels... Actually I cannot fully reproduce the issue. Both on KDE/Qt as well openSuSE/Gtk3 in a VM show the donate label at max 1px shifted. Hard to spot. But if the smaller icon solves the issue for you (please review with the nightly build) I can check whether the statusbar icons are off-sized.
(In reply to Heiko Tietze from comment #8) > Actually I cannot fully reproduce the issue. Both on KDE/Qt as well > openSuSE/Gtk3 in a VM show the donate label at max 1px shifted. Hard to spot. Issue in screenshots attached to this issue are reproducible with the Cinnamon Desktop Environment (DE) which is different to KDE/Qt DEs. Please try Linux Mint 22 “Wilma” Cinnamon Edition available at https://linuxmint.com/edition.php?id=316 Thank you
Heiko Tietze committed a patch related to this issue. It has been pushed to "libreoffice-24-8": https://git.libreoffice.org/core/commit/b2094ca8fc71020b592235646e2b6cbfb4fdaf9c Resolves tdf#162732 - Donate label not vertical centered It will be available in 24.8.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Heiko Tietze committed a patch related to this issue. It has been pushed to "libreoffice-24-8-1": https://git.libreoffice.org/core/commit/0f1fa98ad49c2893cae1e363cb8c4964a01dd21d Resolves tdf#162732 - Donate label not vertical centered It will be available in 24.8.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 196287 [details] LibreOffice 25.2.0.0 Start Center
If we make the icon even smaller it becomes too unobtrusive. Any advice, Caolan?
Seems that gtk defaults to baseline alignment in these cases. Maybe as a workaround https://gerrit.libreoffice.org/c/core/+/173077 works?
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6ca8cf32d2f879dbead2f402eeef60edd3f0266e tdf#162732 force centered alignment for donate button text It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b4c52eb467b3f2164abfdece25830c8347f1ced9 Revert "Resolves tdf#162732 - Donate label not vertical centered" It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-24-8": https://git.libreoffice.org/core/commit/2f5a28d70cab9e9b1c89545dfe658c1c9d119904 tdf#162732 force centered alignment for donate button text It will be available in 24.8.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Heiko Tietze committed a patch related to this issue. It has been pushed to "libreoffice-24-8": https://git.libreoffice.org/core/commit/bc15e025060c37d73119ac9e8493a56eaed3e095 Revert "Resolves tdf#162732 - Donate label not vertical centered" It will be available in 24.8.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.