Bug 163992 - UI: Tooltip of the open documents list in navigator
Summary: UI: Tooltip of the open documents list in navigator
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.8.3.2 release
Hardware: All All
: medium enhancement
Assignee: BogdanB
URL:
Whiteboard: target:25.2.0
Keywords: difficultyBeginner, easyHack, skillDesign
Depends on:
Blocks: Navigator
  Show dependency treegraph
 
Reported: 2024-11-22 16:45 UTC by lol
Modified: 2024-12-04 21:08 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Tooltip navigator open documents list (21.60 KB, image/png)
2024-11-22 16:45 UTC, lol
Details
Tooltip navigator open documents list Draw (9.67 KB, image/png)
2024-11-25 13:31 UTC, lol
Details
Tooltip navigator open documents list Impress (12.37 KB, image/png)
2024-11-25 13:32 UTC, lol
Details
Tooltip navigator open documents list Calc (21.74 KB, image/png)
2024-11-25 13:32 UTC, lol
Details
Extended tooltip navigator open documents list Writer (21.08 KB, image/png)
2024-11-25 14:01 UTC, lol
Details
Extended tooltip navigator open documents list Calc (25.87 KB, image/png)
2024-11-25 14:01 UTC, lol
Details
Extended tooltip navigator open documents list Draw (10.58 KB, image/png)
2024-11-25 14:02 UTC, lol
Details
Extended tooltip navigator open documents list Impress (14.62 KB, image/png)
2024-11-25 14:02 UTC, lol
Details

Note You need to log in before you can comment on or make changes to this bug.
Description lol 2024-11-22 16:45:27 UTC
Created attachment 197721 [details]
Tooltip navigator open documents list

The text of the tooltip of the open documents list in the navigator shows only "document". On the help page for the navigator 
https://help.libreoffice.org/24.8/en-GB/text/swriter/01/02110000.html?System=WIN&DbPAR=WRITER 
the list is named "Open documents". 
So the tooltip should also show "Open documents".

Steps to Reproduce:
1. Open Calc
2. Open the menu View
3. Click on Navigator
4. Hover over the open documents list

See also attached picture.

Version: 24.8.3.2 (X86_64) / LibreOffice Community
Build ID: 48a6bac9e7e268aeb4c3483fcf825c94556d9f92
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Vulkan; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded
Comment 1 Nicole A. 2024-11-22 21:32:14 UTC Comment hidden (obsolete)
Comment 2 Nicole A. 2024-11-22 21:34:06 UTC
Hello,

Thank you for reporting the bug. I can confirm that the bug is present in LibreOffice version 24.8.2.1 (current version) and in 25.2.0.0 (master build).

Master Build

Version: 25.2.0.0.alpha0
TinderBox: MacOSX-aarch64@tb92-TDF, Branch:master, Time: 2024-11-06 05:23:09

As a note, this may be more of an enhancement then a bug but I have updated the status to "New" still. I see the difference from the help page shows "Open documents" but when hovering over the document dropdown in the navigator show's "document".
Comment 3 BogdanB 2024-11-23 20:37:21 UTC
I can do the change, if aproved.
Comment 4 BogdanB 2024-11-23 20:40:44 UTC
If aproved, I found this as the location of the string.
sw/uiconfig/swriter/ui/navigatorpanel.ui:
<property name="tooltip-text" translatable="yes" context="navigatorpanel|documents|tooltip_text">Document</property>
Comment 5 BogdanB 2024-11-23 20:43:20 UTC
But as a sugestion for a new name I propose:
- Opened documents
- Documents in use
- View documents
Comment 6 Heiko Tietze 2024-11-25 12:12:23 UTC
For Calc it is sc/uiconfig/scalc/ui/navigatorpanel.ui, showing "Displays the names of all open documents." The label "Documents" is what I get in Writer (and your screenshot shows this module too). To save the l10n team from unnecessary work I suggest to use the same label.
Comment 7 lol 2024-11-25 13:31:19 UTC
Created attachment 197775 [details]
Tooltip navigator open documents list Draw
Comment 8 lol 2024-11-25 13:32:10 UTC
Created attachment 197776 [details]
Tooltip navigator open documents list Impress
Comment 9 lol 2024-11-25 13:32:33 UTC
Created attachment 197777 [details]
Tooltip navigator open documents list Calc
Comment 10 lol 2024-11-25 13:43:26 UTC
The attachment 197721 [details] shows Writer. I mixed it up.

For Writer (attachment 197721 [details]), Calc (attachment 197777 [details]), Impress  (attachment 197776 [details]) and Draw (attachment 197775 [details]) the tooltip shows document.

I suggest "Opened documents" for the text of the tooltip as it is used on the help page.
Comment 11 lol 2024-11-25 14:01:11 UTC
Created attachment 197779 [details]
Extended tooltip navigator open documents list Writer
Comment 12 lol 2024-11-25 14:01:44 UTC
Created attachment 197780 [details]
Extended tooltip navigator open documents list Calc
Comment 13 lol 2024-11-25 14:02:16 UTC
Created attachment 197781 [details]
Extended tooltip navigator open documents list Draw
Comment 14 lol 2024-11-25 14:02:50 UTC
Created attachment 197782 [details]
Extended tooltip navigator open documents list Impress
Comment 15 lol 2024-11-25 14:10:49 UTC
The tooltip "Displays the names of all open documents." is showing when extended tips is activated. 

There are different extended tips for most of the module.

Calc attachment 197780 [details]
Draw attachment 197781 [details]
Impress attachment 197782 [details]
Writer attachment 197779 [details]
Comment 16 V Stuart Foote 2024-11-25 16:38:07 UTC
The list box on the Navigator SB deck is module specific and holds just those documents as opened for the *current* module.

So yes, tool-tip could be a module specific translated string, e.g in Calc -- "Open spreadsheets", in Impress -- "Open presentations", in Writer -- "Open documents". 

With a corresponding (translated) extended tool-tip text for each of the modules.

Compare how the SB Navigator's lb differs from the main menu's 'Window' listing of open documents. The Window menu list shows open documents of all modules, and allows UI focus to any of them, but has no tooltip.

But, I question if the Navigator list box should show open documents from all modules--with a generic "Document" tool-tip, or remain module specific and receive module specific tool-tips. I'd rather have the SB Navigator lb able to move UI focus to the other modules, and keep the generic tool-tip.

If it remains module specific--then tool-tip should probably reflect the module.
Comment 17 Heiko Tietze 2024-11-26 08:29:09 UTC
Plenty of suggestions, the doer may decide. Easyhack with code pointer in comment 4.
Comment 18 BogdanB 2024-11-26 09:11:21 UTC
Change is in gerrit
https://gerrit.libreoffice.org/c/core/+/177321

Even if it involves changes for translators, I also made changes for Calc and Impress. Feel free to comment on gerrit.
Comment 19 lol 2024-11-26 10:49:03 UTC
I like the idea from V Stuart Foote.
If the tooltips are module specific we should use the opportunity to make the tips which fits the module.

My suggestions

Calc
short tip "Opened spreadsheets"
extended tip "Lists currently open spreadsheets."

Draw
short tip "Opened drawings"
extended tip "Lists currently open drawings."

Impress
short tip "Opened presentations"
extended tip "Lists currently open presentations."

Writer
short tip "Opened documents"
extended tip "Lists currently open documents."
Comment 20 BogdanB 2024-11-26 11:04:36 UTC
(In reply to lol from comment #19)
> I like the idea from V Stuart Foote.
> If the tooltips are module specific we should use the opportunity to make
> the tips which fits the module.
> 
> My suggestions
> 
> Calc
> short tip "Opened spreadsheets"
> extended tip "Lists currently open spreadsheets."
> 
> Draw
> short tip "Opened drawings"
> extended tip "Lists currently open drawings."
> 
> Impress
> short tip "Opened presentations"
> extended tip "Lists currently open presentations."
> 
> Writer
> short tip "Opened documents"
> extended tip "Lists currently open documents."

Ok. I will give another try later.
Comment 21 BogdanB 2024-11-26 11:07:56 UTC
Heiko, I found just sc, sw, sd. The Impress is using the same? Can you give me a code pointer for the fourth one?
Comment 22 Heiko Tietze 2024-11-26 11:32:30 UTC
Draw/Impress seem to use the same panel.
Comment 23 BogdanB 2024-11-26 12:10:55 UTC
> > My suggestions
> > 
> > Calc
> > short tip "Opened spreadsheets"
> > extended tip "Lists currently open spreadsheets." - 

- I changed just this one, documents replaced to spreadsheets.

> > 
> > Draw
> > short tip "Opened drawings"
> > extended tip "Lists currently open drawings."
> > 
> > Impress
> > short tip "Opened presentations"
> > extended tip "Lists currently open presentations."
> > 

If Impress and Draw have a common .ui file, I can not change that.

> > Writer
> > short tip "Opened documents"
> > extended tip "Lists currently open documents."
> 
> Ok. I will give another try later.
Comment 24 Commit Notification 2024-11-26 17:21:37 UTC
Bogdan Buzea committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/82417b47bdeffd8f1051819bda94cd33a9fa48fa

tdf#163992 Improve tooltip for opened documents

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 25 lol 2024-11-27 11:11:57 UTC
Thanks BogdanB for fixing this as far as possible. I will create a new bug report to separate the strings in Draw and Impress.
Comment 26 lol 2024-12-04 15:37:24 UTC
Verified. Checked with

Version: 25.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: afc441e65107ed808c399b65f4737d25541cdf77
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Vulkan; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded