Bug 164171 - Separate strings for tooltips of the open documents list in navigator
Summary: Separate strings for tooltips of the open documents list in navigator
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.8.3.2 release
Hardware: All All
: medium enhancement
Assignee: BogdanB
URL:
Whiteboard: target:25.8.0
Keywords: difficultyBeginner, easyHack, skillDesign
Depends on:
Blocks: Navigator
  Show dependency treegraph
 
Reported: 2024-12-04 21:01 UTC by lol
Modified: 2024-12-21 09:46 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description lol 2024-12-04 21:01:30 UTC
This is a followup bug report of bug 163992.

Draw and Impress use the same strings for the short and extended tooltips for the open documents list in the navigator.
(see comment https://bugs.documentfoundation.org/show_bug.cgi?id=163992#c21)

Draw and Impress should use different strings for the short and extended tooltips so the tooltips are module specific.
(see comment https://bugs.documentfoundation.org/show_bug.cgi?id=163992#c16 and https://bugs.documentfoundation.org/show_bug.cgi?id=163992#c23)

Version: 24.8.3.2 (X86_64) / LibreOffice Community
Build ID: 48a6bac9e7e268aeb4c3483fcf825c94556d9f92
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Vulkan; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded
Comment 1 BogdanB 2024-12-05 05:23:36 UTC Comment hidden (obsolete)
Comment 2 BogdanB 2024-12-05 06:25:15 UTC
New, based on previous comments from bug 163992.
Comment 3 Heiko Tietze 2024-12-05 08:35:12 UTC
(In reply to lol from comment #0)
> Draw and Impress should use different strings for the short and extended
> tooltips so the tooltips are module specific.
What's wrong with "Lists currently open documents."? IOW, what justifies the effort to change this into "Lists currently open presentations." and "Lists currently open drawings."?
Comment 4 lol 2024-12-05 10:34:39 UTC
(In reply to Heiko Tietze from comment #3)
> What's wrong with "Lists currently open documents."? IOW, what justifies the
> effort to change this into "Lists currently open presentations." and "Lists
> currently open drawings."?

For Calc and Writer there are different strings already. Draw and Impress use the same string. So why don't make the string for Draw and Impress also module specific? Why only for Calc and Writer?

The list shows only the documents for the current module. If the tooltip shows "text documents, spreadsheets, presentations and drawings" the user get the advice, that only the documents of the current module are in the list.
Comment 5 Heiko Tietze 2024-12-05 11:05:12 UTC
(In reply to lol from comment #4)
> So why don't make the string for Draw and Impress also module specific?
Because it's effort? At least me I don't know how figure out what document type calls the ctor in sd/source/ui/dlg/navigatr.cxx in order to set mxLbDocs->set_tooltip_text() respectively. Perhaps in the HandleContextChange() method.

> If the tooltip shows...
As a compromise, do you think users understand better that documents are from the current module with "Lists currently open presentations or drawings."?
Comment 6 lol 2024-12-20 11:50:33 UTC
(In reply to Heiko Tietze from comment #5)

> Because it's effort? At least me I don't know how figure out what document
> type calls the ctor in sd/source/ui/dlg/navigatr.cxx in order to set
> mxLbDocs->set_tooltip_text() respectively. Perhaps in the
> HandleContextChange() method.

Maybe somebody can help you with this.

> > If the tooltip shows...
> As a compromise, do you think users understand better that documents are
> from the current module with "Lists currently open presentations or
> drawings."?

I've checked the list of the navigator in Draw and Impress.
The list for the open documents in Impress and Draw shows drawing and presentations together as in opposite to Calc and Writer where only text documents or spreadsheets are shown.

So you suggestion is correct. Then let's do it so.
Comment 7 Heiko Tietze 2024-12-20 13:20:31 UTC
(In reply to Heiko Tietze from comment #5)
> "Lists currently open presentations or drawings."

(In reply to lol from comment #6)
> ...let's do it so.

Bogdan, do you want to finish your work?
Comment 8 BogdanB 2024-12-20 13:53:45 UTC
(In reply to Heiko Tietze from comment #7)
> (In reply to Heiko Tietze from comment #5)
> > "Lists currently open presentations or drawings."
> 
> (In reply to lol from comment #6)
> > ...let's do it so.
> 
> Bogdan, do you want to finish your work?

I prefer not. Does not seem easy.
Comment 9 Heiko Tietze 2024-12-20 14:50:55 UTC
(In reply to BogdanB from comment #8)
> Does not seem easy.
In sd/uiconfig/simpress/ui/navigatorpanel.ui for id="documents" change the value <property name="tooltip-text" from "Open Documents" to "Lists currently open presentations or drawings.". 

Prototype: https://gerrit.libreoffice.org/c/core/+/177321
Comment 10 BogdanB 2024-12-20 16:37:20 UTC
Change is in gerrit

https://gerrit.libreoffice.org/c/core/+/178953
Comment 11 Commit Notification 2024-12-21 09:41:46 UTC
Bogdan Buzea committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/186e997c559c7e5d4b9462f9b4be6a935cdd04cd

tdf#164171 Improve tooltip for Open Documents

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.