Bug 166587 - FILEOPEN PPTX: Gluepoints of shape UpArrow are missing
Summary: FILEOPEN PPTX: Gluepoints of shape UpArrow are missing
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.4 all versions
Hardware: All All
: medium normal
Assignee: Xisco Faulí
URL:
Whiteboard: target:25.8.0
Keywords: bibisected, bisected, implementationError
Depends on:
Blocks: OOXML-Shapes PPTX-line-connector-import
  Show dependency treegraph
 
Reported: 2025-05-15 00:18 UTC by Regina Henschel
Modified: 2025-05-20 20:02 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
shape with connectors and screenshot (26.87 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2025-05-15 00:18 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2025-05-15 00:18:32 UTC
Created attachment 200818 [details]
shape with connectors and screenshot

The shape "upArrow" has object specific gluepoints. They are not imported. Instead the default four gluepoints are used.

The attached file has the shape and connector lines to the shape and a screenshot of how it looks in PowerPoint. Notice that the connectors to the arrow head parts left and right are not connected when you open the file in LibreOffice.
Comment 1 Xisco Faulí 2025-05-15 07:39:32 UTC
Regression introduced by:

commit cbf66ec3e60d07efb7c3cceed9b4f0fb4f0510c8	[log]
author	Tibor Nagy <nagy.tibor2@nisz.hu>	Thu Mar 10 08:42:12 2022 +0100
committer	László Németh <nemeth@numbertext.org>	Tue Mar 29 16:12:45 2022 +0200
tree c7e02c1e50525e42d7b15d000398631be3c7c697
parent bc601af632861896bdfaa14c96daf1a7ffdfcf71 [diff]

tdf#89449 PPTX import: fix line connectors

Bisected with: linux-64-7.4
Comment 2 Regina Henschel 2025-05-15 09:29:49 UTC
Other block arrow types are affected as well.

There was a similar error with flowchart shapes in bug 157216. That was fixed by editing the file https://opengrok.libreoffice.org/xref/core/oox/source/drawingml/customshapes/oox-drawingml-cs-presets

Perhaps the script, that was originally used to generate that file, needs to be improved to automatically generate the { Name = "GluePoints"...} and { Name = "GluePointLeavingDirections"...} parts?


It is not really a regression, because prior to the commit, the connectors were not imported as connectors at all.
Comment 3 Xisco Faulí 2025-05-20 16:54:16 UTC
Hi Regina,
Thanks for the info in comment 2, it was really valuable.
Proposed fix: https://gerrit.libreoffice.org/c/core/+/185572
Comment 4 Commit Notification 2025-05-20 20:02:52 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6771eb320ca0f550caecdbe6fe6b263e89cf6ac1

tdf#166587: PPTX: add "glue points" to upArrow shape

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.