Bug 36308 - [UI]Change behaviour for "tree view" on Writer's Navigator
Summary: [UI]Change behaviour for "tree view" on Writer's Navigator
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.5.5.3 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:6.1.0
Keywords:
: 88371 113961 (view as bug list)
Depends on:
Blocks: Navigator
  Show dependency treegraph
 
Reported: 2011-04-16 13:14 UTC by RGB
Modified: 2019-10-10 19:23 UTC (History)
10 users (show)

See Also:
Crash report or crash signature:


Attachments
lots of same-looking headings at the same level messes up navigator tree view (8.79 KB, application/vnd.oasis.opendocument.text)
2011-04-23 11:17 UTC, Arno Teigseth
Details

Note You need to log in before you can comment on or make changes to this bug.
Description RGB 2011-04-16 13:14:58 UTC
This is a follow up from discussions on the design mailing list (http://nabble.documentfoundation.org/About-the-Navigator-tp2701544p2701544.html)

LibO adds a “Tree view” for the Navigator. The tree view gives immediate feedback about the document structure... But this tree view also adds some usability issues.

For example, consider the case in which you have, say, four levels of headings and you are now on a level three (a sub-subsection). Now, you want to go for a moment to the top level for this part (the Chapter) and as consequence you double click on the corresponding entry on the navigator. You will be “teleported” there immediately, which is OK... but at the same time the tree view for that entry will collapse, hiding the sublevels and forcing you to reopen them one by one to return to the original position, which is bad. On this common user case the tree-view becomes counter productive.

A good change could be to modify the tree view behaviour in order to separate the opening/closing of each level from the “jump to” feature. For example:

- Click (on the Navigator text entry) → Select
- Double–Click (on the Navigator text entry) → Jump
- Something else to open/close the corresponding entry on the tree view.

An option to open all branches at once is highly desirable too.

Also, the tree view should remember its status between sessions, keeping opened the branches that were opened by the user.


NOTE: even if this request ask for different items, all of them affect only one feature (the tree-view) and for that reason I filled them on only one issue.
Comment 1 Christoph 2011-04-16 14:17:20 UTC
(In reply to comment #0)
> - Something else to open/close the corresponding entry on the tree view.

This is / should be possible with the expand/collapse controls (small triangles, or plus/minus-signs - according platform).

> An option to open all branches at once is highly desirable too.

The "Show heading levels" dropdown "filter" should be converted into
a command list. So if the user sets "5", then all the headings until
level 5 should be expanded. All further levels will still be expandable
by the user. If the user sets "1", then all headings are collapsed but
the main headings. Still, the user may expand them manually - there is
no hidden pre-filtering.
Comment 2 Arno Teigseth 2011-04-23 11:15:17 UTC
Something related to this bug: 
If you have a document with "same-looking headings", you can't immediately click something on the third level to select it, no matter how many times you click it. You will need to click the parent heading first, then the subheading.

You ask, "why create two same-looking headings? Aren't headings supposed to be unique?" Yes. But in my project I have Heading1:"Collection header". Heading2:"Book header"(Repeats among collections) and heading3: chapter number (repeats in every single book).

I'll try and upload an extreme case example, try navigating around using the navigator, and close/open with the triangle/arrow icons, feel the frustration.

OK I see my case is a bit strange, but it could be fixed sometime :D
Comment 3 Arno Teigseth 2011-04-23 11:17:20 UTC
Created attachment 45996 [details]
lots of same-looking headings at the same level messes up navigator tree view

The attached document is an extreme case.

The bug is "fixed" by making sure all headings on a specific level are unique document-wide.
Comment 4 Cor Nouws 2011-08-22 07:15:30 UTC
(In reply to comment #2)
> OK I see my case is a bit strange, but it could be fixed sometime :D

You say it :-)
Would be good if you create a separate bug for that enhancement, IMHO.
Comment 5 Cor Nouws 2011-08-22 07:16:45 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > An option to open all branches at once is highly desirable too.
> 
> The "Show heading levels" dropdown "filter" should be converted into
> a command list. So if the user sets "5", then all the headings until
> level 5 should be expanded. All further levels will still be expandable
> by the user. If the user sets "1", then all headings are collapsed but
> the main headings. Still, the user may expand them manually - there is
> no hidden pre-filtering.

What I would suggest: cltr-Arrow to open/close all the nodes of a lower level
Comment 6 Björn Michaelsen 2011-12-23 12:03:54 UTC Comment hidden (obsolete)
Comment 7 RGB 2011-12-23 16:58:35 UTC
The feature requested is not implemented on 3.5 beta2.
Comment 8 Paul Weiss 2012-08-17 20:38:27 UTC
Being able to set LO Writer to display all headings in the Navigator as a remembered setting is crucial for me to be able to use the program. For me the importance is "highest", but I just upped it to "high". :-) Since this is a regression from OOo, I also changed this from "enhancement" to "normal". I updated version and platform.
Comment 9 Paul Weiss 2012-08-19 17:05:11 UTC
I'm not a programmer, but am happy to help in other ways--testing, documentation, etc.
Comment 10 QA Administrators 2015-06-08 14:43:08 UTC Comment hidden (obsolete)
Comment 11 Cor Nouws 2015-06-22 12:10:37 UTC
still not changed
Comment 12 Jim Raykowski 2018-01-02 00:57:54 UTC
Hi All,

Here is a patch
https://gerrit.libreoffice.org/#/c/47241

Comments welcomed
Comment 13 Heiko Tietze 2018-01-11 09:45:16 UTC
*** Bug 88371 has been marked as a duplicate of this bug. ***
Comment 14 Commit Notification 2018-01-11 10:30:55 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=582b2ed5ba25657afc2c2d45860899325b3b2450

tdf#36308 make double click not expand/collapse node in Navigator tree

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Jean-Baptiste Faure 2018-01-11 16:06:56 UTC
Nice change, thank you very much.
Please backport this commit to LO 6.0.

Best regards. JBF
Comment 16 Commit Notification 2018-01-15 21:30:10 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=77acf66a3414c46edecfbc04b65e4a507eb857cb

change Not to Dont in tdf#36308 fix

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Cor Nouws 2018-01-17 16:10:32 UTC
verfied in Version: 6.1.0.0.alpha0+
Build ID: 7a6df88f2579c4fcfa81eb27f6db9e8e21c9a6f8
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-01-14_22:46:48
Locale: nl-NL (nl_NL.UTF-8); Calc: group threaded

thanks a lot!
Comment 18 Thomas Lendo 2018-10-11 12:03:06 UTC
*** Bug 113961 has been marked as a duplicate of this bug. ***
Comment 19 Kaue 2018-11-10 11:37:02 UTC
The second part of the request wasn't filled: "An option to open all branches at once is highly desirable too". 
This is highly necessary for someone that needs to navigate along long documents.
Comment 20 Heiko Tietze 2018-11-10 13:12:58 UTC
(In reply to Kaue from comment #19)
> The second part of the request wasn't filled: "An option to open all
> branches at once is highly desirable too". 
> This is highly necessary for someone that needs to navigate along long
> documents.

Please open a new ticket. If a patch has been submitted the probability to attract developers is low; it's also good practice to have only one issue per ticket.

And finally close again please.
Comment 21 Xisco Faulí 2018-11-12 12:18:40 UTC
(In reply to Kaue from comment #19)
> The second part of the request wasn't filled: "An option to open all
> branches at once is highly desirable too". 
> This is highly necessary for someone that needs to navigate along long
> documents.

Please, create a follow-up bug for that.
Closing as VERIFIED FIXED
Comment 22 John 2019-10-09 19:05:57 UTC
Since there was no follow-up bug, I created it myself:

https://bugs.documentfoundation.org/show_bug.cgi?id=128058