Bug 49500 - FORMATTING: Applying style modification works only once
Summary: FORMATTING: Applying style modification works only once
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.4.0 release
Hardware: Other All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: BSA
Keywords:
: 62911 72791 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-05-04 10:22 UTC by rocku84+oob
Modified: 2017-05-22 13:46 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rocku84+oob 2012-05-04 10:22:57 UTC 
Problem description: 
When modifying a style and clicking apply to see the changes without closing modification window, only the first modification is in fact applied. All subsequent modifications after the first are not really applied -- after closing the style modification window and opening it again the changes are not "checked" either.

Steps to reproduce:
1. Right-click on a style and choose "modify"
2. Do some changes, click "apply"
3. Do some more changes, click "apply" - at this point bug is visible

Current behavior:
Only first style change is applied

Expected behavior:
All style changes should be applied

Platform (if different from the browser): 
              
Browser: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:12.0) Gecko/20100101 Firefox/12.0
Comment 1 Joel Madero 2012-09-16 23:22:32 UTC 
I can confirm this but with a slight modification. 

LO: Version 3.6.1.2 (Build ID: e29a214)

For me it works 100% of the time the first time but subsequent changes aren't always done - it's about a 50/50. When I do a change the 2nd time, it usually doesn't work, but then if I do a 3rd change on top of the 2nd change (without closing the dialog) it seems to work all the time (or close to all of the time). 

This is a pain and quite annoying. Confirming, prioritizing:

Minor: Makes it substantially harder to make professional quality work but not impossible, also work around is to close dialog and then apply a new one. 

Medium: Probably not affecting that many people as you have to be changing styles (already rare) and be doing it in a particular way (multiple times without closing dialog). But leaving at Medium instead of lower because it doesn't reflect well on LO to have this bug where things aren't consistent.
Comment 2 QA Administrators 2015-04-01 14:40:49 UTC Comment hidden (obsolete)
Comment 3 Goran Rakic 2015-04-02 15:11:50 UTC 
I can confirm that the bug is still present in LibreOffice 4.4.2

If some style changes are applied, and then the same setting is changed back to the old value as before the dialog was open, tha apply button will not work.

Steps to reproduce:
1. Type something
2. Right click and open the Edit style dialog
3. Go to Alignment tab
4. Change the Options to Right, click Apply - it works
5. Change the Options to Center, click Apply - it works
6. Now before closing the dialog, change the option back to Left, click Apply and it will not work

Clicking OK follows the Apply - it would not change the setting if reverted. One need to close and open the Edit style dialog again.

I guess there is some "diff" algorithm used for Apply/Ok buttons and that it compares changes against old values before the dialog was open, and does not reflect updates made with Apply while the dialog is still open. So reverting back to the old value behaves as "no change, continue".
Comment 4 Goran Rakic 2015-04-02 15:42:37 UTC 
The bug is present in LibreOffice 3.4.0rc1 when the Apply button was first added so this is not a regression.

A better bug title may be something like:
FORMATTING: Can not set previous value in Style dialog after Apply
Comment 5 Gordo 2015-04-18 15:13:44 UTC 
*** Bug 62911 has been marked as a duplicate of this bug. ***
Comment 6 Gordo 2015-04-19 12:00:51 UTC 
*** Bug 72791 has been marked as a duplicate of this bug. ***
Comment 7 Octavio Alvarez 2016-04-22 01:09:05 UTC 
Can't reproduce on 5.1.1.2 under Ubuntu 14.04. Can somebody else try to reproduce it? Is it fixed for everyone or just for me?

Other similar bugs like bug #66152, bug #88342 and bug #78342 seem to be fixed also. Please try to reproduce.
Comment 8 Michal Sylwester 2016-04-22 13:09:37 UTC 
I'm still seeing it (2nd apply does not work if reverts the first one to be specific), but I'm still on 5.0.5.2.
Comment 9 QA Administrators 2017-05-22 13:23:26 UTC Comment hidden (obsolete)
Comment 10 Matti 2017-05-22 13:46:01 UTC 
Not reproducable in LibreOffice 5.1.6 (Linux Mint). Seems to be OK.