Bug 54660 - FILEOPEN .docx (MSO2007) (OOXML) ignores wrap property 'Background'
Summary: FILEOPEN .docx (MSO2007) (OOXML) ignores wrap property 'Background'
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.3.0 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 58782 (view as bug list)
Depends on: 52208
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-08 06:07 UTC by Korrawit Pruegsanusak
Modified: 2014-02-28 12:52 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Background jpg and png shown fine (12.41 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2013-02-17 09:40 UTC, Rainer Bielefeld Retired
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Korrawit Pruegsanusak 2012-09-08 06:07:50 UTC
+++ This bug was initially created as a clone of Bug #52208 +++

Download attachment 64325 [details] from bug 52208

[Expected] blue rectangle and white rectangles are in background
[Actual] blue rectangle and white rectangles are *not* in background

Please see screenshot in attachment 64326 [details]

Status NEW due to bug 52208 comment 3
Comment 1 Korrawit Pruegsanusak 2012-10-17 11:11:08 UTC
Hello Miklos,

As you said in bug 52208, this "never worked", but my own build on linux on May 2012 worked (transparent shapes shown correctly), but now not work again. :-) So, I decided to do git bisect.

Note: daily builds on Windows -- on the near day that my own build worked (May 2012) -- didn't work. So, I'm not sure whether it is my luck to get linux build worked.

The bisect result is, this commit caused my own build to the not-working state. http://cgit.freedesktop.org/libreoffice/core/commit/?id=f837c4288cdae4921b3fb6747ba2e2cd5ce2dcd2
Comment 2 Korrawit Pruegsanusak 2012-10-17 11:44:41 UTC
(In reply to comment #1)
> http://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=f837c4288cdae4921b3fb6747ba2e2cd5ce2dcd2

I tried to revert all of it, and applied each hunk to see which exact hunk caused the problem. The result is: change in *only* following files caused this bug:

    oox/inc/oox/vml/vmlshape.hxx
    oox/source/vml/vmlshape.cxx

Anyway, after applying only these hunks, it breaks unit test for n#764005, in the second assert. That is, the n#764005 is now Opaque, which should not.

And this is now beyond my little knowledge ;) So, Miklos, could you please have a look? Thanks in advanced. :-)
Comment 3 Miklos Vajna 2012-10-17 21:11:24 UTC
Korrawit,

First, just to make it clear -- I *think* it never worked, but of course now that you proved it's a regression, I'm sure it did. Thanks for correcting me. :-)

I'll try to get to this one soon.

Miklos
Comment 4 Korrawit Pruegsanusak 2013-02-17 06:38:00 UTC
*** Bug 58782 has been marked as a duplicate of this bug. ***
Comment 5 Rainer Bielefeld Retired 2013-02-17 09:34:28 UTC
"Bug 60992 - FILESAVE as .docx ignores 'Background' property in 'Wrap-Through' of DRAW shape" might show that there is some more general misunderstanding concerning Wrap through - Background for Draw objects in .docx?

I do not understand why this bug depends on "Bug 52208 - [DOCX] FILEOPEN: additional empty page after a continuous section break at the end of document", what has been fixed [target:3.6.4], but this one still does exist.

The problem discussed here (Forgeground instead of background) with sample mentioned in original report is already visible in LibO 3.3.0, I think it never worked and I do not understand the discussion here concerning bug appearance.


@Miklós:
Are you planning to fix tis one or should we involve an additional developer?
Comment 6 Rainer Bielefeld Retired 2013-02-17 09:40:56 UTC
Created attachment 74969 [details]
Background jpg and png shown fine

I am a little doubtful concerning DUP Bug 58782, that's a picture (not Draw Element) anchored as character (where no  background option is available). This sample contains 2 pictures (jpg / png) with wrap throuth + background what are shown correctly in background when I open it with LibO 3.6.5 (and in MS WORD Viewer). I would prefer to leave Bug 58782 as separate bug if it's not proved without doubt that roots are the same like here.
Comment 7 Xisco Faulí 2014-02-28 12:52:08 UTC
I close this bug report as RESOLVED FIXED because it is no longer reproducible.
Tested again on:
   - Libreoffice 4.1.4.2 Build  ID: 0a0440ccc0227ad9829de5f46be37cfb6edcf72
   - Libreoffice 4.2.1.1 Build  ID: d7dbbd7842e6a58b0f521599204e827654e1fb8b
   - Libreoffice 4.3.0.0.alpha0 ID: f839b5dd16c05c0eda21345ec36ec0cb024eb732

Feel free to open this bug report again if you find that the bug is still reproducible under some special circumstances, etc.