Bug 56973 - UI: Copy / Paste sole sheet of a spreadsheet wrongly looks inactive
Summary: UI: Copy / Paste sole sheet of a spreadsheet wrongly looks inactive
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: lowest trivial
Assignee: Andreas Heinisch
URL:
Whiteboard: target:7.6.0 target:7.5.0.2
Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
: 100291 117441 119145 146691 (view as bug list)
Depends on:
Blocks: Cut-Copy Sheet
  Show dependency treegraph
 
Reported: 2012-11-11 07:40 UTC by Rainer Bielefeld Retired
Modified: 2023-01-25 17:00 UTC (History)
12 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot comparison (268.18 KB, application/download)
2013-02-11 06:05 UTC, Rainer Bielefeld Retired
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Bielefeld Retired 2012-11-11 07:40:17 UTC
Steps how to reproduce with parallel installation of Master "LOdev  3.7.0.0.alpha0+   -  ENGLISH UI / German Locale  [Build ID: 70ec82)]"  {tinderbox: @16, pull time 2012-11-09 00:53:19} on German WIN7 Home Premium (64bit) with separate User Profile for Master Branch:

1. Start LibO
2. Open New Spreadsheet using start center button
3. If Document contains more than 1 sheet:
   Menu 'tools -> Optiopns -> Calc -> Defaults' change 'Number of worksheets
   in new document" to 1 <ok>
   Close libo and restart from 1
4. type an "a" into cell A1
5. 'Right click sheet tab "Sheet1" -> Move/Copy sheet'
   Expected: Radio button "Move" greyd out, because it's not possible to
            move a sheet in a document only containing this sole sheet.
            Radio button "Copy" active and selected
   Actual:  Selected radio button "copy" is greyed out, looks inactive
6. <ok>
   > A uplicate of "Sheet1" will be added.

So the function works fine as expected, but UI wrongly looks as if copy would be impossible. The problem seems to be that both radio buttons are buttons are marked inactive by the same condition, but they need different ones for the "only 1 sheet" case.
Comment 1 Rainer Bielefeld Retired 2012-11-11 07:47:30 UTC
This problem is already [Reproducible] with "LibreOffice 3.3.0 RC4 - WIN7  Home Premium (64bit) German UI  [OOO330m19 (build 6 / tag 3.3.0.4)]" and OOo 3.1.1, so this problem is inherited from OOo.

One reason for the current behavior might be that in the past there only was a checkbox instead our 2 radio buttons, and there the only way was to mark the Checkbox inactive with checkmark if no selection is possible.

I wonder whether it is possible to mark some of the possible radio button selections inactive and other ones active? So may be this is not a bug report but an enhancement request?
Comment 2 Joel Madero 2013-02-11 04:31:45 UTC
Rainer - this one looks fixed to me on 3.6.4.3, going to mark as WFM. If I'm wrong, my apologies :)

Tested on: 

3.6.4.3 release Bodhi Linux

4.0.0.3 release on Windows 7
Comment 3 Rainer Bielefeld Retired 2013-02-11 06:02:25 UTC
The question was not whether it works, but whether UI looks intuitive. So here we have a design question.

Looks as reported in any of my Versions with any of my Profiles (or fresh new profile) until 4.1.0.0.+:

'Move/Copy sheet' for the only single sheet of a document shows up the expected dialog, but both radio buttons 'Action' are greyed out.

The question is whether that is in accordance with style guides, or even whether we have style guides for such cases.

Unfortunately I did not find a similar case with 2 radio buttons, but for example see attached screenshot comparison, wehre "greyed out" has different meaning.

I think we should try a better unification to make I more intuitive.

I will leave a comment at <libreoffice-ux-advise@lists.freedesktop.org>
Comment 4 Rainer Bielefeld Retired 2013-02-11 06:05:00 UTC
Created attachment 74579 [details]
Screenshot comparison

Please see Comment 3!
Comment 5 Stefan Knorr (astron) 2013-04-11 21:30:03 UTC
Agree with Rainer that this could use some looking through.

I guess it might be best to rename the option to Copy Sheet everywhere in this situation, i.e. context menu, window title. In the given situation, we could then also remove the confusing greyed out selector.
Comment 6 Joel Madero 2014-11-06 21:51:07 UTC
Never independently confirmed - moving to UNCONFIRMED.
Comment 7 raal 2014-11-20 22:42:16 UTC
I can confirm with Version: 4.4.0.0.alpha2+
Build ID: 2f342c61616418c6ad7303d7f5efa27a28378681
TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2014-11-16_00:33:40

Changing component to ux-advice to decide if implement.
Comment 8 Jacques Guilleron 2014-11-20 23:41:49 UTC
I reproduce too with 
LO 3.5.3.2 Version ID : 235ab8a-3802056-4a8fed3-2d66ea8-e241b80
LO 4.4.0.0.alpha1+ Build ID: a8c24b25fd9fb21097a08a22797bf61b59099ea1
TinderBox: Win-x86@39, Branch:master, Time: 2014-10-21_06:33:33
& windows 7 Home Premium.

regards,

Jacques
Comment 9 Joel Madero 2016-02-06 21:30:07 UTC
Bodhi Moksha
LibreOffice 5.0.2.5

Confirmed. 

Might be an interesting easy hack - requesting input.
Comment 10 Robinson Tryon (qubit) 2016-08-25 05:38:53 UTC Comment hidden (noise)
Comment 11 Heiko Tietze 2018-04-10 08:58:10 UTC
Disagree here. The radio buttons belong to the group 'Action' and since you cannot change it from copy, which is set correctly, it's correct to disable the whole group.
Comment 12 Mike Kaganski 2023-01-04 10:50:03 UTC
I don't see how this could be WORKSFORME (= confirmed to be a problem in some version, but got fixed in a later stage, by an unidentified commit), or otherwise questionable (with an easy fix possible in sc/source/ui/miscdlgs/mvtabdlg.cxx, dropping m_xBtnCopy->set_sensitive call in ScMoveTableDlg::SetForceCopyTable). Have people disagreeing with the proposal ever checked if such a change looked inconsistent/confusing, compared to the current situation, given the number of duplicates:

tdf#117441
tdf#119145
tdf#100291
tdf#146691

People *get confused* by this. And the solution it trivial and obvious. And there was no solid arguments against it.
Comment 13 Mike Kaganski 2023-01-04 10:50:15 UTC
*** Bug 117441 has been marked as a duplicate of this bug. ***
Comment 14 Mike Kaganski 2023-01-04 10:50:16 UTC
*** Bug 119145 has been marked as a duplicate of this bug. ***
Comment 15 Mike Kaganski 2023-01-04 10:50:21 UTC
*** Bug 100291 has been marked as a duplicate of this bug. ***
Comment 16 Mike Kaganski 2023-01-04 10:50:23 UTC
*** Bug 146691 has been marked as a duplicate of this bug. ***
Comment 17 Commit Notification 2023-01-05 16:07:04 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a8d3b8985a79c216c3c132fb2e6bb0f85a27831a

tdf#56973 - Copy/paste (single) sheet is checked but not enabled

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Andreas Heinisch 2023-01-05 16:09:39 UTC
Sry for taking an easy hack, but this "inconvenience" bothered me too for a long time now. I hope many users requests from my local high school will be gone now.
Comment 19 Commit Notification 2023-01-09 20:17:09 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/b551acd0a370809fc12e6552dad87447fe5d9dfd

tdf#56973 - Copy/paste (single) sheet is checked but not enabled

It will be available in 7.5.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 20 Laurent Balland 2023-01-25 17:00:43 UTC
(In reply to Commit Notification from comment #19)
> Andreas Heinisch committed a patch related to this issue.
> It has been pushed to "libreoffice-7-5":
> 
> https://git.libreoffice.org/core/commit/
> b551acd0a370809fc12e6552dad87447fe5d9dfd
> 
> tdf#56973 - Copy/paste (single) sheet is checked but not enabled
> 
> It will be available in 7.5.0.2.
Great! May you back-port it to 7.4 branch also?