Bug 57091 - FORMATTING: Allow more options for Allow all users when the sheet is protect
Summary: FORMATTING: Allow more options for Allow all users when the sheet is protect
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.6.3.2 release
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Cell-Sheet-Protection
  Show dependency treegraph
 
Reported: 2012-11-13 19:33 UTC by VLB
Modified: 2020-04-17 19:50 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description VLB 2012-11-13 19:33:09 UTC
In Excel is there more options for allow  all users when the sheet is protect.
In LO is only:
- Select protected cells
- Select unprotected cells

When there is addition for the next is fine:
- Format Cells
- Format Rows
- Format Columns
- Can use the sheet or document till a date in the future
Comment 1 Jean-Baptiste Faure 2012-11-13 21:43:44 UTC
Not a bug -> set priority to enhancement

Best regards. JBF
Comment 2 Julien Nabet 2012-12-05 19:10:19 UTC
*** Bug 56460 has been marked as a duplicate of this bug. ***
Comment 3 Joel Madero 2013-07-27 02:54:25 UTC
Thank you for reporting this enhancement request! I can confirm that this is a valid enhancement request on:
Version: 4.1.0.4 release
Platform: Bodhi Linux 2.2 x64
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + 
As I've been able to confirm the enhancement request I am marking as:

New (confirmed)
Enhancement
Medium - default seems appropriate



+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + 
LibreOffice is powered by a team of volunteers, every bug is confirmed (triaged) by human beings who mostly give their time for free. We invite you to join our triaging by checking out this link:
https://wiki.documentfoundation.org/QA/BugTriage

There are also other ways to get involved including with marketing, UX, documentation, and of course developing -  http://www.libreoffice.org/get-help/mailing-lists/. 

Lastly, good bug reports help tremendously in making the process go smoother, please always provide reproducible steps (even if it seems easy) and attach any and all relevant material
Comment 4 Gauthier 2020-04-11 13:28:04 UTC
Do we know is there is any progress / plan for this?

Some options have been added since v3.6 (when this issue was opened) but as of 6.4.2 some key ones are still missing, notably:
- format column (allowing to hide and unhide)
- format rows

These have been there in excel for while and would be great to have them in calc too.

Many thanks
Comment 5 Julien Nabet 2020-04-11 14:14:50 UTC
Some improvements have been made thanks to Kohei Yoshida on tdf#43535

I'm reading his patch right now but not sure to understand how it works.
See https://cgit.freedesktop.org/libreoffice/core/commit/?id=034be10413ed4915090678ad4f1d48596cf5e206
Comment 6 Julien Nabet 2020-04-11 14:35:05 UTC
Xisco/Heiko: what options should we add from UI point of view? I mean, we could multiply the number of cases

Regina: the options added by Kohei are in XML_NAMESPACE_LO_EXT, so not in ODF 1.2.
Comment 7 Gauthier 2020-04-13 23:48:29 UTC
I'm afraid I don't understand it either.

In terms of options, it would be great to add:

- allow to format columns:
   (allowing to hide / unhide columns)
   (allowing to resize columns)

- allow to format columns:
   (allowing to add / unhide rows)
   (allowing to resize rows)
Comment 8 Julien Nabet 2020-04-14 07:02:19 UTC
(In reply to Gauthier from comment #7)
> I'm afraid I don't understand it either.
> 
> In terms of options, it would be great to add:
> 
> - allow to format columns:
>    (allowing to hide / unhide columns)
>    (allowing to resize columns)
> 
> - allow to format columns:
>    (allowing to add / unhide rows)
>    (allowing to resize rows)

My previous comment wasn't for you but for 2 people I put in cc.
Comment 9 Heiko Tietze 2020-04-14 09:24:08 UTC
(In reply to Julien Nabet from comment #6)
> Xisco/Heiko: what options should we add from UI point of view?

I don't see much need for formatting. The point of sheet protection is to share some ready made content. Printing yes/no, Recalculation and updating data sources comes in my mind. All with PDF export in mind where printing, changing, and access is optional. And to complete this it would be nice to have parts of the document readonly or also hidden too, let's say the calculation method, but allow to insert variables. Think it's possible out of the box.

The summary reads more like granting access to a range of users (eg. admins vs. ordinary user, or *@foo.com +rw, *@bar.com +r-w). Sounds too complicated to me.

Nice topic for the UX people anyway, will add this to the weekly meeting.
Comment 10 Heiko Tietze 2020-04-16 13:44:13 UTC
We talked about this ticket and probably there is some insight in BZ. So we have height/width of col/rows in bug 67352 "Editing: Permit to change cell width/height on protected cell" and formatting in bug 57086 "FORMATTING: in a spreadsheet with partial protection: allow modifying cell styles that are not used on a protected sheet". 

Do you need more input, Julien?
Comment 11 Julien Nabet 2020-04-17 12:11:04 UTC
(In reply to Heiko Tietze from comment #10)
> We talked about this ticket and probably there is some insight in BZ. So we
> have height/width of col/rows in bug 67352 "Editing: Permit to change cell
> width/height on protected cell" and formatting in bug 57086 "FORMATTING: in
> a spreadsheet with partial protection: allow modifying cell styles that are
> not used on a protected sheet". 
> 
> Do you need more input, Julien?

It should be fine.
Reading the other tdfs, it seems we should at least adding these:
- Format columns
- Format rows
- Format cells

In Excel, there's also
- Insert hyperlinks
- Sort
- Use AutoFilter
- Use PivotTable reports
- Edit objects
- Edit scenarios
(see https://support.office.com/en-ie/article/lock-or-unlock-specific-areas-of-a-protected-worksheet-75481b72-db8a-4267-8c43-042a5f2cd93a)
Comment 12 Heiko Tietze 2020-04-17 13:19:22 UTC
(In reply to Julien Nabet from comment #11)
> Reading the other tdfs, it seems we should at least adding these:
> - Format columns
> - Format rows
> - Format cells

Why format columns but not rows? Would make this just one option for cells.

> In Excel, there's also
> - Insert hyperlinks
> - Sort
> - Use AutoFilter
> - Use PivotTable reports
> - Edit objects
> - Edit scenarios

Wonder what scenarios are covered with those options. An editable spreadsheet without sorting capabilities, pivoting... but no objection since more items in this list wont have a negative bearing on usability.
Comment 13 Julien Nabet 2020-04-17 13:35:12 UTC
(In reply to Heiko Tietze from comment #12)
> (In reply to Julien Nabet from comment #11)
> > Reading the other tdfs, it seems we should at least adding these:
> > - Format columns
> > - Format rows
> > - Format cells
> 
> Why format columns but not rows? Would make this just one option for cells.
??
I put "Format columns" and "Format rows" in my list.
About merging, I think it's distinct from rows and cells but not sure, I was just reading Excel example.

> 
> > In Excel, there's also
> > - Insert hyperlinks
> > - Sort
> > - Use AutoFilter
> > - Use PivotTable reports
> > - Edit objects
> > - Edit scenarios
> 
> Wonder what scenarios are covered with those options. An editable
> spreadsheet without sorting capabilities, pivoting... but no objection since
> more items in this list wont have a negative bearing on usability.
Ok good to know.
Comment 14 Julien Nabet 2020-04-17 19:50:55 UTC
It seems protection isn't well taken into account in sidebar part, see tdf#57102.
I gave a try but failed to understand why no error message appeared.

I think we should first fix sidebar bugs before adding new features which will be half broken because of sidebar.
Remark: there's also API which hasn't been taken into account (see https://bugs.documentfoundation.org/show_bug.cgi?id=43535#c17)